try/catch for localStorage calls about javascript-sdk HOT 6 CLOSED

It looks like we later added a bit of bullet-proofing around localStorage, if I'm reading the nature of this request.

Of course, feel free to re-open this Issue with additional info.

from javascript-sdk.

Thanks for raising this issue! Our team will look into it and get back to you as soon as we can. Can you tell us which version of the SDK you are using?

from javascript-sdk.

I suggest using an in memory cache when localstorage is not useable. We do this in all our sites, common workaround.

from javascript-sdk.

@MisterJimson Thanks for the suggestion. IMHO this kind of workaround is very dependent on the use case. It might work with your own code, but third party libs could depend on the persistence of the store and break. For example with Optimizely it could break your A/B tests.
So I prefer to handle it explicitly by use case, not with a catch all workaround.

from javascript-sdk.

@toser Sure, but are the A/B tests not already broken if an exception is thrown when the SDK tries to store a value?

from javascript-sdk.

@MisterJimson I don't have the insights how Optimizely works here. But in general it's better to not fake a working localstorage where it's actually just a memory store. This can cause strange behavior. Then it's better to let the browser throw an error and the lib handles the error itself.

from javascript-sdk.