Giter VIP home page Giter VIP logo

gamma-frontend's People

Contributors

alexisgauba avatar antoncoding avatar imgbot[bot] avatar kmkoushik avatar sasicodes avatar ugolino avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar

gamma-frontend's Issues

Allow burning of oTokens at same time as removing collateral or issuing at the same time as depositing

Is your feature request related to a problem? Please describe.
For an existing vault. - Its not possible to partially burn options against a vault and remove collateral in 1 step. Its not possible to easily know collateralization of that type of action as it is done in 2 steps. Its also not possible to add collateral and mint options in 1 step.

Describe the solution you'd like
I'd like the manage oToken tab to allow adjustments to both collateral (add or remove) + oTokens (allowing burns and mints)

Option chain for yToken collateralized options should be together and renamed (calls and puts)

Is your feature request related to a problem? Please describe.
We will potentially have both yUSDC and yETH collateralized ETH options (yUSDC for puts and yETH for calls). Right now the f/e seems to segregate options based on:

  1. ETH options collateralized by either ETH or USDC
  2. BTC options collateralized by either BTC or USDC
  3. ETH put options collateralized by yUSDC

Describe the solution you'd like
The option chain for ETH/yUSDC should probably be renamed to something like ETH/yToken or ETH, yEarn collateral and include both yETH collateralized calls as well as yUSDC collateralized puts.

We probably need some messaging around the differences between chain #1 and chain #3

Additional context
Screen Shot 2021-08-04 at 12 15 16 PM

Default to showing only options with liquidity

Is your feature request related to a problem? Please describe.
Currently the f/e defaults to showing all options, even those without liquidity

Describe the solution you'd like
Can we default to not showing options with 0 liquidity and allow people to see them all if they want via a checkbox or something?

This is reversing the flow currently which defaults to showing all options and allows people to filter out 0 liquidity options.

Describe alternatives you've considered

Additional context
Screen Shot 2021-08-13 at 5 00 32 PM

yUSDC exchange rate not taken into account on f/e

Describe the bug
For ETHUSDC/yUSDC put options, collateral is posted in yUSDC and the collateral required is based on the yUSDC/USDC exchange rate as well as the strike of the put. Right now the front end is assuming 1 yUSDC = 1 USDC, which is wrong and requires more collateral than is necessary.

A similar issue should exist for yETH collateralized calls if we add to f/e.

To Reproduce
Steps to reproduce the behavior:

  1. Go to ETH/yUSDC option chain.
  2. Click on the 2000 strike listed put bid and enter 1 for option size.
  3. Scroll down to collateral required section, which will say 2000 yUSDC, when it should be closer to 1874.5 yUSDC as 1 yUSDC = ~1.0669 USDC

Expected behavior
Expect the yUSDC required to be less than the USDC required for a put as 1 yUSDC is worth more than 1 USDC. The fx rate has to be taken into account here. A few ways to get the price are Margin calculator, the yUSDC token contract, or our pricer contract for yUSDC.

Screenshots
Screen Shot 2021-08-04 at 12 01 55 PM

Desktop (please complete the following information):

  • OS: macos big sur
  • Browser brave
  • Version 1.27.109

Dashboard gets confused if user tries to burn oTokens and withdraw collateral in different steps

  • A user had a short position of 20 oTokens
  • They bought oToken that reverted on 0x on-chain, but the position card thought it went through so it moved to the burn step. At the burn step he got the error that not enough oToken balance to burn. This makes sense because he had 0 oTokens since his buy txn failed.
  • Then he bought 20 oTokens on trade page. So he had 20 short oTokens and 20 long oTokens. The dashboard registered this as an untraded position.
    • I added adjust collateral and manage oTokens for untraded positions since close position wasn't letting him burn & remove collateral (button was just disabled)
  • After he burned position disappeared from the dashboard all together
  • Had user remove collateral from gamma portal

Need to make sure that the position does not disappear from active positions on burn, but only upon also removing collateral

Add underlying asset price history as default graph with no option selected

Is your feature request related to a problem? Please describe.
Before an option is selected we should display a graph of the asset price history instead of "select an option"

Describe the solution you'd like
Before an option is selected we should display a graph of the asset price history instead of "select an option"

Describe alternatives you've considered
Another option is having no blank space before an option is selected and moving the option chain downward

Additional context
screenshot2

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.