orange-hex / solpm Goto Github PK

Entry property of EntryViewModel is automatically binded to SelectedEntry property of the VaultViewModel which causes it to update instantly during editing, making it impossible to cancel the changes made to the entry.

VaultViewModel's edit command was supposed to pass a copy of the selected entry to EntryViewModel where it's Entry property would've gotten assigned the value of the selected entry and would return either nothing on cancel or the edited entry on save.

The EditEntry command can be viewed here:
https://github.com/JoiNNewtany/SolPM/blob/4ebc19c0536712b0bdcf7bb5f0c50147a6330721/SolPM.Core/ViewModels/VaultViewModel.cs#L291-L326

The EntryViewModel's save and cancel commands can be viewed here:
https://github.com/JoiNNewtany/SolPM/blob/4ebc19c0536712b0bdcf7bb5f0c50147a6330721/SolPM.Core/ViewModels/EntryViewModel.cs#L83-L92

A temporary workaround has been found to fix the issue.
Any help would be appreciated.

Before the vault is written to a file its contents need to be encrypted.
The problem is, however, that encryption requires the user's password and asking the user for the password every time they save the vault isn't the best solution.

I have implemented a temporary workaround for this issue in 5e9553c

Any help with this would be very appreciated.

Whenever the last character in any text control is erased, it doesn't update the binding resulting in the bound property keeping the last character. This breaks some data validation rules.

Whenever a data validation error occurs, the graphical element does not show any indication of it happening.
This may happen due to SecurePassword property being bound using a custom behavior. (SecurePasswordBindingBehavior.cs)