orbitalshell / orbital-shell Goto Github PK

implementation is incomplete regarding to:

• env not correctly initialized : a sub shell must be prepared to run the batch (that is the same for running any command)
• batch args not transmitted to the batch env
• instructional commands missing: if,else,test,...

implements object streams in addition to text streams that connects commands together in commands pipeline. should command specification have to be improved to specifiy this type of connectivity ?
a special pipeline syntax must be added to specify to pass command result to next command, instead of command output

bad case on filenames in the solution .sln

module -i to be completed (module install)

Expected behavior
Deploy nupkg in $modules except if already done

Describe the bug
The shortcuts is not supported completely. (like Control+C)

To Reproduce

1. ssh xxx@xxx
2. if ssh is waiting for response, Control-C will not work,

Expected behavior
Control-C works

Desktop (please complete the following information):

• OS: Windows 10 Pro

Describe the bug
Hooks that may be triggered several times could lead to unexpected module behavior 💣💣💣💣 : generally hooks crash and module isn't loaded. module loading chain is not canceled.

To Reproduce
load twice modules with:

> module -i {modulePath}

Expected behavior
hooks like MODULE INIT should not be triggered several times. Module should not have to handle this

add json settings support to kernel
initialize the shell environment vars

add other ci/cd cool target DOCKER

implements bash functions as c# script or shell script

linux deploy (thanks to @Yobatman38) : up and down arrows doesn't works in clr (command line reader)

Expected behavior
move in command history, that should be output just after the prompt, clearing any previous input/output

Desktop:

• OS: linux
• Version: Linux 5.4.0.65-generic (Unbuntu SMP)

like c# functions supported by the shell, we could run special batch of c# script.
simply share the CommandEvaluationContext, add supports for standards libs, add declaration of supplementary lib imports and runs the script in the c# script engine

member (not method) access is implemented, $VarNamespace[.MemberName], but seems to not work correctly anymore.
syntax for calling methods, passing parameters must be added
exec of method with passing results must be handled

was thinking of a default in variable name parser, but seems it is just a lake of variable name searching in namespaces, like if the _ namespace if never scanned by search var function.
see the code:

OrbitalShell-Kernel/Component/Shell/Variable/Variables.cs

/// <summary>
/// search in variables the path according to these precedence rules:
/// - absolute path
/// - path related to Local
/// - path related to Env
/// - path related to Global
/// </summary>
/// <param name="path"></param>
/// <returns></returns>
public bool Get(string path, out object value, bool throwException = true)
{
    var r = _dataRegistry.Get(path, out value)
    || _dataRegistry.Get(Nsp(VariableNamespace.local, path), out value)
    || _dataRegistry.Get(Nsp(VariableNamespace.global, path), out value)
    || _dataRegistry.Get(Nsp(VariableNamespace.env, path), out value);
    if (!r && throwException)
        throw new VariablePathNotFoundException(path);
    return r;
}

there is no search in:

VariableNamespace._

what is strange is that search in absolute path failed for _.{..}

to reproduce:

> echo $_./

⚠️ the use of caracter '_' should be a source of councerns since it is also used as namespace separator encoding in Enums that define variables namespaces and names

The rm command does'nt works properly at all
stupid erros coz try to delete several times the same items + few less rights in windows terminal/any debugger (manifest should elevate privileges but seems to not be supported in .net core)

To Reproduce

> mkdir folderName
> rm folderName -r -v

💥 🔎 the folder is not erased

if not empty:

removed drw--- Feb 19 14:33 C:/Users/franc/Documents/ORBITAL-SHELL/myrep/folder
One or more errors occurred. (Could not find a part of the path 'C:\Users\franc\Documents\ORBITAL-SHELL\myrep\folder\hello world.txt'.)

💥 🔎 files and sub-folders deleted, but folder is not erased

Expected behavior
no error, anything deleted

context

the complemented is implemented in:

https://github.com/OrbitalShell/Orbital-Shell/blob/master/OrbitalShell-Kernel-Commands/Commands/FileSystem/FileSystemCommands.cs

implementation of pipelines command sequences && || , conditional (only if previous command succeed) or not : |
partially implemented.

implements syntax in command line parser and link to existing grouping of commands in command line processor.
syntax is ( command1 args1 ; ... ; commandn argsn )

command alias should respect bash posix

currently

alias {aliasName} {aliasText} 

Expected

alias {aliasExpression} 

with alias expression := aliasName = aliasText

issue

variables are substituted because they appears in a command parameter string ... it would be better if the substitution of variables is avoid in that case, thus the evaluation of parameters can be done when executing the alias text, otherwise the substitution is done twice (actual case)

add external module and kernel module auto-update feature (including module update all feature)

is implemented: set varName Value
wished:
$varName=Value
$varName=variableExpression
variable expression may be parsed by C# script

installed and activated modules must be loaded by the kernel

activate shell profile with module -i command ?
introduce a module list with activation state (preferred) ?

add syntax:
commandName commandArgs &
and do not wait end of exec (current case) for respecting consign &

colorize input string at command line reader

needs the parser word identification (like issue #7 )

add CD auto nuget deployment in NUGET and secondary to GITHUB

prior to NUGET

should take place in worflow :

merge to master, version increment, successfull build
-> so push new nupkg

auto complete with TAB at command line reader input

needs a thesaurus of words provided by the kernel and any component that contains known words classified by category. the command line parser must provides the word category

implements support of streams redirects in command line.
partially implemented. needs to be completed. related to pipeline processor (pp)

example of need of DI: see

        /// <summary>
        /// register a kernel-hook
        /// </summary>
        /// <param name="context">command evaluation context</param>
        /// <param name="mi">hook method info</param>
        public void RegisterHook(
            CommandEvaluationContext context,
            string name,

            MethodInfo mi)
        {
            object owner = _GetInstance(mi.DeclaringType);      // TODO: having no instance, we MUST use DI to share INSTANCES
            var hs = new HookSpecification(name, owner, mi);
            _hooks.AddOrReplace(name, hs);
        }

👁️ https://github.com/OrbitalShell/Orbital-Shell/blob/master/OrbitalShell-Kernel/Component/Shell/Module/ModuleHookManager.cs

add cmd line (shell meta options) meta options: --help , -- [ specification of decorators and decorators parameters ] -- [output control]