oriches / faker-cs Goto Github PK

The NetStandard.Library is defined as a dependency of the nuget when in fact it is only required for netstandard 2.0. As such the nuget should have atleast 2 target frameworks netstandard 2.0 and netcoreapp 3.0 with netcore app not having any dependency.

Hi,

Just an FYI,

Warning NU1701 Package 'Faker 1.2.0' was restored using '.NETFramework,Version=v4.6.1, .NETFramework,Version=v4.6.2, .NETFramework,Version=v4.7, .NETFramework,Version=v4.7.1, .NETFramework,Version=v4.7.2, .NETFramework,Version=v4.8' instead of the project target framework 'net6.0'. This package may not be fully compatible with your project. TestProject C:\Users\Me\source\repos\DocsAPI\tests\TestProject.csproj 1

Works OK

Test to reproduce

        [TestCase(0, int.MaxValue, "0 to int max")]
        public void Should_Yield_All_ValuesWithinRange(int minValue, int maxValue, string testName)
        {
            Console.WriteLine($@"RandomNumber.Next [{testName}]");
            var result = true;
            for (var i = 0; i < 50; i++)
            {
                var number = RandomNumber.Next(minValue, maxValue);
                Console.WriteLine($@" result: [{number}]");
                if (number < 0)
                {
                    result = false;
                    break;
                }
            }

            Assert.IsTrue(result);
        }

Is your feature request related to a problem? Please describe.
In dependency track this package is reporting as not having a licence type specified

Describe the solution you'd like
The PackageLicenseExpression property is set in the csproj so thay the NUGET package has the information. This can then ben included in the SBOM so that analysis can occur in the appropriate tools

Describe alternatives you've considered
Ignore them, bundle licence file into package & reference the file.

Additional context
As per https://learn.microsoft.com/en-us/nuget/reference/msbuild-targets#pack-target, PackageLicenseUrl is deprecated

The project should have a single project which targets multiple frameworks and compiles a nuget package of all said projects

Summary

I wish for the nuget packages to have a more informative readme.

Details

The nuget package should be using the same readme as the repo to make it as easy as possible for a user to get started with the package.

version: 1.5.148

The generated phone numbers are not valid?

1. They look strange.
2. They are not parsable by google phone lib.

In the German resource file for addresses, the separators between countries are missing. Therefore, there are only two countries present: Egypt and all other countries concatenated.

Unable to use faker references from .net standard 2.0 which is referenced to a .net framework V4.8 test project , the compile time assembly of faker included in a .net standard project is changed to .net framework.

Hello,

I started using this library for handling my mocks and it is awesome !

Does this library supports country codes (as described in ISO_3166) ?
https://en.wikipedia.org/wiki/List_of_ISO_3166_country_codes

Regards,