osgeo / ows.js Goto Github PK

Hi all,

Some days ago I implemented async calls with promises. So the calls change from this:

Older version, sync and blocking method:

// GetRecords
var results = csw.GetRecords(1,10,filter);
console.log(results);

to this:

New version, async and no-blocking method:

// GetRecords
csw.GetRecords(1,10,filter).then(function(result){
        console.log(result)
    });

The code can by re-viewed at https://github.com/juanmav/ows.js/tree/promises

any comments?

Regards
JM

@juanmav any reason why we couldn't have dist/ generated by a build step?

@juanmav http://bower.io/search/?q=ows.js any chance we can point this to https://github.com/OSGeo/ows.js? I'm guessing pushing your local changes / new features upstream at some point.

For the reasoning, see http://contribute.md/

I'd create a first version (partially based on https://github.com/openlayers/ol3/blob/master/CONTRIBUTING.md), but I don't want to imply to much regarding community process etc. without a discussion, so here is a draft: https://gist.github.com/nuest/4b6d60ec0d8fd3b6a930

Feedback is highly appreciated.

Questions:

• How does QUnit work - will all tests go into index.html, or will we split these up by service? Do we have end to end tests (yet)?
• Will we have a manual changelog, or rely on pull request history? I'm inclined for outward communication to have a changelog.md (or a preferred format for JavaScript libs). This looks like a good example: https://github.com/angular/angular.js/blob/master/CHANGELOG.md
• Code style and guidelines - should we set these up now? https://github.com/openlayers/ol3/blob/master/CONTRIBUTING.md gives some extensive and precise guidelines.

I surely don't want to slow down development by this, so keeping these things low profile is fine by me, then we'll just mention that in the contribute.md 😄

I've tried to apply a BBOX filter (paying attention to lat, lon order). With the GetRecords I get this message Argument [ows:BoundingBox] must be an array. Do you have any idea how to solve that? Thanks a lot for your reply

So what do we plan to use for ows.js?

ES6 modules seem the way forward. Since there are transpilers (https://babeljs.io) or shims ( https://github.com/paulmillr/es6-shim/)

What do people think?