Comments (4)
This should be resolved in the develop branch for next release.
from simple-social-icons.
✔️ The mentioned issue "2x the same title id" is now resolved with version 3.0.0
❌ The mentioned issue "2x the same svg id" still remains on version 3.0.0 - I'm not sure if this is valid Markup, can someone double check that?
from simple-social-icons.
Thanks for testing this, @NormanHoehne!
I see the same duplicate ID reused in the SVG markup itself, but it doesn't generate any validation errors for me. The way it's loaded via the <use>
element effectively places it in a separate DOM tree:
The effect is the same as if the nodes were deeply cloned into a non-exposed DOM…
— https://developer.mozilla.org/en-US/docs/Web/SVG/Element/use
Chrome represents this as descending from the shadow-root:
So I expect that particular duplicated ID to be safe to ignore here.
from simple-social-icons.
Thank you for the clarification @nickcernis, I can live with that! :) 👍
from simple-social-icons.
Related Issues (20)
- GitHub Icon is outdated HOT 1
- Add alt attribute to svg tag in HTML HOT 1
- Warning: sprintf(): Too few arguments in simple-social-icons.php on line 458 HOT 1
- Warning: sprintf(): Too few arguments in simple-social-icons.php on line 458
- Add TikTok to Default Settings HOT 14
- Add Patreon
- Add Mastodon and Bluesky HOT 1
- Add Flipboard
- Obfuscate email address when entered with mailto prefix
- Consider adding rel=noopener if links are opened in a new window HOT 2
- Multiple instances of the widget on the same page breaks styling HOT 2
- Limit transparent colors to icon background only HOT 7
- Add ability to set per widget area defaults HOT 3
- Consider dropping Google+ icon HOT 1
- Invalid css output on transparent background HOT 6
- CSS output is within body tags / Validation error
- Themes should be able to set SSI default styles via a config file
- Fix AMP validation error for svgxuse.js HOT 2
- Only enqueue scripts/styles if a widget is actually on the page
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from simple-social-icons.