Giter VIP home page Giter VIP logo

Comments (4)

dreamwhisper avatar dreamwhisper commented on August 19, 2024

This should be resolved in the develop branch for next release.

from simple-social-icons.

NormanHoehne avatar NormanHoehne commented on August 19, 2024

✔️ The mentioned issue "2x the same title id" is now resolved with version 3.0.0
❌ The mentioned issue "2x the same svg id" still remains on version 3.0.0 - I'm not sure if this is valid Markup, can someone double check that?

from simple-social-icons.

nickcernis avatar nickcernis commented on August 19, 2024

Thanks for testing this, @NormanHoehne!

I see the same duplicate ID reused in the SVG markup itself, but it doesn't generate any validation errors for me. The way it's loaded via the <use> element effectively places it in a separate DOM tree:

The effect is the same as if the nodes were deeply cloned into a non-exposed DOM…
https://developer.mozilla.org/en-US/docs/Web/SVG/Element/use

Chrome represents this as descending from the shadow-root:

screen shot on 2018-10-11 at 12 39 12

So I expect that particular duplicated ID to be safe to ignore here.

from simple-social-icons.

NormanHoehne avatar NormanHoehne commented on August 19, 2024

Thank you for the clarification @nickcernis, I can live with that! :) 👍

from simple-social-icons.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.