Giter VIP home page Giter VIP logo

Comments (7)

nickcernis avatar nickcernis commented on August 19, 2024

PR at #83. Will be ready to test once that is merged.

Noting that usability in the Customizer is not perfect (clearing the icon color will still show a clear color in the color picker after publishing, instead of the previous non-blank color that is restored). This should be improved when the RGBA color picker is implemented. https://core.trac.wordpress.org/ticket/39681

from simple-social-icons.

nickcernis avatar nickcernis commented on August 19, 2024

Ready for testing (develop branch):

  • Add a Simple Social Icons widget.
  • Confirm:
    • All colors have default values set.
    • Clearing icon color and icon hover color and saving does not remove default color values.
    • Setting icon color and icon hover color to a custom color and saving causes icon color to update.
    • Setting icon background and icon border colors (and their hover colors) to empty results in a transparent border / background.
    • Setting icon background and border colors (and hover colors) to custom colors lets them update.

cc @dreamwhisper

from simple-social-icons.

JiveDig avatar JiveDig commented on August 19, 2024

I kinda like transparency on the icons. Then we can do something like rgba(0,0,0,.6) and have the icon color just be a darker version of whatever the background changes too. It may add confusion and I can certainly live without it, but worth mentioning the use-case.

from simple-social-icons.

nickcernis avatar nickcernis commented on August 19, 2024

Then we can do something like rgba(0,0,0,.6)

The color slider doesn't yet implement rgba support, from what I can see (it's coming in https://core.trac.wordpress.org/ticket/39681 but not here yet). So wouldn't you still need to override the transparent icon color with custom CSS anyway to get rgba icons as a tint of the background?

from simple-social-icons.

JiveDig avatar JiveDig commented on August 19, 2024

Well, I haven't done it yet outside of my own CSS. But I think doing this should get the same effect:

.my-selector .my-icon {
    color: #000;
    opacity: .6;
}

from simple-social-icons.

dreamwhisper avatar dreamwhisper commented on August 19, 2024

@JiveDig I can see that in custom CSS but since the customizer color selector doesn’t support alpha, I’m not sure how we support transparency as it is now.

Adding a separate opacity setting later may be an option, but right now, it would be 0 opacity/ transparent just by clearing the hex color.

Let me know if I am missing something. It’s completely possible :)

from simple-social-icons.

JiveDig avatar JiveDig commented on August 19, 2024

I've been using Kirki lately so I'm probably spoiled. This is totally an edge case thing that doesn't fit the 80/20 rule so let's proceed as originally intended here :)

from simple-social-icons.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.