ostis-apps / dockerized-ostis Goto Github PK

Provide the ability to specify options for sc-machine build.

Check custom kb rewrite possibility for all versions and possibility to run standalone standard version from docker without run.sh script

Better to use one container per service and use docker-compose to orchestrate these containers

Custom port instead of 8090 is currently not working properly for 0.6.0

It's probably going to be nice to add .bat/.ps1 files for running images on Windows, because it can be problematic to run .sh scripts on Windows by default

Specify run instructions for Linux, Windows and MacOS in Readme file

The build fails with the following error:

#13 11.02     running install_egg_info
#13 11.02     error: 'egg_base' must be a directory name (got `lib`)
#13 11.02
#13 11.02     ----------------------------------------
#13 11.11 Command "/usr/bin/python -u -c "import setuptools, tokenize;__file__='/tmp/pip-build-SaMKL9/sqlalchemy/setup.py';f=getattr(tokenize, 'open', open)(__file__);code=f.read().replace('\r\n', '\n');f.close();exec(compile(code, __file__, 'exec'))" install --record /tmp/pip-ccPPwY-record/install-record.txt --single-version-externally-managed --compile" failed with error code 1 in /tmp/pip-build-SaMKL9/sqlalchemy/
------
executor failed running [/bin/sh -c sudo pip install --default-timeout=100 tornado sqlalchemy redis==2.9 numpy configparser]: exit code: 1

Fortunately, it was easy to fix. The error about the directory name is caused by outdated setuptools, and several other packages (such as numpy) required a bdist_wheel instruction in setuptools, which requires wheel to be installed. Long story short, it's a 3-line PR that I will upload in a moment.

Specify run options with descriptions in Readme file

Check options to reduce total image size. It's probably needed to review all dependencies and remove redundant

In the current state, branch 0.6.0 doesn't build successfully, because it uses ostis-apps/sc-web as the source repository for sc-web, and this repo is not maintained anymore, thus, sc-web doesn't build with later versions of tornado (no version pinning is used). It was fixed in ostis-dev/sc-web.

It is wise to change the source repo to ostis-dev/sc-web, but this repo does not build with current implementation either, because dockerized-ostis/Dockerfile relies on python2 to install sc-web dependencies, while the scripts used in ostis-dev/sc-web (0.6.0) have actually been rewritten to python3.

I've cooked up a PR resolving this issue, please see #36.

Set up automated builds in docker-hub.
Rebuild images after push

Remove problem solver folder for all branches as it's not a part of docker

The problem: after poking around with the project I've noticed that every time I use run.sh and stop it, it leaves a container, which is probably an undesired behavior since we create a new instance every time we launch run.sh

Solutions:

1. Use --rm flag, which should delete the container after exit. It plays well with our use case I believe, and it is also how ephemeral Docker containers are supposed to work work.
2. We could also run the same container over and over using docker start, if it has any tangible advantages over the first way.

For new and old interface version:

• Add possibility to specify interface folder as a volume
• Add script for interface rebuild
• Update documentation

Move adjust configuration options to environment variables for docker run command

1. Можно добавить функцию command_exists, которая будет проверять наличие команды в системе.
2. Вместо жестко закодированных путей к скриптам, можно использовать переменные для хранения этих путей.
3. Можно добавить проверки на ошибки после выполнения каждой команды. Если команда завершится с ошибкой, скрипт может выйти с ненулевым кодом возврата.
4. Добавить использование цветовых сообщений для вывода информации в терминал. Например, использование зеленого цвета для сообщения о запуске sc-web.
5. Рекомендуется добавить комментарии, которые помогут другим разработчикам понять цель и логику вашего скрипта.
6. Добавить обработку сигналов, чтобы при завершении скрипта были выполнены соответствующие действия, такие как остановка запущенных служб или процессов.