osxc / legacy-boot Goto Github PK

the only response I get from this script is that 'authentication failed'

• easy_install doesn't need -E for pip
• only CFLAGS are needed for pip to install ansible(e.g., this works in a virtualenv, as per this post:
  CFLAGS="-Wunused-command-line-argument-hard-error-in-future" pip install ansible
• sudo is also unnecessary for ansible when using a virtualenv(which osxc doesn't take into account in general, I know)
• instead of $latest, appending @1.6.0 to the git URL would specify the 'stable/release' version that's known to work with osxc, although I understand we think all future versions will support the current functionality

I'm running 10.9.2 with Xcode and the dev tools installed. I've used homebrew to install a handful of things.

I was surprised when boot.sh decided that it needed to install them, given that homebrew has been happy. Is it really necessary?

Xcode appears to have been installed via the app store, I believe that it was part of the image with which the machine was handed to me.

This homebrew issue discusses some funny business with Mavericks and the dev tools. It mentions using xcode-select to print the path to the install, heres what I get:

georgewh-L0DKQ1:xc-boot georgewh$ xcode-select --print-path
/Applications/Xcode.app/Contents/Developer

So, is it really necessary to reinstall the dev tools to use osxc? If not, is there a way I can help improve boot.sh to avoid it?

It seems like that you changed the repo name from xc-common/xc-custom to legacy-common/legacy-custom.
In this way, $CM_REPO and $CS_REPO should be changed as well.
or:

Custom tools clone

Cloning into '/Users/zhangchen/src/github.com/Michaelizm/xc-custom'...
Username for 'https://github.com': Michaelizm
Password for 'https://[email protected]':
remote: Repository not found.
fatal: repository 'https://github.com/Michaelizm/xc-custom.git/' not found

Thanks.

-p'ing the mkdir means it sets 0777 on all intermediate folders, which may be all well and good in single-user systems with good security hardening practices already in place, but it should be addressed by instead creating the ~/src directory first with 700 if not present, with a chmod +a everyone deny delete" ~/src for good measure.
If you'd like I can whip up a branch/PR for this as well, but it's also weird when the boot script creates the folders(which it seems assumes the short username == github name? I don't understand the CS_REMOTE=${1:-github.com/osxc/xc-custom}) it essentially runs a 'clean' on both the common and custom folders by rm -rf'ing after creation. We know mkdir -p will not error if it sees directories are already there, so this would be uncaught with the current code and could cause data loss. If you want to add an optional 'clean' function and variable that's off by default but around for troubleshooting, it may make more sense.

• Naming aside, (some people call the place they store repo's 'dev',) it is generally a bad practice (even if plenty of sync services and others do it) to place a folder at the root of the users home and assume a single-user system. Proper permissions are often not set by those services, so if we're at the root of the home folder, verifying a /bin/chmod 700 would be recommended
• Variable names alone could be clearer about intent/purpose - comments would definitely help to explain, # Git remote path to osxc-maintained roles for CM_REMOTE, I personally find it weird to specify where the git repo happens to be hosted as part of the project working directory path, but that's just me
• And most importantly, Homebrew tests for the most likely receipts left behind by an Xcode dev tools install, a la the code here - it would be best to follow suit

I'll cook up a PR to discuss this with working code sooner rather than later