otake84 / messagepack-rs Goto Github PK
View Code? Open in Web Editor NEWmessagepack-rs is pure Rust MessagePack implementation.
messagepack-rs is pure Rust MessagePack implementation.
I want to use Deserializer
for stdin
(below code) but it is impossible because Deserializer
requires Seek
trait. Do you have any plans for Deserializer
update?
{
let stdin = io::stdin();
let input = stdin.lock();
let mut reader = BufReader::new(input);
let mut stream_deserializer = Deserializer::new(reader);
// deserialize repeatedly...
}
IMO, if Deserializer
inputs pure Read
, it can accept any stream object e.g. socket(TcpStream). The implementation might be like MessagePack.newDefaultUnpacker(InputStream in)
of msgpack-java
.
Thanks!
Hello ๐ฆ,
we (Rust group @sslab-gatech) found a memory-safety/soundness issue in this crate while scanning Rust code on crates.io for potential vulnerabilities.
messagepack-rs/messagepack-rs/src/deserializable.rs
Lines 59 to 71 in ceaf013
messagepack-rs/messagepack-rs/src/deserializable.rs
Lines 90 to 92 in ceaf013
messagepack-rs/messagepack-rs/src/deserializable.rs
Lines 90 to 92 in ceaf013
4 functions (deserializable::Deserializable::{deserialize_string, deserialize_extension_others, deserialize_map::deserialize_string_primitive}
) create an uninitialized buffer and passes it to user-provided Read
implementation. This is unsound, because it allows safe Rust code to exhibit an undefined behavior (read from uninitialized memory).
This part from the Read
trait documentation explains the issue:
It is your responsibility to make sure that
buf
is initialized before callingread
. Calling read with an uninitializedbuf
(of the kind one obtains viaMaybeUninit<T>
) is not safe, and can lead to undefined behavior.
The Naive & safe way to fix the issue is to always zero-initialize a buffer before lending it to a user-provided Read
implementation. Note that this approach will add runtime performance overhead of zero-initializing the buffer.
As of Jan 2021, there is not yet an ideal fix that works in stable Rust with no performance overhead. Below are links to relevant discussions & suggestions for the fix.
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.