otakumegane / tallnether Goto Github PK

View Code? Open in Web Editor NEW

8.0 8.0 2.0 695 KB

Spigot plugin that creates a 256-block high Nether

Java 100.00%

tallnether's People

Contributors

Stargazers

Watchers

Forkers

theblobinc q2297045667

tallnether's Issues

Request for permission

This is actually not a issue.
Dear developer, I love your awesome plugin TallNether so much, so could I have your permission to make a introduction thread on a chinese forum named MCBBS? (http://www.mcbbs.net)
I won't leak the jar and will redirect to your page. If you agree, I'd appreciate it a lot.
Sorry if I have troubled you.

1.16.2 is unsupported

I apologize for being that guy, but 1.16.2 bumped the nms revision and is unsupported.

Great plugin by the way! Thank you for maintaining it.

Edit: https://www.spigotmc.org/threads/tallnether.143809/page-7#post-3912945

1.16.4 Not working?

Versions:
Paper: Paper-263
Tall Nether: 2.5.4
Multiverse 2: 4.2.3-SNAPSHOT-b816

I've edited the config to match my settings for now to basically test this, along with trying to remove the world from both MV and the server directory, making sure I started a fresh, I then removed the region files and had them recreated. To no avail there was no difference.

I do have the original nether removed via the server.properties because of how I have my worlds setup, my default world is called void but has no end or nether, I then created these worlds through MV; world, world_nether and world_the_end. Assuming that they wouldn't cause any problem to the generation of this plugin.

Tall Nether Config:

https://hastebin.com/ehafanowor.yaml

Multiverse Config:

https://hastebin.com/upodekecuf.yaml

Paper forks are breaking on 1.16.2

Your Paper detection is not done properly to detect forks of Paper (like Tuinity, Purpur, Yatopia, Origami, etc)

As you know, CraftBukkit relocates fastutils but Paper does not relocate it, which is why it's important you have a Paper specific nms helper in your plugin to use the non-relocated fast utils. However, your plugin is checking very specifically for the server name to be "Paper" which fails on Paper forks, like mine.

Possible solution: It would be better check for the existence of PaperConfig in a try/catch to know if the environment is indeed a Paper environment. Or, you can use PaperLib to handle this check for you and you use PaperLib#isPaper()

New world error

For reference. This error occurs on 1.18 when starting a new world with TallNether enabled but never shows up on an existing world. Possibly related to spawn finding?

java.util.concurrent.CompletionException: java.lang.ArrayIndexOutOfBoundsException: Index 31 out of bounds for length 17
	at java.util.concurrent.CompletableFuture.encodeThrowable(CompletableFuture.java:315) ~[?:?]
	at java.util.concurrent.CompletableFuture.completeThrowable(CompletableFuture.java:320) ~[?:?]
	at java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1770) ~[?:?]
	at java.util.concurrent.CompletableFuture$AsyncSupply.exec(CompletableFuture.java:1760) ~[?:?]
	at java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:373) [?:?]
	at java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1182) [?:?]
	at java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1655) [?:?]
	at java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1622) [?:?]
	at java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:165) [?:?]
Caused by: java.lang.ArrayIndexOutOfBoundsException: Index 31 out of bounds for length 17
	at net.minecraft.world.level.levelgen.NoiseChunk$d.b(SourceFile:291) ~[spigot-1.18-R0.1-SNAPSHOT.jar:3335-Spigot-a5dea1c-a008701]
	at net.minecraft.world.level.levelgen.NoiseChunk.a(SourceFile:156) ~[spigot-1.18-R0.1-SNAPSHOT.jar:3335-Spigot-a5dea1c-a008701]
	at java.util.ArrayList.forEach(ArrayList.java:1511) ~[?:?]
	at net.minecraft.world.level.levelgen.NoiseChunk.c(SourceFile:156) ~[spigot-1.18-R0.1-SNAPSHOT.jar:3335-Spigot-a5dea1c-a008701]
	at net.minecraft.world.level.levelgen.ChunkGeneratorAbstract.a(ChunkGeneratorAbstract.java:349) ~[spigot-1.18-R0.1-SNAPSHOT.jar:3335-Spigot-a5dea1c-a008701]
	at net.minecraft.world.level.levelgen.ChunkGeneratorAbstract.lambda$17(ChunkGeneratorAbstract.java:308) ~[spigot-1.18-R0.1-SNAPSHOT.jar:3335-Spigot-a5dea1c-a008701]
	at java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1768) ~[?:?]
	... 6 more

Generation favors "y stacking"

Generated elements, such as hidden lava pockets and ore veins, pick a single Y value in each chunk then generate only vertically.
This is a world generated from a config containing nothing but:
world: world_nether: enabled: true

The included image is four chunks with all netherrack removed (WorldEdit) giving a pretty solid visual to what I'm describing.
This is (hopefully obviously) impractical behavior for defaults.

Amazing concept, hope to see it fixed soon!

server crashed on startup.

Caught this server crash on startup:

Console: https://pastebin.com/raw/aYYSF9CQ
Crash report: https://pastebin.com/raw/dpu0zEMt
TallNether config: https://pastebin.com/raw/CNYgekDF

Using Paper 1.16.5 Build 586
TallNether Build 2.5.5

1.16 Update

So, 1.16 is currently in the snapshot phases right now, but since it is the Nether Update, I'd thought to let you know in advance incase major changes are needed.

1.16.3 Structures don't generate above y: 128

Not sure if it has to do with fortresses which I believe were noted as being an issue, but new nether structures like the bastion remnants don't seem to generate above y: 128. Using v1_16_R2.

Possible to adjust size of biome generation?

We're aiming to generate biomes of 2000 block width or more, is there an easy setting we can change in this generator to make that happen?

retrogenerate old chunks

when going from pregenerated chunks to new chunks it cuts off, I know that this is intentional because its only supposed to affect new chunks but it would be cool for servers that have been using normal nether for months to be able to retrogenerate old chunks y120+ into new terrain even if its butchered its better than nothing. just an idea

Java 14 compatibility

CentOS Linux 7.8.2003
Java 14.0.2
Spigot 1.16.3
TallNether 2.5.1

On server start-up:

[17:11:59] [Server thread/WARN]: java.lang.NoSuchFieldException: modifiers
[17:11:59] [Server thread/WARN]:        at java.base/java.lang.Class.getDeclaredField(Class.java:2489)
[17:11:59] [Server thread/WARN]:        at com.minefit.xerxestireiron.tallnether.v1_16_R2.ReflectionHelper.setFinal(ReflectionHelper.java:31)
[17:11:59] [Server thread/WARN]:        at com.minefit.xerxestireiron.tallnether.v1_16_R2.LoadHell.setGenerator(LoadHell.java:133)
[17:11:59] [Server thread/WARN]:        at com.minefit.xerxestireiron.tallnether.v1_16_R2.LoadHell.overrideGenerator(LoadHell.java:103)
[17:11:59] [Server thread/WARN]:        at com.minefit.xerxestireiron.tallnether.ManageHell.overrideGenerator(ManageHell.java:109)
[17:11:59] [Server thread/WARN]:        at com.minefit.xerxestireiron.tallnether.TallNether.prepareWorld(TallNether.java:95)
[17:11:59] [Server thread/WARN]:        at com.minefit.xerxestireiron.tallnether.TallNether.onWorldInit(TallNether.java:64)
[17:11:59] [Server thread/WARN]:        at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
[17:11:59] [Server thread/WARN]:        at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
[17:11:59] [Server thread/WARN]:        at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
[17:11:59] [Server thread/WARN]:        at java.base/java.lang.reflect.Method.invoke(Method.java:564)
[17:11:59] [Server thread/WARN]:        at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:315)
[17:11:59] [Server thread/WARN]:        at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:70)
[17:11:59] [Server thread/WARN]:        at org.bukkit.plugin.SimplePluginManager.fireEvent(SimplePluginManager.java:589)
[17:11:59] [Server thread/WARN]:        at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:576)
[17:11:59] [Server thread/WARN]:        at org.bukkit.craftbukkit.v1_16_R2.CraftServer.createWorld(CraftServer.java:1066)
[17:11:59] [Server thread/WARN]:        at org.bukkit.Bukkit.createWorld(Bukkit.java:524)
[17:11:59] [Server thread/WARN]:        at org.bukkit.WorldCreator.createWorld(WorldCreator.java:325)
[17:11:59] [Server thread/WARN]:        at com.onarandombox.MultiverseCore.utils.WorldManager.doLoad(WorldManager.java:467)
[17:11:59] [Server thread/WARN]:        at com.onarandombox.MultiverseCore.utils.WorldManager.doLoad(WorldManager.java:448)
[17:11:59] [Server thread/WARN]:        at com.onarandombox.MultiverseCore.utils.WorldManager.doLoad(WorldManager.java:423)
[17:11:59] [Server thread/WARN]:        at com.onarandombox.MultiverseCore.utils.WorldManager.loadWorlds(WorldManager.java:728)
[17:11:59] [Server thread/WARN]:        at com.onarandombox.MultiverseCore.MultiverseCore.onEnable(MultiverseCore.java:310)
[17:11:59] [Server thread/WARN]:        at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:263)
[17:11:59] [Server thread/WARN]:        at org.bukkit.plugin.java.JavaPluginLoader.enablePlugin(JavaPluginLoader.java:351)
[17:11:59] [Server thread/WARN]:        at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:480)
[17:11:59] [Server thread/WARN]:        at org.bukkit.craftbukkit.v1_16_R2.CraftServer.enablePlugin(CraftServer.java:492)
[17:11:59] [Server thread/WARN]:        at org.bukkit.craftbukkit.v1_16_R2.CraftServer.enablePlugins(CraftServer.java:406)
[17:11:59] [Server thread/WARN]:        at net.minecraft.server.v1_16_R2.MinecraftServer.loadWorld(MinecraftServer.java:435)
[17:11:59] [Server thread/WARN]:        at net.minecraft.server.v1_16_R2.DedicatedServer.init(DedicatedServer.java:216)
[17:11:59] [Server thread/WARN]:        at net.minecraft.server.v1_16_R2.MinecraftServer.w(MinecraftServer.java:808)
[17:11:59] [Server thread/WARN]:        at net.minecraft.server.v1_16_R2.MinecraftServer.lambda$0(MinecraftServer.java:164)
[17:11:59] [Server thread/WARN]:        at java.base/java.lang.Thread.run(Thread.java:832)
[17:11:59] [Server thread/INFO]: [TallNether Error] Something went wrong enabling TallNether on world 'world_whitedog_nether'.

No issues on Java 8 or 11.

[BUG]: Could not pass event WorldInitEvent to TallNether v2.5.4

Server Version: git-Purpur-841 (Spigot 1.16.4-R0.1-SNAPSHOT)
MC: 1.16.4

[15:18:30 ERROR]: Could not pass event WorldInitEvent to TallNether v2.5.4
java.lang.NullPointerException: null
        at com.minefit.xerxestireiron.tallnether.v1_16_R3.BiomeModifiers.BasaltDeltasModifier.<init>(BasaltDeltasModifier.java:22) ~[?:?]
        at com.minefit.xerxestireiron.tallnether.v1_16_R3.WorldInfo.collectBiomeData(WorldInfo.java:49) ~[?:?]
        at com.minefit.xerxestireiron.tallnether.v1_16_R3.LoadHell.overrideDecorators(LoadHell.java:31) ~[?:?]
        at com.minefit.xerxestireiron.tallnether.v1_16_R3.LoadHell.addWorld(LoadHell.java:53) ~[?:?]
        at com.minefit.xerxestireiron.tallnether.ManageHell.overrideGenerator(ManageHell.java:117) ~[?:?]
        at com.minefit.xerxestireiron.tallnether.TallNether.prepareWorld(TallNether.java:95) ~[?:?]
        at com.minefit.xerxestireiron.tallnether.TallNether.onWorldInit(TallNether.java:64) ~[?:?]
        at com.destroystokyo.paper.event.executor.asm.generated.GeneratedEventExecutor16.execute(Unknown Source) ~[?:?]
        at org.bukkit.plugin.EventExecutor.lambda$create$1(EventExecutor.java:69) ~[patched_1.16.4.jar:git-Purpur-841]
        at co.aikar.timings.TimedEventExecutor.execute(TimedEventExecutor.java:80) ~[patched_1.16.4.jar:git-Purpur-841]
        at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:70) ~[patched_1.16.4.jar:git-Purpur-841]
        at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:607) ~[patched_1.16.4.jar:git-Purpur-841]
        at net.minecraft.server.v1_16_R3.MinecraftServer.loadWorld(MinecraftServer.java:441) ~[patched_1.16.4.jar:git-Purpur-841]
        at net.minecraft.server.v1_16_R3.DedicatedServer.init(DedicatedServer.java:249) ~[patched_1.16.4.jar:git-Purpur-841]
        at net.minecraft.server.v1_16_R3.MinecraftServer.w(MinecraftServer.java:943) ~[patched_1.16.4.jar:git-Purpur-841]
        at net.minecraft.server.v1_16_R3.MinecraftServer.lambda$a$0(MinecraftServer.java:179) ~[patched_1.16.4.jar:git-Purpur-841]
        at java.lang.Thread.run(Thread.java:832) [?:?]