oujesky / closure-templates Goto Github PK

When I create a {literal} block which has a multiline content, then the generated HTML contains \n characters.

SOY source:

{template .test}
    {literal}
        /* some
           multiline
           string */
    {/literal}
{/template}

Generated PHP source:

  public static function test($opt_data = null, $opt_ijData = null) {
    $output = '\n        /* some\n           multiline\n           string */\n    ';
    return new \Goog\Soy\SanitizedHtml($output);
  }

Rendered HTML source:

\n        /* some\n           multiline\n           string */\n    

So the problem is when setting the value of $output, the value is surrounded by single quotes, so the new line character will be treated as text instead of as a special character. Changing single quotes to double quotes or replacing \n with PHP_EOL can fix this issue.

It would be nice if there was an extra option in the Soy compiler which can copy the annotations from the Soy templates to the generated PHP functions.

For example:

Soy source:

/**
 * Test template
 * @annotation custom annotation
 */
{template .test}
    test
{/template}

PHP source:

  /**
   * Test template
   * @annotation custom annotation
   * @param array|null $opt_data
   * @param array|null $opt_ijData
   * @return \Goog\Soy\SanitizedContent
   */
  public static function test($opt_data = null, $opt_ijData = null) {
    $output = 'test';
    return new \Goog\Soy\SanitizedHtml($output);
  }

But of course this output is just an example/idea, the format can be changed if it is necessary. Also, it would nice to keep the original @param annotations as @soyparam or something like this.