The dir-sync from owenvoke

dir-sync's Introduction

Hi there, I'm a full-stack web developer living in Bristol, UK.

I currently work at @worksome as a Senior Backend Engineer
I use PHP and JavaScript daily
I'm mostly active within the Laravel community
Working on @pestphp, @laravel-zero, @tldr-pages, @parceltrap, and more.
Contact me on Twitter, or via email

I'm interested in PHP, Laravel, Web3, cryptocurrencies, and anything tech.

Check out voke.dev for more information.

dir-sync's People

Contributors

Stargazers

Watchers

dir-sync's Issues

Make into a library, not a project

The current version is a project rather than a library.

It would probably be better as a library with utility classes (and remove the public directory).

That way, testing is easier and more efficient and it puts it in the hands of the user.

The current public files can be examples instead.

[Insight] Logical operators should be avoided - in Client/PlexCronClient.php

in Client/PlexCronClient.php, line 53
in Client/PlexCronClient.php, line 67
in Client/PlexCronClient.php, line 72

The or operator does not have the same precedence as ||.
This could lead to unexpected behavior, use || instead.

                    $path = $this->moviesPath;
                    if (is_dir($path)) {
                        $results = scandir($path);

                        foreach ($results as $result) {
                            if ($result === '.' or $result === '..') continue;

                            if (is_dir($path . '\\' . $result)) {
                                $folders[] = $result;
                            }
                        }