Giter VIP home page Giter VIP logo

Comments (7)

sfadschm avatar sfadschm commented on September 6, 2024 1

Thanks!
As initially stated, the updater is actually still working when running from the webUI. There it only fails at the restartWebserver command, after the actual update is already finished. So for users who use this way, it should work to just update and ignore that error.

Running the updater from the command line will however not be possible as you described.
not sure if that might be worth an update note?

from updater.

sfadschm avatar sfadschm commented on September 6, 2024 1

Fixed in core 10.15.

from updater.

sfadschm avatar sfadschm commented on September 6, 2024

Moved from owncloud/core#41057 (comment).

from updater.

sfadschm avatar sfadschm commented on September 6, 2024

This issue still persists with Core 10.13.3.4.

from updater.

sfadschm avatar sfadschm commented on September 6, 2024

The reason is most likely this change in #711:

https://github.com/owncloud/updater/blob/master/src%2FCommand%2FBackupDbCommand.php#L46

The method now returns 1 and stops the update. Before, it returned nothing.

Same for the "restartwebserver" command.

Ref.: #713

from updater.

sfadschm avatar sfadschm commented on September 6, 2024

@phil-davis Maybe the methods should return 0, i.e., fail silently? At least this seems to be how it was handled before #711. For now, we have the output that the methods are not implemented, which is quite good to know for anyone using the updater.

from updater.

phil-davis avatar phil-davis commented on September 6, 2024

PR #730 puts the behavior back, so that things that are not-yet-implemented will return command line status 0 (success), and not fail the upgrade. That should fix the problem.

It won't end up in a release until the next core release (some time in 2024, I suppose). Existing installations would need to apply that change "manually" if they want to use the updater.

from updater.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.