p3lim-wow / extraquestbutton Goto Github PK

Quests that aren't in your current zone wouldn't display items even if tracked.

During the WQ Drawing Out the Poison you loot the Phylactery of Arin'gore, which you need to use to summon the target mob. Simple questItems addition.

The Korthia/Archivists' Codex quest Diviner's Rune Chits has you randomly loot Diviner's Rune Chits from treasures in Korthia, which have to be used to gain actual quest progress, and thus aren't displayed in the quest tracker for EQB to pick up on automatically.
(Similar to BfA's The Great Sea Scrolls / Tortollan Pilgrimage Scrolls, in fact)
I added this to the questItems section in my local copy, and also had to add it to inaccurateQuestAreas, since the quest itself has no defined quest area. I suggest the areas { 1961, 2006, 2007 } for Korthia and its two caves with their own map, although given the nature of the quest, a simple true would also fit, you'd want to use the items as soon as possible anyway, and you only loot them in Korthia... but let's not get too philosophical, I'll leave the decision to your opinion.

I noticed you added the items for Who Devours the Devourers?, but Lua ignores the first entry for the green item (other languages would complain about using an array index/key twice)
You'd have to use a table to store both itemIDs under the same questID index, and then account for that in the determining function, use the first item from the table that you possess (priority on the blue item, in this case)

PS: While this ticket is still open, a thing I found while levelling:
Boom Boots (for both H/A versions of A Breath of Fresh Air) need an entry in completeItems, as the quest is 'complete' on accept. UiMapID is 205, Shimmering Expanse (although the code currently just looks for a non-false value in the array)

Zereth Mortis missing daily quest

Materials of Creation (Item: Firim's Forge-tap) doesnt appear to work

It's All Fun And Games - Icecrown - 'Eyesore Blaster'

Describe the bug
I was doing the Loose Change world quest and the button didn't show up.

I tried adding the quest id and item id to the ItemData.lua file in the ns.itemData.questItems section but it didn't help.
[52230] = 158226, -- Stormsong Valley, Loose Change

As you're aware I'm no expert with this stuff but I like to try and solve things if I can, I figure that's better than just complaining.
I may have it in the wrong section but perhaps I need a more accurate area of Stormsong Valley?
Unfortunately the WQ is ending now and I've collected all the coins so my testing time is over.

Only take quest items from quests that are currently being tracked in the quest log.

Probably easiest to just add this to the existing state driver:

RegisterStateDriver(Button, 'visible', '[extrabar,petbattle] hide; show')

not sure if I'm missing it, but I would love for the grey lightning texture around the button to be hidden, so it's simply the button that is displayed. (:

I'm running the latest version 80000.10, as soon as the quest completes and the quest tracker info changes and removes the icon this error pops up. Happens every time. I only started using this add-on yesterday so not sure if something has changed recently but it has never worked for me since I first tried it.

Message: ...terface\AddOns\ExtraQuestButton\ExtraQuestButton-80000.10-Release.lua:44: Usage: GetItemCooldown(itemID)
Time: Fri Jul 27 15:22:16 2018
Count: 1
Stack: ...terface\AddOns\ExtraQuestButton\ExtraQuestButton-80000.10-Release.lua:44: Usage: GetItemCooldown(itemID)

Locals:

Using Dominos and currently hide the textures on my extra button. I'm really loving this addon (it's really how Blizzard should handle quest items I think), but the ExtraQuestButton texture gets in the way of parts of my UI. Any chance of getting an option to hide the textures?

For now, is there a couple of lines of code I could comment out to hide the textures? I did a quick search, but were quite a few lines of code with the word texture, so couldn't figure it out.

hiho,
Great addon, no idea why this isn't a default thing in the game but thankfully clever people like you can Make it So.

Quest: http://www.wowhead.com/quest=29515/writing-the-future Writing the Future
This is the scribe profession leveling quest.

Adding [29515] = 823, to the Darkmoon Island section of the quest.lua file made it work.

Appending the next one my, infrequently played, alt found missing.
[29516] = 823,

The EQB for the Further Gelatinous Research world quest (id 61189) in Maldraxxus only shows for the bottom half of the questing area, while most of the slimes you need for it are in the top half.

80000.11-Release

Low priority. I also noticed that the button size changed when I hid the graphics (or at least the green square size changed), not sure if that's intended or not.

I've only just got around to doing this pre-expansion quest stuff and noticed the first quest in Icecrown isn't working.
I've only looked Alliance side but, having looked up the quest on Wowhead I see Horde has a similar quest, so I suspect they'll have the same problem.

A Valiant Effort is the quest, Crusader's Dressing is the item.

I looked up how to get the zone id, /dump C_Map.GetBestMapForUnit("player") and it returns 118.
Looking up Zone Ids that matches, although there is another listing in there as 1400.
I don't know if there's a sub-zone or a specific phasing needed but a bit of reading indicates that someone has written a library because the game returns the same map id even if you're in a sub-zone.

I tried adding [183797] = 118, to quests.lua but it didn't help.
I also adjusted the settings you've added to try and work out if any of them help, they didn't. 😢

If there's anything I can help with please let me know.

I got the following error when I picked up an old quest.
It provides an item for the quest although it's a bit different from other items as it's consumed on use, it gives you a buff for ten minutes and when it runs out, or you click it off, the NPC gains another chat option to get more bait. When you get replacement bait the default quest tracking button doesn't come up, you have to find it in your bag and use it.

In my investigation I discovered that GetDistanceSqToQuest and C_TaskQuest.GetDistanceSqToQuest have been removed and C_QuestLog.GetDistanceSqToQuest was added.
So I changed line 58 to:
local distanceSq, onContinent = C_QuestLog.GetDistanceSqToQuest(questID)
That stops the error but the extra quest button doesn't come up. I assume that's because the item gets consumed on use?

[string "@ExtraQuestButton\Utils.lua"]:58: in function <ExtraQuestButton\Utils.lua:18>
[string "@ExtraQuestButton\Utils.lua"]:111: in function `GetClosestQuestItem'
[string "@ExtraQuestButton\ExtraQuestButton-90000.15-Release.lua"]:144: in function `callback'
[string "@ExtraQuestButton\mixins\EventHandlerMixin.lua"]:56: in function <ExtraQuestButton\mixins\EventHandlerMixin.lua:53>

Locals:
questID = 36201
questLogIndex = 32
itemLink = "|cffffffff|Hitem:114874::::::::50:62:::::::|h[Moonshell Claw Bait]|h|r"
_ = 133707
_ = -1
showWhenComplete = false
itemID = 114874
(*temporary) = nil
(*temporary) = 36201
(*temporary) = "attempt to call global 'GetDistanceSqToQuest' (a nil value)"
itemData = <table> {
 targetItems = <table> {
 }
 itemBlacklist = <table> {
 }
 accurateQuestAreas = <table> {
 }
 noCompleteItems = <table> {
 }
 inaccurateQuestAreas = <table> {
 }
 completeItems = <table> {
 }
 questItems = <table> {
 }
}
ns = <table> {
 GetItemID = <function> defined @ExtraQuestButton\Utils.lua:148
 GenerateItemLinkFromID = <function> defined @ExtraQuestButton\Utils.lua:152
 GetClosestQuestItem = <function> defined @ExtraQuestButton\Utils.lua:92
 itemData = <table> {
 }
 GetNPCID = <function> defined @ExtraQuestButton\Utils.lua:139
 GetCurrentMapID = <function> defined @ExtraQuestButton\Utils.lua:156
 Print = <function> defined @ExtraQuestButton\Utils.lua:160
 mixins = <table> {
 }
}
sqrt = <function> defined =[C]:-1
GetDistanceSqToPoint = <function> defined @ExtraQuestButton\Utils.lua:7

Polly Want A Cracker?
https://www.wowhead.com/quest=50164/polly-want-a-cracker

I've tried adding it via quest id and item id but it isn't working, I'm using zone number 895 as that is what WeakAuras tells me the zone is.
I'm not sure what more to try so I'm leaving this note here for you. :-)

I got this error when the leader of a LFG party I joined enabled party sync (after I accepted the sync). Got the same error again a few seconds after sync, and it might have kept continuing but the party was disbanded at that point.

2x ExtraQuestButton\Utils.lua:130: attempt to index local 'info' (a nil value)
[string "@ExtraQuestButton\Utils.lua"]:130: in function GetClosestQuestItem' [string "@ExtraQuestButton\ExtraQuestButton-90000.21-Release.lua"]:150: in function callback'
[string "@ExtraQuestButton\mixins\EventHandlerMixin.lua"]:56: in function <ExtraQuestButton\mixins\EventHandlerMixin.lua:53>

Locals:
self =

{
GenerateItemLinkFromID = defined @ExtraQuestButton\Utils.lua:165
mixins = {
}
Print = defined @ExtraQuestButton\Utils.lua:173
GetCurrentMapID = defined @ExtraQuestButton\Utils.lua:169
GetClosestQuestItem = defined @ExtraQuestButton\Utils.lua:94
db = {
}
GetNPCID = defined @ExtraQuestButton\Utils.lua:152
L = {
}
GetItemID = defined @ExtraQuestButton\Utils.lua:161
itemData = {
}
}
closestQuestItemLink = nil
closestDistance = 1000
onlyInZone = false
onlyIfWatched = false
(for index) = 2
(for limit) = 62
(for step) = 1
index = 2
info = nil
(*temporary) = nil
(*temporary) = 2
(*temporary) = nil
(*temporary) = "attempt to index local 'info' (a nil value)"
ns = {
GenerateItemLinkFromID = defined @ExtraQuestButton\Utils.lua:165
mixins = {
}
Print = defined @ExtraQuestButton\Utils.lua:173
GetCurrentMapID = defined @ExtraQuestButton\Utils.lua:169
GetClosestQuestItem = defined @ExtraQuestButton\Utils.lua:94
db = {
}
GetNPCID = defined @ExtraQuestButton\Utils.lua:152
L = {
}
GetItemID = defined @ExtraQuestButton\Utils.lua:161
itemData = {
}
}
GetQuestDistanceWithItem = defined @ExtraQuestButton\Utils.lua:18

Started using this addon some weeks ago, loving it, found some more items that should be supported (some you already added in the recent version) - or blacklisted.

Describe the solution you'd like
ns.itemData.questItems should be extended by:

• Discarded Harp for Go Beyond! (Ardenweald, Night Fae Mushroom Network Daily, item is looted during quest and not shown in questlog, to be used near an NPC - doesn't need to be targetted)
• Tainted Centurion Component for The Right Stuff (Bastion, Venthyr Campaign)

The "Call [Construct]" items from the weeklies of the Abominable Stitching Necrolord Feature need to be addressed. These items are always shown in the quest log, even when the corresponding Abomination is summoned. You don't really "need" these items that often, but they can obstruct items from World Quests, e.g. Call Atticus 'prevents' the use of the skull for the WQ Deathfang's Favorite Toy via this addon's button.
Either make them low priority compared to other items, or add them to the blacklist.
However. the blacklist is defined in ItemData.lua, but isn't referenced anywhere else in the code, did you maybe delete its use by accident?
I put a check into GetQuestDistanceWithItem and got the blacklist to work.

Similarly, the Ani-Matter Orb is used for a weekly in Maldraxxus, but Necrolords will want to hang onto it to be able to summon the rare Zargox each day.
This orb should also be low priority, as it obstructs the flag for Parts to a Whole.

Regarding the "low priority during collision" categories in ItemData.lua, it seems this only applies to the category checks for an item, not vs. other quest items. Maybe an option to always prefer World Quests? They're usually your top priority. This would be another way to address the above Necrolord items.
(Hope this still makes sense, only realized the stuff in the last paragraph while writing this, so I shifted sentences and words around a lot)

Queued up to run some Cataclysm Timewalking on my Demon Hunter. Upon zoning into a dungeon I received the following error. Thanks.

12x Usage: local position = C_Map.GetPlayerMapPosition(uiMapID, unitToken)
[string "=[C]"]: in function GetPlayerMapPosition' [string "@ExtraQuestButton\Utils.lua"]:9: in function <ExtraQuestButton\Utils.lua:7> [string "@ExtraQuestButton\Utils.lua"]:73: in function <ExtraQuestButton\Utils.lua:18> [string "@ExtraQuestButton\Utils.lua"]:152: in function GetClosestQuestItem'
[string "@ExtraQuestButton\ExtraQuestButton-90100.24-Release.lua"]:158: in function `callback'
[string "@ExtraQuestButton\mixins\EventHandlerMixin.lua"]:56: in function <ExtraQuestButton\mixins\EventHandlerMixin.lua:53>

Locals:
(*temporary) = "Usage: local position = C_Map.GetPlayerMapPosition(uiMapID, unitToken)"

http://www.wowhead.com/quest=29517/eyes-on-the-prizes
Adding this made it work.
[29517] = 823,

Another quest I found, which could work better, is:
http://www.wowhead.com/quest=26572/a-golden-opportunity

The knife comes up okay but once you cut off the tail it stays as the knife and you've got to go digging through your bag for the tail. It would be awesome if the button would swap to the tail when you got it.
http://www.wowhead.com/item=58958/drowned-thunder-lizard-tail

Not sure if that's possible, just mentioning it in case it isn't too hard. :-)

Hide the extra quest button by shift clicking it, or middle clicking etc.
Don't unhide until the item is used from within the inventory or using the objective tracker button.

Add an option to remove the on screen button at all times, but for the keybind still to work

Hey, we've just seen that you experienced issues uploading your addon. We just fixed a bug that prevented you from doing it :-) please try again. In case you need further help feel free to reach out on Discord: Jayow#8905

I use Dominos to change the position of the Extra Action Button. However on load ExtraQuestButton resets the position, ignoring Dominos positioning.

If you try to move the button from your addon it does recognise another addon has moved it and does not allow you to change the position.

In Anchor.lua you have the following lines

-- re-anchor/size buttons
ExtraActionButton1:ClearAllPoints()
ExtraActionButton1:SetPoint('CENTER', self)
ExtraActionButton1:SetSize(self:GetSize())

However there is no check for other addons like when you go to move the button.

I just copied the code from above and added the check to stop the reposition always firing on load and it has solved the issue.

getting that rectangle in picture -not sure for what reason

Describe the bug

mixins\StateHandlerMixin.lua file is missing. Either TOC needs updated to remove this or the file needs to be included.

https://mods.curse.com/addons/wow/extraquestbutton?comment=18

There seems to be a bug that occurs when a quest item has the same name as a toy (and perhaps other things). This is my guess at what's happening, anyway.

I ran into the problem while doing the quest The Mantidote. When I used the keybinding to use the quest item, it worked once (and once again many minutes later) and then it kept saying the item wasn't ready despite it clearly not being on cooldown; the icon showed it was ready (and the item doesn't have a long cooldown to begin with). The quest item is Ken-Ken's Mask, which has the same name as a Toy that has a long cooldown.

It seems like it was trying to use the toy instead of the quest item or something (though the quest item was used at the same time? or the quest allows you to use the toy instead of the quest item? I don't know for sure).

If I dragged the quest item to my bar and clicked that or used Blizzard's small quest item in the watch frame, I didn't have this problem. It only happened with the keybinding (and presumably the button) from this addon.

• Changing scale
• Support for adjustments with the mouse (scroll to scale, middle-click to reset)
• Skinning (Masque)

Maybe also control the ExtraActionButton with these settings, but that should be optional.

Error occurs after combat has ended. Did not happen earlier in the session, but seemed to pop up on this quest.

3x ExtraQuestButton\ExtraQuestButton-@[email protected]:54: Usage: ExtraQuestButton:UnregisterEvent("event")
[C]: in function `UnregisterEvent'
ExtraQuestButton\ExtraQuestButton-@[email protected]:54: in function `?'
ExtraQuestButton\ExtraQuestButton-@[email protected]:6: in function <ExtraQuestButton\ExtraQuestButton.lua:4>

Locals:
self = ExtraQuestButton {
 0 = <userdata>
 HotKey = ExtraQuestButtonHotKey {
 }
 SetItem = <function> defined @ExtraQuestButton\ExtraQuestButton.lua:204
 PLAYER_LOGIN = <function> defined @ExtraQuestButton\ExtraQuestButton.lua:65
 Update = <function> defined @ExtraQuestButton\ExtraQuestButton.lua:253
 UnwrapScript = <function> defined @FrameXML\SecureHandlers.lua:710
 SetFrameRef = <function> defined @FrameXML\SecureHandlers.lua:715
 PLAYER_REGEN_ENABLED = <function> defined @ExtraQuestButton\ExtraQuestButton.lua:52
 Icon = ExtraQuestButtonIcon {
 }
 UPDATE_BINDINGS = <function> defined @ExtraQuestButton\ExtraQuestButton.lua:58
 WrapScript = <function> defined @FrameXML\SecureHandlers.lua:704
 updateTimer = 4.5900001144037
 attribute = "Goren Gas Extractor"
 itemLink = "|cffffffff|Hitem:111910:0:0:0:0:0:0:0:95:0:11:0|h[Goren Gas Extractor]|h|r"
 itemName = "Goren Gas Extractor"
 Cooldown = ExtraQuestButtonCooldown {
 }
 itemID = 111910
 Artwork = ExtraQuestButtonArtwork {
 }
 Execute = <function> defined @FrameXML\SecureHandlers.lua:699
 RemoveItem = <function> defined @ExtraQuestButton\ExtraQuestButton.lua:243
 BAG_UPDATE_COOLDOWN = <function> defined @ExtraQuestButton\ExtraQuestButton.lua:40
 rangeTimer = 0.11700000241399
}

80000.11-Release

While doing the quest Help Those That Cannot Help Themselves (Borean Tundra), the EQB showed up for a few mammoths but at some point just disappeared despite the quest still being active. I'm not seeing any indication of a problem otherwise.

Reloading the UI brought it back.

EDIT: It disappeared again as I approached the trap, may have happened once I got within range of the trap to actually use the ability. Reloading usually brought it back but didn't once. Another time I was able to use the EQB but it disappeared when used but I was already within range to use it. There may just be something weird about this quest. I'll follow up if I see anything similar with other quests.

EDIT 2: So far it's just been that one quest, the button was left in a hidden/inactive state when that quest completed and remained hidden for a subsequent quest with a button but when I used the quest tracker button for the action the EQB button came back and has been working normally since, I believe.

... or provide some other way to temporarily override the selected item. Maybe alt-rightclick to blacklist it for 5 minutes.

Use case: This morning I was leveling an alt in Un'goro and picked up the quest to bait diemetradons into the spike pits, but some other guy was farming the diemetadons around the pits (who knows why) and I couldn't get any further-out ones to follow all the way to the pit, so I just went to do some other quests in the meantime. However, since the "map blob" for that quest covers about half the zone, the bait item took priority over several other quests' items and I had to manually use them from my bags.

Granted, this kind of situation doesn't come up often, but with the buttons on the objectives tracker being completely unusable due to everything everwhere tainting them all the time, it's pretty annoying when it does. :(

Ley Line Focus Control Ring - ItemID "36751"

Quest - "The Focus on the Beach" QuestID - "12065"

Location - Northrend > Dragonblight > 26.5, 65.5

The new AdventureMap provides some neat features for figuring out the best quests the player should take, we could look into using the API.

2nd button doesn't work if use 2 buttons for EXTRAACTIONBUTTON1.

local key = GetBindingKey('EXTRAACTIONBUTTON1')
if(key) then
self:SetBindingClick(1, key, self, 'LeftButton')
end

Fix:
local key1, key2 = GetBindingKey('EXTRAACTIONBUTTON1')
if(key1) then
self:SetBindingClick(1, key1, self, 'LeftButton')
end
if(key2) then
self:SetBindingClick(2, key2, self, 'LeftButton')
end

I noticed this before reset but wasn't sure what was happening, after reset I noticed it again and took the time to get this screen shot and add the bug report.
The really odd part is that brighter area of grass, it moves as I move the camera around, it stops being bright after I hand the quest in. I tried capturing it but something has changed since I last recorded WoW and it isn't working now and given it's 3:20am now isn't the time to trouble shoot it!

/fstack tells me it's ExtraQuestButton.240d2708060 and the artwork is ExtraQuestButtonArtwork, which is what we'd expect.
There's no reason for it to come up now, as you can see none of the quests have an icon next to them.
The quest I've just finished is Crysa's Flyers.

Hi, currently if you bind EQB then it activates on key up. I would like an option for it to activate on key down instead.

Describe the bug
EQB memory usage grows at a linear rate. It starts at <1mb and gradually goes up. Earlier I had it on 10MB+.

How to reproduce
Just having it enabled seems to cause it

What did you expect?
A more consistent memory usage

Error report
n/a

Screenshots
https://user-images.githubusercontent.com/1754678/143659892-6e106a11-a75c-4e56-9937-f95d685adc5a.mp4

I have lower level alts with myriad level 615 items retrieved from Follower missions through the garrisons which are unusable until level 100.

The button cheerily taunts me with the items which I cannot open, causing me to cry.

Please do not let the addon make me cry.

• What version are you using?
  latest version and in BFA/retail

• Can the issue be reproduced, and if so, how?
  mouseover extra button, no tooltip shows up

• If there was an error message, please include it.

• If there is a graphical issue, please include a screenshot (you can drag-n-drop here).

Make sure you check back often until the issue is resolved for any follow-up questions.

I'm running the Github version I was asked to test for a different reported issue, the button is defaulting down in the middle of my action bar and /eqb isn't doing anything (I just get the usual "Type /help etcetc").

There's no quest item in my bag and not doing any quest but it pops out

Not sure how much you care about earlier expansion quests but I'll just add them here as I come across them.

• The Plume of Alystros - Dragonblight - Item is called 'Skytalon Molts'
• Mystery of the Infinite - Dragonblight - 'Hourglass of Eternity'
• Mystery of the Infinite, Redux - Dragonblight - 'Hourglass of Eternity'
• That Which Creates Can Also Destroy - Dragonblight - 'Seeds of Nature's Wrath' (it did come up for Turgid and Overseer)

In previous add-ons, the button is moved incorrectly.
I have never seen it work after BFA( the addon was updated

• What version are you using?
  80000.13-Release

• Can the issue be reproduced, and if so, how?
  The Rodrigo's Birdseed Biscuit#154878 from the World Quest Flew the Coop#49402 does not get a button.

Hi p3lim,

I am using ExtraQuestButton and I have noticed that in the questid 44067 the item to be used itemid:141253 is always overwritten by the spell used as disguised night elf (spellid 204477).

The problem is that the quest item is to be used when you have to fight some elites, but when you fight you are not disguised anymore and so the the other spell appears (even if in combat) overwritten the first.

Thanks if you can check it .

So, in order for the key binds to work right you will need to change either the Binding.xml (all instances) EXTRAQUESTBUTTON to ExtraQuestButton
or in ExtraQuestButton.lua in function ExtraQuestButton:UpdateBinding() local keyButton = addonName to local keyButton = string.upper(addonName)

It has the key binding registered as EXTRAQUESTBUTTON (in the xml) and tries to look it up as ExtraQuestButton (in the lua)

This quests have missing area blobs:
Torch Tossing: 11921, 11922, 11926, 11731
Torch Catching: 11923, 11924, 11925, 11657

Version: 60100.4-Beta

ExtraQuestButton\Utils.lua:61: bad argument #1 to 'sqrt' (number expected, got nil)

I am not 100% sure but I think this happens when there is a quest that has no indicator on the world map.
Happened on this quest:
https://www.wowhead.com/quest=31004/preserved-in-amber

Describe the bug
I installed the addon before realizing that I wouldn't be able to hide the button from view. Upon removing the addon it somehow caused the button to become permanently offset.
I play retail and use Bartender... So far I haven't been able to reset the ExtraActionButton bar without resetting the entire profile - something I'd really like to avoid due to the amount of time spend customizing it.

How to reproduce
Tbh, I don't know what happened and there has been no errors to consult.
The only thing I can safely determine is that the bug didn't occur until the addon was removed... As if it left some kind of a indentation somewhere...

What did you expect?
-||-

Error report
No errors reported

Screenshots