Giter VIP home page Giter VIP logo

Comments (30)

blindndumb avatar blindndumb commented on July 29, 2024

And may be device maintainers should fork it to their own account.
EDIT : Sorry accidentally pressed close, Re Opened!!

from android_vendor_pac.

Nick0703 avatar Nick0703 commented on July 29, 2024

I agree with blindndumb. If we do that, our github (PAC's) will look clean.

from android_vendor_pac.

szlkiev avatar szlkiev commented on July 29, 2024

This is what singh_dd93 did weeks ago, and we're using it in our dependencies

https://github.com/pac-semc7x30

from android_vendor_pac.

Nick0703 avatar Nick0703 commented on July 29, 2024

Ah I see! I'll probably make one for Samsung devices then.

from android_vendor_pac.

Papa-Smurf151 avatar Papa-Smurf151 commented on July 29, 2024

Why not just make a pac-devices github and use it for all. That way there
aren't a ton of different pac githubs
On May 20, 2013 8:15 PM, "Lokesh (Nick) Chamane" [email protected]
wrote:

Ah I see! I'll probably make one for Samsung devices then.


Reply to this email directly or view it on GitHubhttps://github.com//issues/131#issuecomment-18181802
.

from android_vendor_pac.

Nick0703 avatar Nick0703 commented on July 29, 2024

@szlkiev, is that ok with you? If we make one pac-devices github?

from android_vendor_pac.

singhdd93 avatar singhdd93 commented on July 29, 2024

@Papa-Smurf151 I think different organisations should be made for different company devices
that will keep the organisation clean and easy to maintain

from android_vendor_pac.

Papa-Smurf151 avatar Papa-Smurf151 commented on July 29, 2024

Either way is fine. Just only fork what is needed. If it's maintained by
cm or the muppets then no need for us to host it. Just means more merging
and updating for no reason.
On May 20, 2013 8:30 PM, "Damandeep Singh" [email protected] wrote:

@Papa-Smurf151 https://github.com/Papa-Smurf151 I think different
organisations should be made for different company devices
that will keep the organisation clean and easy to maintain


Reply to this email directly or view it on GitHubhttps://github.com//issues/131#issuecomment-18182272
.

from android_vendor_pac.

singhdd93 avatar singhdd93 commented on July 29, 2024

I had to fork all repos as there is no official CM support of CM10.1 for our devices and many times the device tree in originally maintained repos become unstable

from android_vendor_pac.

szlkiev avatar szlkiev commented on July 29, 2024

Both ways looks good to me.

from android_vendor_pac.

szlkiev avatar szlkiev commented on July 29, 2024

Down from 79 to 60
Will need more dependencies changes to reduce more of them.
In the meanwhile I just moved repo ownership to github.com/szlkiev for a temporary backup

Now we have
PAC-semc7x30
PAC-samsung

from android_vendor_pac.

blindndumb avatar blindndumb commented on July 29, 2024

@Forum moderators.. Please reset my password of forum , The reset password option doesn't work
Username : blindndumb
Need to push changes..
BTW.. making a new PAC-htc too.. or has anyone already made it..

from android_vendor_pac.

Nick0703 avatar Nick0703 commented on July 29, 2024

@szlkiev You can delete all the samsung repos. We forked all of them to PAC-samsung.

from android_vendor_pac.

singhdd93 avatar singhdd93 commented on July 29, 2024

I still see semc device repos. @szlkiev please remove them

from android_vendor_pac.

szlkiev avatar szlkiev commented on July 29, 2024

@nick, some dependency in jellybean branch haven't been edited, need to edit them first before remove the repos : i927, quincyatt
Also some samsung devices in cm-10.1 branch

@singhdd
Do you mind replace pac-semc7x30 jellybean branch with ones from pac-man?
Also in pac-semc7x30 we don't need other branches except jellybean & cm-10.1.
And update jellybean dependencies.
Once its done i'll remove all semc device trees

from android_vendor_pac.

Nick0703 avatar Nick0703 commented on July 29, 2024

@szlkiev ok I'll edit them also.

from android_vendor_pac.

Nick0703 avatar Nick0703 commented on July 29, 2024

@szlkiev I think it should be good now.

from android_vendor_pac.

szlkiev avatar szlkiev commented on July 29, 2024

Path of proprietary i927 & quincyatt are non standard.
Should be proprietary_vendor_samsung instead just proprietary_vendor_i927 or vendor_quincyatt
Then no need repository proprietary_vendor_i927 anymore in PAC-samsung, so need to edit their dependency again

from android_vendor_pac.

Nick0703 avatar Nick0703 commented on July 29, 2024

I was going to make them use the proprietary_vendor_samsung but I notice
that there was a few changes between them. I was afraid that if I make them
use it, it might break the builds for them. I'll update/merge or do
something else tomorrow. I can't update them right now.
On 2013-05-26 11:03 PM, "szlkiev" [email protected] wrote:

Path of proprietary i927 & quincyatt are non standard.
Should be proprietary_vendor_samsung instead just proprietary_vendor_i927
or vendor_quincyatt
Then no need repository proprietary_vendor_i927 anymore in PAC-samsung, so
need to edit their dependency again


Reply to this email directly or view it on GitHubhttps://github.com//issues/131#issuecomment-18480517
.

from android_vendor_pac.

szlkiev avatar szlkiev commented on July 29, 2024

OK,
One more error in Samsung gio.dependencies
Incorrect target path for android_device_samsung_gio
I believe this device was not buildable before, drunk maintainer :)

Edit: its stated in both gio.dependencies & gio.adds, still, drunk maintainer :)

Down to 46

@blindndumb , mind helping us with HTC pyramid ?

from android_vendor_pac.

sudwind avatar sudwind commented on July 29, 2024

I also need to get my password reseted from the forum. And get added to the PAC-Samsung, since I'm the maintainer of tass, a msm7x27 device, and I provided the sources for beni, I forked most of the needed repos from androidarmv6 (some changes were needed, like the editing for the not yet ready BlueZ support or the newer atheros wifi libs). I'm just busy but still maintaing my source built pac for tass :) (and sorry for writing this here)

from android_vendor_pac.

blindndumb avatar blindndumb commented on July 29, 2024

Will create PAC-htc tonight, HTC maintainers please contact me "[email protected]"
@szlkiev I dont see any dependencies of Pyramid, also the device tree has not been updated since Sep 19,2012
It is useless .. better delete it..

from android_vendor_pac.

singhdd93 avatar singhdd93 commented on July 29, 2024

@szlkiev I will copy the jellybean branch of semc devices from PAC-man to PAC-semc7x30 within a day or two and also change the dependencies.

from android_vendor_pac.

championswimmer avatar championswimmer commented on July 29, 2024

Another thing is, if there are any vendor trees on PAC (which might have required forking from TheMuppets or wherever), create separate account for them.
Blobs attract attention of DMCA-takedown sort of things. Though bigger projects like CM can be easier targets, it's preferrable to keep hands clean of any potential problems.
Worst case scenario is PAC-man github may get suspended (all repos) which will be very unfortunate.

from android_vendor_pac.

blindndumb avatar blindndumb commented on July 29, 2024

@szlkiev android_device_htc_pyramid was useless, Deleted!
Also htc_msm8660-common was used in only evita and jewel (maintained by jameig71), rest htc devices are using CyanogenMod's , Deleted! - It was also not updated since Sep

PM Sent to maintainer to update dependencies
So HTC is now clean, I guess!

from android_vendor_pac.

szlkiev avatar szlkiev commented on July 29, 2024

Please check jellybean branch, might still be used there

from android_vendor_pac.

blindndumb avatar blindndumb commented on July 29, 2024

@szlkiev Never mind evita and jewel are 8960 device, Actually 8660-common was forked by the one who forked device_pyramid.. So its none of use. BTW I checked jellybean too before deleting

from android_vendor_pac.

szlkiev avatar szlkiev commented on July 29, 2024

@blindndumb, Great, now just left semc & lge

from android_vendor_pac.

singhdd93 avatar singhdd93 commented on July 29, 2024

semc done
remove all repos

from android_vendor_pac.

szlkiev avatar szlkiev commented on July 29, 2024

done, clean from device tree

from android_vendor_pac.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.