Giter VIP home page Giter VIP logo

Comments (20)

victornoel avatar victornoel commented on June 19, 2024 1

Thanks @leleuj :)

FYI @evnm I will announce it soon on dropwizard mailing list :)

from dropwizard-pac4j.

evnm avatar evnm commented on June 19, 2024
  1. I haven't posted anything since that initial dropwizard-user@ thread in which we first discussed the library. No one has reached out with commentary, so I haven't received any feedback either.
  2. I've considered this library to be in a holding pattern until we see evidence that its functionality is desired by Dropwizard users. Without concrete feedback from folks trying to use it, it seems preemptive to arbitrarily mint a 1.0.0 release. We should release a series of 0.x stable versions that folks can try out before we solidify APIs.
  3. Transferring the library to the pac4j org is fine by me. Regardless of which org the project falls under, dropwizard-pac4j should be added to modules.dropwizard.io once a stable version is released.

To be honest, I don't think I'm the right person to maintain dropwizard-pac4j long-term, since I don't work on any projects that currently use pac4j. I will of course stick around to consult on the Dropwizard side of things.

from dropwizard-pac4j.

leleuj avatar leleuj commented on June 19, 2024
  1. I think we need something more engaging, like "Secure your Dropwizard services with pac4j", but there is no hurry
  2. It feels like the "Egg or chicken" story ;-) I think there is always a need for a good security library to secure web services. So I think our main concern is to make dropwizard-pac4j known and used by Dropwizard users so that feedbacks and inquiries come.
  3. Noticed for the modules.dropwizard.io

"I don't think I'm the right person to maintain dropwizard-pac4j long-term": I have absolutely no problem with that, this is open source and free involvement. And the "eat your own dog food" is a key rule. In that case, can you transfer this project to the pac4j organization so that we can take over?

from dropwizard-pac4j.

evnm avatar evnm commented on June 19, 2024

Sounds like we're in agreement. I'm happy to transfer the project to the pac4j org. As for getting the word out, how about we wait until a) @victornoel's JAX-RS redux of this library is merged and b) a stable version of dropwizard-pac4j is released, at which point we can send mail to dropwizard-user@, pac4j-users@, and any other relevant mailing lists.

from dropwizard-pac4j.

evnm avatar evnm commented on June 19, 2024

@leleuj, could you please delete the existing pac4j/dropwizard-pac4j repository? I can't complete transfer until it is removed.

from dropwizard-pac4j.

leleuj avatar leleuj commented on June 19, 2024

I just deleted the pac4j/dropwizard-pac4j repository: it should be ok now.

from dropwizard-pac4j.

victornoel avatar victornoel commented on June 19, 2024

On my side, I am using all these libraries in an application that is under development in my company. In the coming month I will be playing more and more with the advanced features of pac4j (to have SSO, for now I only use a simple login with users in a local database).
It's currently not accessible, because we are reworking our forge/CI infrastructure, but it's under an AGPL license, so it will be visible also in the month I guess...

I think we can at least release 0.x versions quite quickly and wait for a 1.0.0 until I have (or someone else) used the more advanced features that makes pac4j a relevant architectural choice :)
We can still advertise the 0.x version I think :)

There is a good chance that things may need to be changed in a breaking way I think, both in jac-rs-pac4j and dropwizard-pac4j.

from dropwizard-pac4j.

leleuj avatar leleuj commented on June 19, 2024

Great to have you as an intensive user and contributor!

We must not fear breaking changes. If so, we'll upgrade to version 2.0.0.

from dropwizard-pac4j.

evnm avatar evnm commented on June 19, 2024

Ugh, so apparently in order to transfer a repo, the person making the transfer has to have admin/owner rights to the recipient account/organization: https://help.github.com/articles/transferring-a-repository-owned-by-your-organization/

@leleuj, could you temporarily grant me admin rights to the pac4j org, please? You can rescind these rights once the transfer is complete.

from dropwizard-pac4j.

victornoel avatar victornoel commented on June 19, 2024

@evnm the other solution would maybe to transfer it to @leleuj and let him put it in the organisation.

Also Ithink this page is more likely to apply to your case @evnm since the repository is in your private account :)

from dropwizard-pac4j.

leleuj avatar leleuj commented on June 19, 2024

Everything is ok now. I moved it to the pac4j organization.

from dropwizard-pac4j.

victornoel avatar victornoel commented on June 19, 2024

@leleuj great :) any ETA for deployment on Sonatype snapshot repository?

from dropwizard-pac4j.

leleuj avatar leleuj commented on June 19, 2024

I just did it. In fact, the build fails due to the EndToEnd class tests and I noticed that the README is out-of-date as well (it mentioned the j2e-pac4j library instead of the jax-rs-pac4j one). But you should be able to fix that easily.

from dropwizard-pac4j.

victornoel avatar victornoel commented on June 19, 2024

@leleuj should be alright with #7, thanks!

from dropwizard-pac4j.

leleuj avatar leleuj commented on June 19, 2024

Build is ok, but deployment fails. Checking...

from dropwizard-pac4j.

leleuj avatar leleuj commented on June 19, 2024

It's good now: https://oss.sonatype.org/content/repositories/snapshots/org/pac4j/dropwizard-pac4j/0.0.1-SNAPSHOT/

from dropwizard-pac4j.

victornoel avatar victornoel commented on June 19, 2024

@leleuj maybe it would make sense that until 1.0.0, I get push rights on this repository and maybe also jax-rs-pac4j? I will still make PR for everything concerning pac4j itself so that you can review :)

from dropwizard-pac4j.

leleuj avatar leleuj commented on June 19, 2024

Lets' do that for now. You should have received invitations...

from dropwizard-pac4j.

victornoel avatar victornoel commented on June 19, 2024

Thanks!

from dropwizard-pac4j.

leleuj avatar leleuj commented on June 19, 2024

As I just released version 1.0.0, we can close this issue.

from dropwizard-pac4j.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.