pace / cloud-sdk-capacitor-plugin Goto Github PK

Problem

We've defined that startApp() can be called with PresetUrl: https://github.com/pace/cloud-sdk-capacitor-plugin/blob/master/src/definitions.ts#L145

This doesn't work for the Android plugin yet.

Tasks

• Update Android's Cloud SDK with the environment-based preset URLs
• Support PresetUrl for startApp

Android

• Rename PluginCofuStation to PluginGasStation

Both

• Add opening hours: Pass values as is from tiles response to plugin + include documentation in the Wiki

{
    "openingHours": [
        {
            "day": "monday",
            "hours": [["0","5"], ["20","24"]] // open, 24h format
        },
        {
            "day": "tuesday",
            "hours": [["0","5"], ["20","24"]]  // open, 24h format
        }
    ]
}

• Add fuel prices + fuel types:

{
    "fuelPrices": [
        {
            "fuelType": "diesel",
            "productName": "Diesel",
            "price": 1359,
            "unit": "L",
            "currency": "EUR",
            "priceFormatting": "d.dds", // see Wiki
            "updated": 1622030266 // Unix time in seconds
        },
        {
            "fuelType": "ron98e5",
            "productName": "Super Plus",
            "price": 1559,
            "unit": "L",
            "currency": "EUR",
            "priceFormatting": "d.dds", // see Wiki
            "updated": 1622030266 // Unix time in seconds
        }
    ]
}

Tasks

• Implement wrapper method for PACECloudSDK.setup()

Fix errors in

• startFuelingApp (threading issue)
• getNearbyGasStations

Motivation

Currently it is quite hard to know how to setup the project. The README should include:

1. How to setup the capacitor plugin for iOS
2. How to setup the capacitor plugin for Android
3. How to update the PACE Cloud SDK for iOS
4. How to update the PACE Cloud SDK for Android
5. How to update the plugin (adjusting of interface files etc.)
6. How to release a new version of the plugin via npm

Tasks

• Implement wrapper method for PACECloudSDK.setup()

https://capacitorjs.com/docs/updating/3-0 & https://capacitorjs.com/docs/updating/plugins/3-0

• Remove listAvailableCoFuStations and checkForLocalApps
• Add getNearbyGasStations

We should integrate a stable version of the SDK here instead of the master, otherwise this will lead to a lot of confusion and breaking behavior.

Problem

How to deal with iOS' native completion blocks?

Pointers

• https://capacitorjs.com/docs/plugins/ios#events

• Remove listAvailableCoFuStations and checkForLocalApps
• Add getNearbyGasStations

Tasks

• listAvailableCoFuStations(countries: [String]? = null): Promise<{results: any[]}>
• isPoiInRange(poiId: String): Promise<{result: boolean}>
• checkForLocalApps(): Promise<{results: any[]}>
• startApp(url: String)
• startApp(app: App)

API definition

Tasks

• Update the interfaces to the latest Cloud SDK
• Make sure to adjust the Wiki to explain the usage of the getAccessToken method