Giter VIP home page Giter VIP logo

Comments (11)

ghachey avatar ghachey commented on August 23, 2024 1

Hi @maratomega . The idea here is to add a tiny bit of data to assist in troubleshooting the duplicate issue we are struggling to fix. So this is a proposed work to assist with issue #21 .

Refer to the screenshot below. On the left is the metadata of a Google Service Cloudfile. On the right is our XML Survey. I propose we add some tablet unique identifyer of some sort. Let's call it "sourceTabletIdentifyier". This would be a value taken from the tablet this cloud file is coming from. This could be the name? an ID on Android? anything unique to the tablets. I think it can be only on the metadata properties (as on the left of image below). But I don't think it would not hurt to have it also on the XML survey file.

Screenshot 2022-07-04 104634

So of course in merging this value is not carried over. For example, merging a worker tablet (device 2) into a team leader's tablet (device 1) the sourceTabletIdentifyer from device 2 will not make it to device 1.

Let me know if you come across anything you are not sure.

from pacific-emis-education-survey-tool.

ghachey avatar ghachey commented on August 23, 2024 1

The tablet id variable in a survey should store a list of all device identifiers on which the survey has ever changed, correct?

No. This would defeat the purpose of trying to find out where the actual survey file is located. One survey file should be exactly on one tablet and thus that tablet's ID.

No tracking, no added complexity. Only need to know where the cloud file is located, on which tablet.

from pacific-emis-education-survey-tool.

maratomega avatar maratomega commented on August 23, 2024

Hi @ghachey could you share more information about this issue

from pacific-emis-education-survey-tool.

maratomega avatar maratomega commented on August 23, 2024

Hi @ghachey perhaps instead of adding tablet ID, we can use lastEditedUser to identify the tablet? To avoid adding new metadata (tablet ID)

from pacific-emis-education-survey-tool.

maratomega avatar maratomega commented on August 23, 2024

One more question about Status of survey: right now we have the following flow - the Positive survey when it's merged gets new status Merged, we think it's a bug, and it should keep the same status Positive.
Correct me if I'm wrong.

from pacific-emis-education-survey-tool.

ghachey avatar ghachey commented on August 23, 2024

Hi @ghachey perhaps instead of adding tablet ID, we can use lastEditedUser to identify the tablet? To avoid adding new metadata (tablet ID)

I am not sure about the validity of this. Does not the last edited user get merge. So when say worker device 3 gets with lastEditedUser Worker C gets merged into team leader device 1 that currently has lastEditedUser Worker B (for example). Then device one gets lastEditedUser Worker C. And the merged part survey on device 3 is also lastEditedUser Worker C. How does that information tell me with clarity where there file is? No, I prefer a tablet unique identifying for zero ambiguity.

from pacific-emis-education-survey-tool.

ghachey avatar ghachey commented on August 23, 2024

One more question about Status of survey: right now we have the following flow - the Positive survey when it's merged gets new status Merged, we think it's a bug, and it should keep the same status Positive. Correct me if I'm wrong.

What is this use case scenario you have discovered? I believe this could possibly be responsible for the duplicate and is related to issue #34 and #21 which is the original bug issue. Let's get this cleared up. Are you saying that a survey with surveyCompleted=POSITIVE can actually get merged and then switch to MERGED status? If this is what you have then yes, this is definitely an issue. Because when a survey has surveyCompleted=POSITIVE this means is it completed and thus there is no reason to merge this anywhere. Refer to my comment #34 (comment)

But your assumption that it "should be kept the same status POSITIVE" is not quite the correct handling of this. Because a survey with surveyCompleted=POSITIVE is considered completed and ready for review online and approval. No more merging of this should be allowed. Refer back to my comment linked in above paragraph.

from pacific-emis-education-survey-tool.

maratomega avatar maratomega commented on August 23, 2024

Hi @ghachey A survey is created and assigned a tablet id. When a user (the same email) opens and edits a survey from another device, his tablet id should be copied (replaced with the current one) or the id of the tablet is added to the previous one? The same applies to other users who edit or merge a survey. If the user will be different (other email), but the device is one, what should happen to id in the survey?

From Google guides: the tablet id is a unique application installation identifier. If the application is removed from the device and reinstalled, the id will change. The above scenario is based on the advice of Google to avoid problems in the future.

from pacific-emis-education-survey-tool.

ghachey avatar ghachey commented on August 23, 2024

I'm not sure I am following this. Perhaps can you re-phrase it in the familiar context scenarios (i.e. team leader device 1, worker device 2, 3, 4, etc.)

from pacific-emis-education-survey-tool.

maratomega avatar maratomega commented on August 23, 2024

@ghachey
Ok. The tablet id variable in a survey should store a list of all device identifiers on which the survey has ever changed, correct?

And, another thing, Do identifiers have to be duplicated to track how many times the device has been edited? E.g.: when worker device 2 has merged survey to team leader device 1, but later wants (device 2) to merge again to device 1

from pacific-emis-education-survey-tool.

ghachey avatar ghachey commented on August 23, 2024

This seems all good.

from pacific-emis-education-survey-tool.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.