Comments (5)
It makes sense to me @benquinteros, but i'll let Tim/Yousaf comment as they are the maintainers of this repo.
from jest-pact.
I remembered why we had a new type - it's because we add timeout
to the options. But, you're right that it jest-pact
should use the upstream PactOptions
directly.
I've fixed this in #188 , which
- Removes the definition of
PactOptions
- Introduces
JestPactOptions
, which unions the upstreamPactOptions
object and includes thetimeout
I wanted to hold off merging for a bit of discussion - simple questions, but worth thinking about before we release a version 1:
- Should
JestPactOptions
be calledPactOptions
? I'm not sure. I thought about separating out the Jest-specific options, but I'm not a big fan of having two ways of specifying options - users of this code shouldn't have to know what part of the framework they're configuring - For extra settings, should we put them under a namespace?
jestTimeout
?jest.Timeout
?
It's worth keeping in mind that currently this is really also jasmine-pact
as well as jest-pact
, since it exclusively uses jasmine features.
from jest-pact.
I forgot to close this issue before - this is fixed in 0.5.3.
It's technically a breaking change if you've explicitly used the type PactOptions
, because I've renamed it to JestPactOptions
- however, most people probably use it implicitly.
Since this is getting more traction, we'll release a version 1.0.0 soon, which will let us be clearer about breaking changes.
from jest-pact.
I'm wondering if it makes sense to have PactOptions
duplicated in this package - could it not just reference the upstream PactOptions
interface directly? This would mean it's always up-to-date with pact?
from jest-pact.
agree with @mefellows, it is better to reference the interface from pact-js directly. Happy for a PR proposal 👍 otherwise I look to address in the next couple of days
from jest-pact.
Related Issues (20)
- Pact tests fail with timeout on pact server setup HOT 2
- Log file does not contain data for all tests HOT 5
- Pact Verification Failed for multipart/form-data request HOT 2
- Support newer jest versions HOT 1
- future proofing `jest-pact` / `jasmine is undefined` HOT 2
- Race condition HOT 3
- Pact V3 support HOT 13
- Typescript Compiler failing with error TS2307 HOT 2
- jest-pact depends on Jasmine HOT 3
- Readme example - incorrect method name HOT 2
- Jest 27 support HOT 2
- "jest-pact": "0.9.0-beta.v3" not compatible "@pact-foundation/pact": "10.0.0-beta.45", HOT 3
- Error occurred in mock service: JSON::ParserError - 757: unexpected token at '"[{}]"' HOT 3
- Logging in jest-pact V3 Beta HOT 2
- move to pact-foundation org/scope HOT 6
- ci: move to GH actions
- pact-js 10.0.0 not compatible with jest-pact 0.9.0-beta.v3 HOT 2
- V3 DSL Feedback HOT 6
- Jest 29 support HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jest-pact.