Giter VIP home page Giter VIP logo

Comments (6)

YOU54F avatar YOU54F commented on August 29, 2024

Screenshot 2022-03-17 at 20 40 51

Looks like its already under the pact-foundation org in npm, but not scoped.

If we do scope, we may want to do the same with https://github.com/pact-foundation/mocha-pact

Thoughts anyone?

from jest-pact.

TimothyJones avatar TimothyJones commented on August 29, 2024

I think pact-foundation is still just an npm user- there isn’t actually an org. It would be worth converting it to an org, since it’s not really a person.

from jest-pact.

YOU54F avatar YOU54F commented on August 29, 2024

Agreed! Looks like it's easy enough to do as well

https://docs.npmjs.com/converting-your-user-account-to-an-organization

What are your thoughts on moving to a @pact-foundation scope?

from jest-pact.

YOU54F avatar YOU54F commented on August 29, 2024

Agreed! Looks like it's easy enough to do as well

https://docs.npmjs.com/converting-your-user-account-to-an-organization

I’ll get a canny roadmap ticket up to track this, as there will actually be a few tasks to consider and it’s worth taking the time to flesh them out

from jest-pact.

TimothyJones avatar TimothyJones commented on August 29, 2024

What are your thoughts on moving to a @pact-foundation scope?

I previously intentionally didn't do this, so that it would sort with other jest-related packages in package.json. My thinking was that it's idomatic for jest plugins / extensions to be jest-*, and it's likely that someone migrating away from Jest would want to keep pact. I don't feel strongly about it though.

For me, the arguments are:

  • Consistency with Jest extensions is reasonable, so jest-pact is an appropriate name
  • Consistency with other pact npm packages is also reasonable, so @pact-foundation/jest-pact is an appropriate name (although maybe @pact-foundation/jest-extensions is better - since pact is already in the name?)

I don't feel strongly.

I think that churning on the name will inconvenience some users, and doing it just so that it's under @pact-foundation isn't necessarily worth that pain.

I do think it's worth releasing a v1, since the interface is now pretty stable.

from jest-pact.

YOU54F avatar YOU54F commented on August 29, 2024

I think I am inclined to stick with jest-pact for the reasons outlined above.

My thinking was that it's idomatic for jest plugins / extensions to be jest-*

Yeah, that is how I felt when I initially named it, looking at other plugins in the jest ecosystem

I think that churning on the name will inconvenience some users, and doing it just so that it's under @pact-foundation isn't necessarily worth that pain.

This is a very fair point

I do think it's worth releasing a v1, since the interface is now pretty stable.

Nod.

We have the pact-foundation org now set up thanks to @mefellows

from jest-pact.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.