padok-team / terraform-google-network Goto Github PK

cf. https://github.com/padok-team/terraform-gcp-starter/issues/39

Applying this module on a freshly created Google project fails because the Compute Engine API is disabled.

Could we enable the API from within the module? It would look something like this:

resource "google_project_service" "compute_engine" {
  service            = "compute.googleapis.com"
  disable_on_destroy = false
}

Or, alternatively, could we add the activation of the API to the module's examples as a dependency?

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

• chore(deps): update terraform terraform-google-modules/network/google to v7.5.0
• chore(deps): update tflint plugin terraform-linters/tflint-ruleset-google to v0.27.1
• chore(deps): update actions/setup-go action to v5
• chore(deps): update google-github-actions/release-please-action action to v4
• chore(deps): update terraform google to v5
• chore(deps): update terraform terraform-google-modules/network/google to v9
• Click on this checkbox to rebase all open PRs at once

Detected dependencies

• Check this box to trigger a request for Renovate to run again on this repository

The module's current provider resource requirements are as follows:

required_providers {
  google = {
    source  = "hashicorp/google"
    version = ">= 3.90"
  }
  google-beta = {
    source  = "hashicorp/google-beta"
    version = ">= 3.90"
  }
}

These constraints are too flexible in my opinion. Terraform gave me no warning when using version 4.12 of the providers.

There is no output for VPC access connector, it's indispensible to export it in order to use it with other resources such as cloudfunctions.

╷
│ Error: project: required field is not set
│ 
│   with module.blueprint.module.network.module.network.google_compute_network.this,
│   on ../../modules/base/terrafrom-google-network/main.tf line 10, in resource "google_compute_network" "this":
│   10: resource "google_compute_network" "this" {
│ 
╵

Maybe, you should indicate somewhere that a provider is required

Some clients have to open a lot of connections per VM, so we should allow setting the field min_ports_per_vm on the resource google_compute_router_nat.

Right now we set the min_ports_per_vm to 0, but when we apply it sets it to 64, so putting 0 is confusing.

It could be great to allow dynamic port mapping as well instead of endpoint_independent_mapping.

The module should output vpc connectors (or at least their name), so we can use them, for instance in a cloud run setup.

The interface of this output should be discussed since the name are generated through a local

I used this module in a project to bootstrap a new network stack and I wanted a static IP for our NAT Gateway to be able to whitelist calls from Cloud Functions using the VPC Access Connector.
Let's discuss about naming for this feature here : #16

Could you please remove the dot in order to have "ERRORS_ONLY" ? I got the following error using your module
Error: expected log_config.0.filter to be one of [ERRORS_ONLY TRANSLATIONS_ONLY ALL], got ERRORS_ONLY.

Thanks !