pajamacat / nytimessearch Goto Github PK

Hey Jiafang,

👍 great work. Some notes after checking out the code:

• Be sure to use styles.xml whenever possible to keep your layout files clear of duplicate and unnecessary view presentation code.
• Good use of a Toolbar within your activities. Be sure to check out how to collapse the Toolbar on scroll using the CoordinatorLayout.
• You might want to improve the look and feel of the article item results. You should play with the padding, spacing, font sizes and look into the CardView. Right now the items look very crowded and hard to consume.
• Consider adding progress bars to your app whenever a network request goes out.
• Refer to the RecyclerView guide for an easier approach to item click handling using a decorator.
• Glad to see you used a date-time picker. To make sure the picker looks better on older devices (pre-Lollipop), you can check out third-party libraries for improved backwards compatibility.
• Glad to see you were able to get Retrofit working! Setting this up can be a little complicated (and confusing) to get used to at first but looks like you set it up pretty well.
• Good to see you got sharing working using the ShareActionProvider system. Keep in mind that this is simply leveraging the implicit intent system behind the scenes. Refer to this guide on implicit intents to see other common usages of them.

Let us know if you have any other thoughts or questions about this assignment. The next assignment (Twitter Client) will be especially important since it introduces the majority of the remaining pieces necessary to build a fully functional app including persistence with SQLite and modular view re-use with Fragments.

If you want to learn more about the scoring rubric for projects or how to improve your submission, check comments above as well as this project rubric breakdown.