Comments (1)
palerdot
commented on May 30, 2024
Issue Analysis:
import { isNumber as _isNumber } from "lodash"
Above piece of code was added, without adding lodash as a dependency. Scary thing was, lodash was a dependency for other libraries like storybook, babel etc ... so lodash was implicity available in my existing node_modules ...
The transpiled code was just require('lodash') from the main node_modules ... since, lodash was not listed as a dependency, when using this in a project that does not use lodash ... the code require('lodash') would fail since it would not have been installed ...
Even now, react is not listed as a dependency, but it is ok, since it is a react library, the assumption is people would be using it with their existing setup.
Tests were passing because lodash was some dependency of some devDependency, so lodash was implicitly available in the test environment ...
This is kind of scary and should find a way to sandbox the build and verify it ...
from react-d3-speedometer.
Related Issues (20)
- "Error: require() of ES Module" while unit testing with vitest and react-resting library
- Hi guys i am working on react speedometer chart in my company project where i want seven emotion and that niddle should move to the dominant emotion value and perticular to the colored segment as well
- Hi guys i am working on react speedometer chart in my company project where i want seven emotion and that niddle should move to the dominant emotion value and perticular to the colored segment as well
- Target animation HOT 1
- Fluid Width prop to take only necessary height HOT 5
- How to add a linear gradient color to needle HOT 5
- Facing app crash after importing using given example HOT 5
- Allow `segmentValueFormatter` to return a DOM node HOT 2
- Having two labels HOT 1
- Possible to make needle stop at max value? HOT 3
- Minus sign used in "segmentValueFormatter" is wrong HOT 2
- Setting Full width Prop to true is make the speedometer component to render partially and then re render on state change HOT 3
- Tooltip on hover on the segment HOT 1
- First value should be equivalent to min value given. Current min value - 1000 HOT 2
- Typescript React v18 react-d3-speedometer@next. I am getting Could not find a declaration file for module 'react-d3-speedometer'. HOT 1
- Custom Segment Labels should be an array with length of 10
- When will v2.0 become general available? is it stable already? HOT 2
- Custom segment labels display error HOT 3
- maxSegmentLabels not working HOT 1
- Can I set maxValue Dynamic HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-d3-speedometer.