Giter VIP home page Giter VIP logo

pancake-swap-interface-v1's Introduction

pancake-swap-interface-v1's People

Contributors

artistic709 avatar callil avatar chef-cheems avatar chef-chungus avatar chefhopper avatar chefhutch avatar chefkai avatar chikeichan avatar christophsiegenthaler avatar dy avatar hachiojidev avatar hav-noms avatar haydenadams avatar ianlapham avatar imgbot[bot] avatar kennyt avatar memoyil avatar mikedemarais avatar mirshko avatar moodysalem avatar mooncakehero avatar noahzinsmeister avatar pancake-cat avatar pancake-swap avatar paulrberg avatar rabbitdoge avatar richardpk avatar tpmccallum avatar vikmeup avatar wjmelements avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

pancake-swap-interface-v1's Issues

WalletConnect not interacting with site features/contracts MaxListenersExceededWarning

Bug Description
After unlocking/connecting a wallet on https://pancakeswap.finance/pools using WalletConnect and scanning the QR code with SafePal or Trust Wallet apps, the unlocked wallet cannot interact with the contracts/site features. For example, on the pools page if trying to unstake the site shows the transaction as pending but no transaction appears in the wallet app for approval.

Steps to Reproduce

  1. Go to https://pancakeswap.finance/pools
  2. Click on "connect" button (upper right).
  3. Select "WalletConnect".
  4. Scan QR with TrustWallet.
  5. Attempt to approve a pool or unstake from a pool.
  6. No transaction appears in wallet app, if unstaking the site shows it is pending.
  7. No transactions shown in BSCscan meaning there is not interaction with the contracts.
  8. Inspection of page shows [MaxListenersExceededWarning] (entire report below).

Expected Behavior
A clear and concise description of what you expected to happen.

Additional Context
Brave Version 1.18.77 Chromium: 87.0.4280.101 (Official Build) (64-bit) and Firefox Version 1.18.77. Chromium: 87.0.4280.101 (Official Build) (64-bit) Android 11. Trust Wallet 1.23.5 and SafePal 2.5.1. Multiple users reported the same issues regardless of browser or phone. Safari, Chrome, and various iOS versions excperienced the same issue.

console-export-2021-1-8_2-2-29.txt

WalletConnect.Unstake.Attempt.mp4

Add Roobee in the token list

{
"name": "ROOBEE",
"symbol": "ROOBEE",
"address": "0xa31b1767e09f842ecfd4bc471fe44f830e3891aa",
"chainId": 56,
"decimals": 18
}
LOGO:
ROOBEE

Add Beer to the list of token

{
      "name": "Beer Garden",
      "symbol": "Beer",
      "address": "0xbb8db5e17bbe9c90da8e3445e335b82d7cc53575",
      "chainId": 56,
      "decimals": 18
}

Logo:
Beer

Wallet Connect: unable to login

Bug Description
Unable to login pancakeswap using wallet connect (in trust wallet)

Steps to Reproduce

  1. Go to http://pancakeswap.finance
  2. Click on Unlock Wallet
  3. Click Wallet Connect
  4. Open TrustWallet with Binance Smart Chain wallet
  5. Scan QR code

...

Expected Behavior
Can login with Binance Smart Chain account in Trust Wallet

Actual Behavior
It said No account available
image

Additional Context

[Listing] Request listing for ACS, ACSI

{
"name": "ACryptoS",
"symbol": "ACS",
"address": "0x4197C6EF3879a08cD51e5560da5064B773aa1d29",
"chainId": 56,
"decimals": 18
},
{
"name": "ACryptoS(I)",
"symbol": "ACSI",
"address": "0x5b17b4d5e4009B5C43e3e3d63A5229F794cBA389",
"chainId": 56,
"decimals": 18
}

icon: https://app.acryptos.com/android-chrome-512x512.png

We are getting ~$50K volume/day:
https://pancakeswap.info/pair/0x2366ec9ddd1eb27506fa2ed48da8f2d9e99ed3c7
https://pancakeswap.info/pair/0x699c58d77027ae44608808b3863c394a194d76f6

Website: https:/acryptos.com/

We are currently listed on:
TrustWallet
https://www.coinbase.com/price/acryptos
https://coinmarketcap.com/currencies/acryptos/
https://www.coingecko.com/en/coins/acryptos
https://dappradar.com/binance-smart-chain/defi/acryptos

dddd

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

CAKE stats on main page showing incorrectly when wallet isn't connected.

Bug Description
When going to pancakeswap.finance home page, the "total CAKE supply" shows 137,243,856 (at the time of writing this) and "total cake burned" as 0.

Steps to Reproduce

  1. Go to pancakeswap.finance home page.
  2. Do not unlock a wallet or sign out of any unlocked wallets.
  3. Look at the Cake Stats
    ...

Expected Behavior
The Cake stats should show the correct values without having to unlock a wallet.

Additional Context
No Connected Wallter:
image

Connected Wallet:
image

Add MARS, YFMR to the list of token

Please, add MARS, YFMR token to the tokens list. Our website http://yfmars.app/

{
"name": "marsUSD",
"symbol": "MARS",
"address": "0x7e440598f8f63fccd9b12a606263a02a06cfb16a",
"chainId": 56,
"decimals": 18,
"logoURI": "/images/coins/MARS.png"
},
{
"name": "YFMARS",
"symbol": "YFMR",
"address": "0x9b3ed616c4ff49023a89f4da8b85cce22c0f8cb3",
"chainId": 56,
"decimals": 18,
"logoURI": "/images/coins/YFMR.png"
}

https://github.com/yfmars-dev/pancake-swap-interface/blob/master/public/images/coins/MARS.png
https://github.com/yfmars-dev/pancake-swap-interface/blob/master/public/images/coins/YFMR.png

Dashboard view to see my whole Farm.

I have been testing and using this Dapp alot. After staking some cakes for many days I started using farms in order to stake flip tokens.

I had staked 4 different types of flip tokens to test the app further. It does have a nice feature on dashboard to see the number of cakes earned. It would be great to have the details of farms in a tabular view. (Like farmer watching farms from height using binoculars with cow boy hat. Just kidding).

Furthermore, Same view can be modified later with little visual fun in it like visual farms with crop growing. User can also tap or hover on farms to see flip tokens name.

Gitcoin bounty - 08/12/2020

GitCoin Bounty - Various tasks

Stack
Typescript/React

Add Text/Image loading state (component loader).

Add CTA cards to the dashboard

  • Figma/more information will be shared to the applicant who is accepted.

Farms revamp

  • Update cards to revised designs
  • Add APY calculator modal
  • Add search
  • Add toggle to show only the farms you're participating in
  • Add list view
  • All designs are available to the applicant who has been accepted.

Swapping through low-liquidity pairs

Bug Description
Website offers to swap some tokens through low-liquidity pairs while there are high-liquidity pairs for the same tokens. Examples:
For BNB to CAKE website offers to use BNB > BUSD > CAKE, while the better route is BNB > CAKE (directly), because there is an $11M pair for that.
USDT to NYA swap: website offers USDT > WBNB > NYA, while the better route is USDT > WBNB > CAKE > NYA (more liquidity there)

Steps to Reproduce

  1. Go to exchange.pancakeswap.finance
  2. Set a swapping route: from USDT to NYA (it shows out the bug more clearly and appears more often)
  3. Enter "20" in the top field (USDT)
  4. You will see the wrong route USDT > WBNB > NYA
    ...

Expected Behavior
A correct route for USDT > NYA example is USDT > WBNB > CAKE > NYA (or any other through CAKE). The same is for other routes: it should rather choose high-liquidity pairs.

Additional Context
Some screenshots showing examples above with wrong routes
Снимок экрана от 2020-12-21 02-46-35
Снимок экрана от 2020-12-21 02-11-17

Github Bounty

  1. Adding the explainer to the homepage
  2. Pool/Farms list view
  3. Migrate exchange to pancakeswap.finance
  4. Sidebar menu implementation

Missing translations for exhange. on Crowdin

Note:

Please can we setup a separate Crowdin project for the farm / staking / syruppool site - it is impractical to manage them in one project, and needlessly resource intensive for our users - they will be fetching all translations for both domains when they visit EITHER domain.

As the two sites are different applications - this is not useful, the users only need the translations being used by the domain they are visiting.

This would mean renaming the current pancakeswap Crowdin project to pancakeswap-exchange and creating a new one, pancakeswap-farm (or similar).

Bug Description

  • There are a lot of missing translation strings for the exchange.pancakeswap domain in Crowdin, listed below

Missing translations:

  • Connect to a wallet
  • From (estimated)
  • To (estimated)
  • Search name or paste Address
  • Connect to a wallet to view your liquidity.
  • Connect wallet
  • About
  • Code
  • Telegram
  • On
  • Off
  • Your transaction will revert if there is a large, unfavorable price movement before it is confirmed.
  • Your transaction will revert if the price changes unfavorably by more than this percentage.
  • Your transaction will revert if it is pending for more than this long.
  • Insufficient liquidity for this trade.
  • Approving
  • Approved
  • Approve
  • Select a token to find your liquidity.
  • Connect to a wallet to find pools
  • Pool Found!
  • You don’t have liquidity in this pool yet.
  • No pool found
  • Create pool.
  • Loading
  • Maximum sold
  • Minimum received
  • Your transaction will revert if there is a large, unfavorable price movement before it is confirmed.
  • The difference between the market price and estimated price due to trade size
  • Price impact
  • Liquidity Provider Fee
  • For each trade a 0.2% fee is paid. 0.17% goes to liquidity providers and 0.03% goes to the PancakeSwap treasury.
  • Route
  • Routing through these tokens resulted in the best price for your trade.
  • Initial prices
  • Prices
  • and pool share
  • per
  • Deposited
  • Rates
  • Share of Pool:
  • Create Pool & Supply
  • Confirm Supply
  • Import Pool
  • Use this tool to find pairs that don't automatically appear in the interface.
  • Add
  • Remove
  • Liquidity
  • When you add liquidity, you are given pool tokens representing your position. These tokens automatically earn fees proportional to your share of the pool, and can be redeemed at any time.
  • Removing pool tokens converts your position back into underlying tokens at the current rate, proportional to your share of the pool. Accrued fees are included in the amounts you receive.
  • Connect to a wallet to view your liquidity.
  • Your position
  • Pooled
  • Your pool tokens:
  • Your pool share:
  • Insufficient
  • balance

Lastly:

CROWDIN_APIKEY and REACT_APP_CROWDIN_PROJECTID

In order for the Crowdin API queries to work - you will need REACT_APP_CROWDIN_APIKEY & REACT_APP_CROWDIN_PROJECTID env variables set in your root .env.development.local file - please contact a dev if you need these.

Can you please help me with CROWDIN_APIKEY and REACT_APP_CROWDIN_PROJECTID so that I can run a local copy of pancake. It used to work till last update.

Font sizing issue on Swap

image

Bug Description
the 289.6 Cake is 16px, others are 14px. They all should be 14px (defined as “small” in style guide)

Additional Context
Visible when making a swap on the Exchange

swap prices doesnt match market prices by a huge margin

Bug Description
swap prices doesn't match market prices, for example if I want to swap ETH to DAI and the current market price of eth its 1220 pancake swap will show a swap price of 1208 or lower. maybe 12 dollars isn't much but I even experienced over 50 dollars difference which its huge. could it be an oracle problem ?
Steps to Reproduce

  1. Go to : https://exchange.pancakeswap.finance/?_gl=1*zutr2b*_ga*MTU5MDk2NzM3Mi4xNjA5NjgwNDcz*_ga_334KNG3DMQ*MTYxMDA2MDI3NS4xMy4xLjE2MTAwNjAzMTguMA..#/swap: select
  2. Click on : select ETH and DAI and check the price of the token showed on the DEX and the current market value, of course isn't goin to be exactly the market value however the difference its huge.

Expected Behavior
its should show a price close to the market value therefore the transaction should be close to the market value.
Additional Context
At some point today ETH was around 1280 DAI, not in a single moment the price showed nor the price of the transaction was close to the 1280 it never went over the 1239 mark.
Again maybe its an oracle problem or its interaction with the contract.
Maybe adding a chart on the side like other DEXS have on their swap may help to compare or if there something wrong with that token or swap on particular or at least to have the option to not execute the swap if something its obviously wrong
I hope u can fix this because it can impact negatively on pancakeswap. you can contact me for any additional information you may require.
Thanks.

Fix our testing && add Readme introduction

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

CHEAT NIJA LOGO

{
"name": "CHEAT NIJA",
"symbol": "CHEAT",
"address": "0x73ea129d538bb1e75c1c5e99a77666409005681e",
"chainId": 56,
"decimals": 18,
"logoURI": "cheatninja.png"
},
cheatninja

Exchange submenu incorrectly closing and not indicating location

Bug Description
When arriving on the exchange, the submenu is shut and there's no indicator of which page a user is on.

Expected Behavior

  1. click “exchange” in menu, submenu stays open and page changes to exchange
  2. when i arrive on exchange, submenu is open, with the green line showing me my current page
  3. when i collapse the entire menu, the icon for the exchange section should have a green line

Settings modal doesn't fit on min device width

image

Bug Description
On a device with a width of 320px (the recommended minimum width), the settings dialogue doesn't fit on the screen.

We should push the options onto the next line in this scenario - see following image for context

image

Additional Context
This is accessible from the swap page when clicking on the setting button

BinanceChain Browser Extension support

Add Binance Chain Chrome Extension as an option for linked wallets. This can improve onboarding experience for desktop users and drive adoption:

  • Straightforward onboarding ⏩
  • No need to deal with Custom RPC Servers on MetaMask ❌
  • Branded experience with Binance 🥞

Implementation Notes on https://docs.binance.org/smart-chain/wallet/wallet_api.html

  • Binance uses window.BinanceChain for provider API access while the convention (ie. MetaMask) uses window.ethereum.
  • window.BinanceChain might be straight-swappable with window.ethereum as it implements the same interface.

I'm fairly new to the codebase but would love to help out!


image

ADD ROYAL : Royal Finance

Name : Royal Finance
Address : 0x2e4b9a52836aeb2e6809fa760c9b799885fd6c34
Symbol : ROYAL
Decimals : 18
ChainID : 56
Logo :
0x2e4b9a52836aeb2e6809fa760c9b799885fd6c34

Dashboard view to see the details of Farms.

I have been testing and using this Dapp alot. After staking some cakes for many days I started using farms in order to stake flip tokens.

I had staked 4 different types of flip tokens to test the app further. It does have a nice feature on dashboard to see the number of cakes earned. It would be great to have the details of farms in a tabular view. (Like farmer watching farms from height using binoculars with cow boy hat. Just kidding).

Furthermore, Same view can be modified later with little visual fun in it like visual farms with crop growing. User can also tap or hover on farms to see flip tokens name.

Display APY in staking page

Is your feature request related to a problem? Please describe.
N/A

Describe the solution you'd like
Display APY in staking page
https://pancakeswap.finance/staking

Total staked CAKE = Total Supply of SYRUP
NUMBER_BLOCK_IN_ONE_YEAR = 365 * 86400 /3
APY = 10 CAKE per block *NUMBER_BLOCK_IN_ONE_YEAR / Total Supply of SYRUP * 100%

Describe alternatives you've considered

Additional context
N/A

Whitelist BUNNY Token Request

Request a token whitelist. ref: #64
Please let me know if there are any other requirements I have to do for whitelisting.

{
"name": "Bunny Token",
"symbol": "BUNNY",
"address": "0xC9849E6fdB743d08fAeE3E34dd2D1bc69EA11a51",
"chainId": 56,
"decimals": 18
}

BUNNY.png


BUNNY PROJECT
PancakeBunny is a new and rapidly growing DeFi yield aggregator that is used for PancakeSwap. The PancakeBunny protocol empowers farmers to leverage their yield-seeking tendencies to optimize yield compounding strategies. We are providing strategies for the various needs of farmers from the highest yield seekers to the risk reward optimizing smart investors

website: https://pancakebunny.finance
telegram: https://t.me/pancakebunnyfinance
email: [email protected]
twitter: https://twitter.com/PancakeBunnyFin
pancakeswap: https://pancakeswap.info/token/0xc9849e6fdb743d08faee3e34dd2d1bc69ea11a51
coingecko: https://www.coingecko.com/en/coins/pancake-bunny
bscscan: https://bscscan.com/token/0xc9849e6fdb743d08faee3e34dd2d1bc69ea11a51

WalletConnect link not working, js site crashes

Bug Description
When navigating to exchange.pancakeswap.finance with latest version of Chrome or Safari (from OSX Big Sur also latest version) and trying to connect with Walletconnect after reading the QR with my iPhone 12 (iOS latest version) and also latest version of TrustWallet the site crashes. Below it's the screenshot.
image

Steps to Reproduce

  1. Go to exchange.pancakeswap.finance.
  2. Click on "connect" button (upper right).
  3. Select "WalletConnect".
  4. Scan QR with TrustWallet
  5. Site JS crashes.
    ...

Expected Behavior
The expected behavior should be that the app won't crash and let me stake or trade my tokens.

Video
uxjDVzMMAI

Local dev-experience - error on localhost when trying to set up exchange

Bug Description

  • While on either MAIN NET(56) or TEST NET (97), attempting to create an exchange pair throws a "Failed to fetch multicall chunk" error after selecting the 'to' token.
  • It then throws this error consistently, on a timeout
  • Error:
Failed to fetch multicall chunk [{…}] 56 Error: call revert exception (method="aggregate((address,bytes)[])", errorSignature=null, errorArgs=[null], reason=null, code=CALL_EXCEPTION, version=abi/5.0.5)

Steps to Reproduce

  1. Go to "http://localhost:3000/#/swap"
  2. Click on "Select a token"
  3. Select 'BUSD'
  4. See error
  5. Add '1' to either value, and it will remove the other value. The swap rate has not been discovered.
    ...

Expected Behavior

  • No error when selecting second token in pair, success message like:
Success to fetch multicall chunk (21) [{…}, {…}, {…}, {…}, {…}, {…}, {…}, {…}, {…}, {…}, {…}, {…}, {…}, {…}, {…}, {…}, {…}, {…}, {…}, {…}, {…}] 56
  • When value of one token is input, you get an exchange rate.

Additional Context
Screen capture of behaviour: https://www.loom.com/share/962e7d96bd3b416a87f1db1f73e26932

Nav bar is a bit jumpy - making it hard to use on mobile devices

Image.from.iOS.MP4

Bug Description
When scrolling up to the top of the page, the nav bar can be a bit glitchy and appear, disappear and appear again. It makes it difficult for users to access the menu when they need to.

Expected Behavior
Nav bar should appear smoothly and quickly

Error gas required exceeds allowance (30000000) or always failing transaction

Bug Description
My complete copy of Pancake Swap failed to create a new liquidity pool for any pair. It returns "gas required exceeds allowance (30000000) or always failing transaction".

Steps to Reproduce
I made a full copy of Pancake environment, creating new Factory, Router and WBNB (for WETH parameter).
So I made a clone of the interface project to adapt the contract addresses in the interface and in the sdk source.
When I tried to create a new liquidity pool, it was necessary to approve the coin, but it was not possible to Create and Supply.
At F12 (Developer Tools) has an error. It seems to occur at estimate function.

Expected Behavior
I hope you guys could share some possible solutions to solve this problem.

Additional Context
An additional info, I changed many part of the code /node_modules/@pancakeswap-libs/sdk to change Factory and Router addresses.

Selection_590

It seems to occur on estimate function:
Selection_592

STAKING Cake tokens cannot be unlocked

Function: leaveStaking(uint256 _amount)

MethodID: 0x1058d281
[0]: 000000000000000000000000000000000000000000000019dc98e33a83632772

outcome
Warning! Error encountered during contract execution [out of gas]

The compiled contract might be susceptible to EmptyByteArrayCopy (medium-severity), DynamicArrayCleanup (medium-severity) Solidity Compiler Bugs.

Calculate TVL of swap all lp pairs, 24 hours volume of swap

Calculate TVL of swap all lp pairs, 24 hours volume of swap

Currently, our TVL is only from Farming pools, We haven't calculated the total value provided via liquidity in the swap exchange.

We need the two functions:

caluculateTVL = () = {}
calculateVolume = (hours) => {}

Reward to first finishers:

250 CAKE for calculateTVL (roughly $175)
400 CAKE for calculateVolume (roughly $280)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.