Comments (3)
ms-ati
commented on August 19, 2024
1
Yeah, I suggest we give up on this for now @JacobEvelyn
from memo_wise.
ms-ati
commented on August 19, 2024
I'm familiar with this idea! This is optimizing to return a literal value, right?
So, right off the bat, @JacobEvelyn do you agree that this approach is fundamentally incompatible with immutable objects?
Or do you see a path forward to supporting this on immutable objects?
from memo_wise.
JacobEvelyn
commented on August 19, 2024
Thanks @ms-ati!
This is optimizing to return a literal value, right?
Yes, exactly!
do you agree that this approach is fundamentally incompatible with immutable objects?
Yep! I forgot to mention that in my description above but I was assuming we'd branch and only do this if the object is not frozen. I realize now that if an object is frozen after the first method call and then we try to reset the memoization that wouldn't work though. Does that seem like a sufficient edge case to no longer consider this path?
from memo_wise.
Related Issues (20)
- Investigate whether we can speed up tests
- Method arguments with specific names can be overwritten
- Create easier way to compare changes against current `MemoWise` version HOT 1
- Memowise v1.2.0 regression with Rails concerns HOT 8
- Broken handling of inheritance after "Optimize zero-argument methods" HOT 4
- Avoid defining methods unless needed
- Use squiggly heredocs everywhere
- Multiple composition inheritance bug HOT 8
- Error memo_wising in subclass with included module HOT 2
- Tidy CHANGELOG
- Use method-specific instance variables for methods that take arguments HOT 1
- Use nested hashes instead of arrays for methods with multiple required arguments HOT 2
- Array data structure leading to multiple bugs
- Release 1.4.0 breaks simple inheritance HOT 4
- Cannot use memoized class level method in sub classes HOT 5
- Fix thread safety tests which are non-deterministic on TruffleRuby
- SystemStackError when memoized method calls memoized super method HOT 2
- memo_wise raises error when memoizing a method in a module that's included in a class that overrides `initialize` HOT 1
- Sorbet compatibility
- Documentation: Add alt_memery & memoist3 to performance comparison table HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from memo_wise.