Wrong attributes are stored for encrypted attributes about paper_trail HOT 6 CLOSED

@ghiculescu yes, that's expected. When using the default "non deterministic" encryption, each time you encrypt a value it generates a random initialization vector, so the encrypted payload will be different, even if the cleartext is the same.

from paper_trail.

I can make a PR if that’s confirmed ^

from paper_trail.

I think the root cause is roughly here.

The type here is a ActiveRecord::Encryption::EncryptedAttributeType, and this returns a different result each time it's called with the same input:

(ruby) Post.type_for_attribute(:name).serialize('asdf')
"{\"p\":\"RLLLSA==\",\"h\":{\"iv\":\"H7c94XC/8rKT9jN/\",\"at\":\"QJmzn+d6IJ+4lnGRpOM3Ug==\"}}"
(ruby) Post.type_for_attribute(:name).serialize('asdf')
"{\"p\":\"ngsW0A==\",\"h\":{\"iv\":\"yeLWQvJucVR+LVcQ\",\"at\":\"yFddZTzXzefl+VzR1sCh+w==\"}}"
(ruby) Post.type_for_attribute(:name).serialize('asdf')
"{\"p\":\"M2O6tQ==\",\"h\":{\"iv\":\"TUz7TkOsgUN9XjoL\",\"at\":\"8zhIkMB3f0dHG2ea8qBWXw==\"}}"

Assuming this is intentional (I think it is, but not certain), then Paper Trail should not re-run the serialization since it returns a new value. We could skip re-serializing using a mechanism similar to TypeSerializers::PostgresArraySerializer.

@jorgemanrubia sorry to tag you on a gem that you have nothing to do with, but I was hoping you could just confirm if it's intended that EncryptedAttributeType#serialize returns a different output each time it's called.

from paper_trail.

This issue has been automatically marked as stale due to inactivity.
The resources of our volunteers are limited.
Bug reports must provide a script that reproduces the bug, using our template. Feature suggestions must include a promise to build the feature yourself.
Thank you for all your contributions.

from paper_trail.

Okay. I think this is a bug then.

from paper_trail.

This issue has been automatically marked as stale due to inactivity.
The resources of our volunteers are limited.
Bug reports must provide a script that reproduces the bug, using our template. Feature suggestions must include a promise to build the feature yourself.
Thank you for all your contributions.

from paper_trail.