papermc / starlight Goto Github PK

Rewrites the light engine to fix lighting performance and lighting errors

License: Other

Java 100.00%

fabric forge java light-engine minecraft minecraft-performance

starlight's Issues

(Question) Is starlight safe to use via clients during reproduction?

I usually never ask something like this before but; Can starlight be safely used in reproduction environments such as hypixel or other worlds without it causing issues in process?

The reason why i bring this up is because i planned to switch from phosphor to starlight all together to try and make the lighting engine 'improved' in some cases.

Mod pack inclusion?

Do you have a specific policy for inclusion in a pack. I am working on a github repo pack for fabric optimization mods. I want to include starlight. Is that fine if I cite the repo and your name in the sources file? Sorry to make an issue report of it I didn't know how else to reach you.

When upgrading from 0.0.1 to 0.0.2, your world is deleted

When flying over oceans, I have noticed some chunks are randomly lit up. There is no light source and when f3 is pressed, it says that there isn't any block light. I don't know if this is client side or server side.
Mods on server: Starlight, Tic-Tacs, Lithium, SmoothBoot, BBOR, Carpet, Carpet Extra, Fabric Api, Fast Furnace, Fabric Geyser, Hydrogen, Krypton

Block Lighting bugs in flat neighboring chunks

Expected Behavior

When I place the light source everything lights up properly

Actual Behavior

When I place the light source, everything doesn't light up properly

Reproduction Steps

Build something like this (the wall or floor must be completely flat (or at least the part where light reaches) and be on the edge of the other chunk, but the bug will not occur)
Place a light source at least 1 block away from the wall or floor

Mod Version

starlight-0.0.1-SNAPSHOT

Additional screenshots

5681942750785458012
/execute in minecraft:overworld run tp @s 44.39 37.57 -304.14 -112.63 -8.26

5681942750785458012
/execute in minecraft:overworld run tp @s -955.04 25.00 88.25 68.13 9.18

Missing chunk emptiness map entries

Hey there,
I just crashed, while joining a server, here are the logs:
https://paste.ee/p/eMRC5
Is that some mod incompatibility again?
Thanks!

Missing homepage and issues tags inside the fabric.mod.json file.

Please don't be mad for reporting something so pointless.

Tons of lag when going through chunk boundaries

Phosphor has recently just fixed this Minecraft Bug. Is it possible for you to as well?

No mod icon

No mod icon in ModMenu

VoxelShape#unionCoversFullCube is too slow

Need to port https://github.com/Spottedleaf/Tuinity/blob/dev/lighting/patches/server/0058-fixup-Highly-optimise-single-and-multi-AABB-VoxelSha.patch#L628-L670
Affects mainly snowy areas

Blocks removed for missing registry do not cause block light updates

When you load a chunk which has blocks that do not exist in it they leave holes in the world and do not cause block light updates. This appears to be vanilla lighting behavior and has been tested in Phosphor and Starlight. The best way to reproduce this is to add a mod to your game that adds blocks, place them down exit the game remove the mod and reload. When you rejoin they will be removed from the world since the registry entry for them does not exist. The blocks that were removed appear they have no block light because they don't cause lighting updates when they are removed.

Conflict between the Create and Starlight

When using Create (Create v0.3.1c) and starlight (starlight v1.0.0-RC2) at the same time, the client will crash.
Simply disable the starlight mod to solve the problem.
For those that have also deployed Starlight on the server, it should not need to be disabled.

If you need any log or something.Please reply this issues.

Starlight + Dimensional Threads crash

A modpack put in my mod World Blender, Dimensional Threads, and StarLight. However, in my dimension, the game crashes. I reported the issue to Dimensional Threads but they closed the report: WearBlackAllDay/DimensionalThreading#21

The crash appears during World Blender's entity ticking but does not appear in the stacktrace. Instead Starlight does. Here's the crash stacktrace from the latest.log that was given to me by the modpack dev
https://paste.ee/p/7PQ0o

Here's my ticking code for my entity
https://github.com/TelepathicGrunt/WorldBlender-Fabric/blob/35e2237f7657487b8c38ae649f79d5e7a513397e/src/main/java/com/telepathicgrunt/worldblender/entities/ItemClearingEntity.java#L60-L126

I'm wondering if it because I am removing a ton of blocks when my entity tick at first. And that change of blocks causes StarLight to try and recalculate lighting for the area and then crashes due to DimensionalThreading trying to multithread the dimension.

Sorry I couldn't be of more help. Hopefully this is enough to try and get a reproducible case with all three mods on.

Full CPU usage and then crash.

After loading the world again chunks were not saved, I tried reproducing my steps since this was a fresh world but this time it was running without issues. Probably nothing useful in the logs...

---- Minecraft Crash Report ----
// This is a token for 1 free hug. Redeem at your nearest Mojangsta: [~~HUG~~]

Time: 4/30/21, 11:35 PM
Description: Exception in server tick loop

java.lang.OutOfMemoryError: Java heap space
	at Not Enough Crashes deobfuscated stack trace.(1.16.5+build.4)
	at ca.spottedleaf.starlight.common.light.SWMRNibbleArray.toVanillaNibble(SWMRNibbleArray.java:363)
	at ca.spottedleaf.starlight.common.light.StarLightInterface$2.getLightSection(StarLightInterface.java:182)
	at net.minecraft.world.ChunkSerializer.serialize(ChunkSerializer:251)
	at net.minecraft.server.world.ThreadedAnvilChunkStorage.save(ThreadedAnvilChunkStorage:716)
	at net.minecraft.server.world.ThreadedAnvilChunkStorage.method_20583(ThreadedAnvilChunkStorage:388)
	at net.minecraft.class_3898$$Lambda$9570/0x0000000801b67c40.accept(Unknown Source)
	at java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:183)
	at java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:177)
	at java.util.Iterator.forEachRemaining(Iterator.java:133)
	at java.util.Spliterators$IteratorSpliterator.forEachRemaining(Spliterators.java:1801)
	at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:484)
	at java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:474)
	at java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:150)
	at java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:173)
	at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
	at java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:497)
	at net.minecraft.server.world.ThreadedAnvilChunkStorage.save(ThreadedAnvilChunkStorage:385)
	at net.minecraft.server.world.ServerChunkManager.save(ServerChunkManager:321)
	at net.minecraft.server.world.ServerWorld.save(ServerWorld:710)
	at net.minecraft.server.MinecraftServer.save(MinecraftServer:567)
	at net.minecraft.server.integrated.IntegratedServer.tick(IntegratedServer:83)
	at net.minecraft.server.MinecraftServer.handler$dod000$modifiedRunLoop(MinecraftServer:8310)
	at net.minecraft.server.MinecraftServer.runServer(MinecraftServer:651)
	at net.minecraft.server.MinecraftServer.method_29739(MinecraftServer:257)
	at net.minecraft.server.MinecraftServer$$Lambda$8351/0x0000000801866c40.run(Unknown Source)
	at java.lang.Thread.run(Thread.java:829)


A detailed walkthrough of the error, its code path and all known details is as follows:
---------------------------------------------------------------------------------------

-- System Details --
Details:
	Minecraft Version: 1.16.5
	Minecraft Version ID: 1.16.5
	Operating System: Linux (amd64) version 5.8.0-50-generic
	Java Version: 11.0.11, BellSoft
	Java VM Version: OpenJDK 64-Bit Server VM (mixed mode), BellSoft
	Memory: 13007968 bytes (12 MB) / 4294967296 bytes (4096 MB) up to 4294967296 bytes (4096 MB)
	CPUs: 8
	JVM Flags: 2 total; -Xms4096m -Xmx4096m
	Suspected Mods: Starlight (starlight)
	Fabric Mods: 
		advancedchat: AdvancedChat 3.2.0-1.16.5
		alloy_forgery: Alloy Forgery 1.1.0
		amecs: Amecs 1.3.4+mc.1.16.3
		amecsapi: Amecs API 1.1.4+mc1.16.5
		angerable-patch: Angerable Patch 1.1.0-1.16.4
		architectury: Architectury 1.11.144
		autoconfig1u: Auto Config v1 Updated 3.3.1
		autoconfigtoml: AutoConfig-TOML 1.0.0-fabric
		bambootweaks: Bamboo Tweaks 2.0.5
		banner_capes: Banner Capes 0.2.1
		bendy-lib: Bendy api 1.1.0
		bettercaves: YUNG's Better Caves 1.16.5-1.1
		betterend: Better End 0.9.3-pre
		bettermineshafts: YUNG's Better Mineshafts 1.16.4-1.0
		betternether: Better Nether 5.0.7
		biomemakeover: Biome Makeover 1.16.5-1.3.7
		bundlesplus: bundles plus 0.1.8
		byg: BYG 1.1.7
		c2me: Concurrent Chunk Management Engine 0.1-SNAPSHOT
		campanion: Campanion 1.3.5
		cardinal-components-base: Cardinal Components API (base) 2.7.1
		cardinal-components-entity: Cardinal Components API (entities) 2.7.1
		cardinal-components-world: Cardinal Components API (worlds) 2.6.0
		carpet: Carpet Mod 1.4.34
		cavebiomes: Cave Biomes 0.6.2
		charm: Charm 2.3.3-snapshot
		chesttracker: Chest Tracker 0.8.13
		cinderscapes: Cinderscapes 1.3.3
		cloth-api: Cloth API 1.5.50
		cloth-armor-api-v1: Cloth Armor API v1 1.5.50
		cloth-basic-math: Cloth Basic Math 0.5.1
		cloth-client-events-v0: Cloth Client Events v0 1.5.50
		cloth-common-events-v1: Cloth Common Events v1 1.5.50
		cloth-config2: Cloth Config v4 4.11.19
		cloth-datagen-api-v1: Cloth Datagen v1 1.5.50
		cloth-durability-bar-api-v1: Cloth Durability Bar API v1 1.5.50
		cloth-dynamic-registry-api-v1: Cloth Dynamic Registry API v1 1.5.50
		cloth-scissors-api-v1: Cloth Scissors API v1 1.5.50
		cloth-utils-v1: Cloth Utils v1 1.5.50
		com_electronwill_night-config_core: core 3.6.3
		com_electronwill_night-config_toml: toml 3.6.3
		com_moandjiezana_toml_toml4j: toml4j 0.7.2
		consistency_plus: Consistency Plus 0.2.0-beta
		cotton-client-commands: Cotton Client Commands 1.0.1+1.16-rc1
		croptopia: Croptopia 1.3.1
		cullleaves: Cull Leaves 2.1.0
		customportals: Custom Portals 1.3.0
		darkness: True Darkness 1.6.58
		dashloader: DashLoader 1.2-alpha-DevBuild8
		defaultsettings: DefaultSettings 3.0.2
		dehydration: Dehydration 1.1.2
		dynamicsoundfilters: Dynamic Sound Filters 1.2.0+1.16.5
		emotecraft: Emotecraft 2.0.1
		enchant_giver: Enchant Giver 1.0.3
		enhancedblockentities: Enhanced Block Entities 0.1
		entityculling: EntityCulling-Fabric 1.2.1
		environmentz: EnvironmentZ 1.0.13
		fabric: Fabric API 0.33.1+1.16
		fabric-api-base: Fabric API Base 0.2.1+9354966b7d
		fabric-api-lookup-api-v1: Fabric API Lookup API (v1) 1.0.0+dc716ea17d
		fabric-biome-api-v1: Fabric Biome API (v1) 3.1.1+ca58154a7d
		fabric-blockrenderlayer-v1: Fabric BlockRenderLayer Registration (v1) 1.1.5+ca58154a7d
		fabric-command-api-v1: Fabric Command API (v1) 1.1.1+351679a77d
		fabric-commands-v0: Fabric Commands (v0) 0.2.2+ca58154a7d
		fabric-containers-v0: Fabric Containers (v0) 0.1.11+9354966b7d
		fabric-content-registries-v0: Fabric Content Registries (v0) 0.2.1+ca58154a7d
		fabric-crash-report-info-v1: Fabric Crash Report Info (v1) 0.1.3+ca58154a7d
		fabric-dimensions-v1: Fabric Dimensions API (v1) 2.0.6+61336ba97d
		fabric-entity-events-v1: Fabric Entity Events (v1) 1.0.3+ca58154a7d
		fabric-events-interaction-v0: Fabric Events Interaction (v0) 0.4.2+ca58154a7d
		fabric-events-lifecycle-v0: Fabric Events Lifecycle (v0) 0.2.1+ca58154a7d
		fabric-game-rule-api-v1: Fabric Game Rule API (v1) 1.0.6+ca58154a7d
		fabric-item-api-v1: Fabric Item API (v1) 1.2.1+ca58154a7d
		fabric-item-groups-v0: Fabric Item Groups (v0) 0.2.7+2868a2287d
		fabric-key-binding-api-v1: Fabric Key Binding API (v1) 1.0.4+9354966b7d
		fabric-keybindings-v0: Fabric Key Bindings (v0) 0.2.1+ca58154a7d
		fabric-language-kotlin: Fabric Language Kotlin 1.5.0+kotlin.1.4.31
		fabric-language-scala: Fabric Language Scala 1.0.0
		fabric-lifecycle-events-v1: Fabric Lifecycle Events (v1) 1.2.1+ca58154a7d
		fabric-loot-tables-v1: Fabric Loot Tables (v1) 1.0.2+ca58154a7d
		fabric-mining-levels-v0: Fabric Mining Levels (v0) 0.1.3+ca58154a7d
		fabric-models-v0: Fabric Models (v0) 0.3.0+bc7a746f7d
		fabric-networking-api-v1: Fabric Networking API (v1) 1.0.1+ca58154a7d
		fabric-networking-blockentity-v0: Fabric Networking Block Entity (v0) 0.2.8+ca58154a7d
		fabric-networking-v0: Fabric Networking (v0) 0.3.2+ca58154a7d
		fabric-object-builder-api-v1: Fabric Object Builder API (v1) 1.9.4+9354966b7d
		fabric-object-builders-v0: Fabric Object Builders (v0) 0.7.2+ca58154a7d
		fabric-particles-v1: Fabric Particles (v1) 0.2.4+ca58154a7d
		fabric-permissions-api-v0: fabric-permissions-api 0.1-SNAPSHOT
		fabric-registry-sync-v0: Fabric Registry Sync (v0) 0.7.4+ca58154a7d
		fabric-renderer-api-v1: Fabric Renderer API (v1) 0.4.2+2868a2287d
		fabric-renderer-indigo: Fabric Renderer - Indigo 0.4.4+ca58154a7d
		fabric-renderer-registries-v1: Fabric Renderer Registries (v1) 2.3.0+2868a2287d
		fabric-rendering-data-attachment-v1: Fabric Rendering Data Attachment (v1) 0.1.5+ca58154a7d
		fabric-rendering-fluids-v1: Fabric Rendering Fluids (v1) 0.1.13+ca58154a7d
		fabric-rendering-v0: Fabric Rendering (v0) 1.1.2+ca58154a7d
		fabric-rendering-v1: Fabric Rendering (v1) 1.6.0+2868a2287d
		fabric-resource-loader-v0: Fabric Resource Loader (v0) 0.4.6+2868a2287d
		fabric-screen-api-v1: Fabric Screen API (v1) 1.0.0+c045166c7d
		fabric-screen-handler-api-v1: Fabric Screen Handler API (v1) 1.1.5+9354966b7d
		fabric-structure-api-v1: Fabric Structure API (v1) 1.1.4+ca58154a7d
		fabric-tag-extensions-v0: Fabric Tag Extensions (v0) 1.1.1+ca58154a7d
		fabric-textures-v0: Fabric Textures (v0) 1.0.6+ca58154a7d
		fabric-tool-attribute-api-v1: Fabric Tool Attribute API (v1) 1.2.7+8183d3957d
		fabrication: Fabrication 1.3.4
		fabricloader: Fabric Loader 0.11.3
		fabrilousupdater: FabrilousUpdater 1.0.3
		fading: Fading 1.2.3
		fallflyinglib: FallFlyingLib 1.1.0
		fallingleaves: Falling Leaves 1.6.0+1.16.5
		fluidphysics: Fluid Physics 1.4.0+fabric-1.16.4
		full_slabs: Full Slabs 2.0.1
		geckolib3: Geckolib 3.0.30
		hydrogen: Hydrogen 0.2-SNAPSHOT
		io_activej_activej-codegen: activej-codegen 4.1.1
		io_activej_activej-serializer: activej-serializer 4.1.1
		jankson: Jankson 3.0.1+j1.2.0
		java: OpenJDK 64-Bit Server VM 11
		kibe: Kibe 1.6.7-BETA
		lazydfu: LazyDFU 0.1.2
		lengthyladders: Lengthy Ladders 1.0.1
		libblockattributes_core: LibBlockAttributes (Core) 0.8.7
		libblockattributes_fluids: LibBlockAttributes (Fluids) 0.8.7
		libgui: LibGui 3.3.5+1.16.5
		lightstones: Lightstones 1.3.0
		lithium: Lithium 0.6.4-SNAPSHOT
		loading-timer: Loading Timer 1.4.2-Snapshot
		make-every-biome-spawnable-lol: Make Every Biome Spawnable 1.16.5-1.1.0
		malilib: MaLiLib 0.10.0-dev.21+arne.5
		map_atlases: Map Atlases 1.2.5
		micalibria: Micalibria 1.0.2
		midnight-hats: Midnight Hats 2.0.1
		minecraft: Minecraft 1.16.5
		modifiers: Modifiers 0.1.1
		modmenu: Mod Menu 1.16.9
		more_gems: More Gems 1.1.22
		mostructures: Mo' Structures 1.1.1+mc.1.16.5
		mythicmetals: Mythic Metals 0.9.9
		net_gudenau_lib_unsafe: unsafe 1.4.1
		net_openhft_zero-allocation-hashing: zero-allocation-hashing 0.11
		noplayerlabels: No Player Labels 2.0.1
		notenoughcrashes: Not Enough Crashes 3.2.0
		oldregen: Good Ol' Regen 1.0.1
		org_jetbrains_kotlin_kotlin-reflect: kotlin-reflect 1.4.31
		org_jetbrains_kotlin_kotlin-stdlib: kotlin-stdlib 1.4.31
		org_jetbrains_kotlin_kotlin-stdlib-jdk7: kotlin-stdlib-jdk7 1.4.31
		org_jetbrains_kotlin_kotlin-stdlib-jdk8: kotlin-stdlib-jdk8 1.4.31
		org_jetbrains_kotlinx_kotlinx-coroutines-core-jvm: kotlinx-coroutines-core-jvm 1.4.2
		org_jetbrains_kotlinx_kotlinx-coroutines-jdk8: kotlinx-coroutines-jdk8 1.4.2
		org_jetbrains_kotlinx_kotlinx-serialization-core-jvm: kotlinx-serialization-core-jvm 1.1.0
		org_jetbrains_kotlinx_kotlinx-serialization-json-jvm: kotlinx-serialization-json-jvm 1.1.0
		org_slf4j_slf4j-api: slf4j-api 1.7.29
		origins: Origins 0.7.0
		playerabilitylib: Pal 1.2.1
		pride: Pride Lib 1.0.0+1.16
		puddles: Puddles 1.0.0
		randompatches: RandomPatches 2.4.5-fabric
		reach-entity-attributes: Reach Entity Attribute 1.0.1
		repurposed_structures: Repurposed Structures 1.16.5-1.10.4-fabric
		retail: Retail 0.2.0
		rocks: This Rocks! 1.3.1
		roughlyenoughitems: Roughly Enough Items 5.11.218
		roughlyenoughitems-api: REI (API) 5.11.218
		roughlyenoughitems-default-plugin: REI (Default Plugin) 5.11.218
		roughlyenoughitems-runtime: REI (Runtime) 5.11.218
		seasons: Fabric Seasons 1.1.1-BETA
		sentimentality2: Sentimentality 2 1.1.0
		sextant: Immersive Travel Overhaul 0.3
		sodium: Sodium 0.1.1+build.330
		spark: spark 1.5.2
		starlight: Starlight fabric-1.0.0-RC2-82ae5ca
		terraform-shapes-api-v1: Terraform Shapes API (v1) 1.0.1
		terraform-wood-api-v1: Terraform Wood API (v1) 1.0.1
		throwabletorch: ThrowableTorch 1.16.5
		timecraft: Craft Takes Time 0.4.4
		tk_valoeghese_zoesteriaconfig: ZoesteriaConfig 1.3.2
		trinkets: Trinkets 2.6.7
		tweakeroo: Tweakeroo 0.10.0-dev.20210204.204245
		unearthed: Unearthed 1.1.1
		waystones: Waystones 1.1.1.1
		whereisit: Where Is It 1.11.7
		wi_zoom: WI Zoom 1.3-MC1.16.5
		yungsapi: YUNG's API 1.16.5-Fabric-2
	Player Count: 1 / 8; [class_3222['_K0RR_'/36861, l='ServerLevel[Nowy świat]', x=617.72, y=65.00, z=294.80]]
	Data Packs: vanilla, Fabric Mods
	Type: Integrated Server (map_client.txt)
	Is Modded: Definitely; Client brand changed to 'fabric'

[Feature request] Fix bug with vanilla smooth light

Expected Behavior

Actual Behavior

Reproduction Steps

Activate in the smooth light in graphics options
Choose one of the following blocks

(It can be any slab or stair, the piston must be extended)
Place light
Lock yourself in a 1x2x1 where the light arrives and leave the chosen block as a roof

[1.16.5 / Fabric] Certain areas not lighting up

Hi there, sorry for not being much help here but as you can see in the image, the area inside square and tunnel is not lighting up correctly, the surrounding areas seem to be alright though, please let me know if there is any more information I should provide which may help.

https://i.imgur.com/Q9VNlav.png

Thanks

Upload to curseforge

I'm not 100% sure if this is the right place to put this (if not i will take down the comment), but the reason i state this as an issue is because many server hosting sites only allow certain mods that have been uploaded to recognised sites. Hence it would be advantageous to upload this to curseforge with a disclaimer that it is still in early stages. Either way, you have done an excellent job here and are an asset to the community

Incorrect Skylight Nibble Initialisation

It looks like the current method of initialising skylight nibbles still isn't compatible with vanilla, which means I have to modify the current initialisation and management to match vanilla.

0.0.2-RC3 forge version crashes on startup with latest forge build

latest.log
I attached the startup log. Hopefully that is of some use.

Use newer Gradle version.

The version used when building is 6.5.1 from Jun 30, 2020. The current stable is 6.8.3 from Feb 22, 2021.

[1.17] Light is not updated

After migrating my minecraft 21w10a vanilla server to fabric with latest starlight from releases (happens when Compiled locally too) The light is getting corrupted , What i mean by that is all light sources only illuminate one block , this happens on a clean server too

Here are some screenshots:

Vanilla:

[NOTE:] Sometimes the light fixes itself is some entities are around it. [Screenshot 2] it fixed near the glow squids this time but it’s not always the case

Starlight :

[EDIT: Updated the screenshots to look like they are supposed to]

Unable to build from source

Whenever I try to build from source I get this error: https://paste.srnyx.xyz/uvodomujiz.yaml

Crash when creating a schematic with litematic

Expected Behavior

I hope minecraft doesn't introduce any bugs when putting the 2 mods together

Actual Behavior

When you load a schematic it crashes
crash-2020-12-08_20.01.52-client.txt

Reproduction Steps

Press the M, Area selection browser, New selection, Name it and accept
Make the selection with the tool (default is a stick)

3, Press the M, Area selection browser, Configure, Save schematic, Save schematic
4. Press the M, Load schematics, click on the schematic created

World not loading

Loading or making a new singleplayer world doesen't work

Failed to light chunk while generating on fabric in the nether

Server info
Fabric 1.16.4
Seed: -2680893630548586222
Generating the nether

Log file
https://paste.gg/p/anonymous/181792d011d74c61a7bc8bf39bd6999f

Mods list
BlueMap-1.3.0-snap-fabric-1.16.4.jar, Chunky-1.1.21.jar, fabric-api-0.29.0+1.16.jar, fabric-language-kotlin-1.4.21+build.1.jar, Lakeside-1.0.3+1.16.4.jar, lithium-fabric-mc1.16.4-0.6.0.jar, mostructures-1.0.1+mc.1.16.4.jar, simplexterrain-0.7.2.jar, starlight-fabric-0.0.2-RC3.jar, upstream-1.0.1.jar

Datapack list
incendium-v3-1-7, newvanilla-1-4-1-cegress

No lighting when using bobby

No lighting in "ghost" or fake chunks when using bobby on a server or single-player world

(render distance set to 1 in bobby settings to better see the problem)

[1.16.5 / Fabric] Failed to inject light data into save data for chunk

Ive got no clue if its a mod incompatibility but Without starlight, Ive got no issue.
Huge lag spikes when loading new chunks

Initially the world will load with this Error Message:

[16:17:55] [Server thread/WARN]: Failed to inject light data into save data for chunk [-4, -14], chunk light will be recalculated on its next load
java.lang.ArrayIndexOutOfBoundsException: Index 256 out of bounds for length 18
at net.minecraft.class_2852.saveLightHookReal(class_2852.java:1110) ~[intermediary-fabric-loader-0.11.3-1.16.5.jar:?]
at net.minecraft.class_2852.handler$bkc000$saveLightHook(class_2852.java:1069) ~[intermediary-fabric-loader-0.11.3-1.16.5.jar:?]
at net.minecraft.class_2852.method_12410(class_2852.java:360) ~[intermediary-fabric-loader-0.11.3-1.16.5.jar:?]
at net.minecraft.class_3898.method_17228(class_3898.java:716) ~[intermediary-fabric-loader-0.11.3-1.16.5.jar:?]
at net.minecraft.class_3898.method_20583(class_3898.java:388) ~[intermediary-fabric-loader-0.11.3-1.16.5.jar:?]
at java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:183) ~[?:?]
at java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:177) ~[?:?]
at java.util.Iterator.forEachRemaining(Iterator.java:133) ~[?:?]
at java.util.Spliterators$IteratorSpliterator.forEachRemaining(Spliterators.java:1801) ~[?:?]
at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:484) ~[?:?]
at java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:474) ~[?:?]
at java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:150) ~[?:?]
at java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:173) ~[?:?]
at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234) ~[?:?]
at java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:497) ~[?:?]
at net.minecraft.class_3898.method_17242(class_3898.java:385) ~[intermediary-fabric-loader-0.11.3-1.16.5.jar:?]
at net.minecraft.class_3215.method_17298(class_3215.java:321) ~[intermediary-fabric-loader-0.11.3-1.16.5.jar:?]
at net.minecraft.class_3218.method_14176(class_3218.java:710) ~[intermediary-fabric-loader-0.11.3-1.16.5.jar:?]
at net.minecraft.server.MinecraftServer.method_3723(MinecraftServer.java:567) ~[intermediary-fabric-loader-0.11.3-1.16.5.jar:?]
at net.minecraft.class_1132.method_3748(class_1132.java:83) ~[intermediary-fabric-loader-0.11.3-1.16.5.jar:?]
at net.minecraft.server.MinecraftServer.method_29741(MinecraftServer.java:670) ~[intermediary-fabric-loader-0.11.3-1.16.5.jar:?]
at net.minecraft.server.MinecraftServer.method_29739(MinecraftServer.java:257) ~[intermediary-fabric-loader-0.11.3-1.16.5.jar:?]
at java.lang.Thread.run(Thread.java:832) [?:?]

but after reloading it now spits this out:

[16:19:51] [Server thread/WARN]: Failed to inject light data into save data for chunk [-9, -2], chunk light will be recalculated on its next load
java.lang.ArrayIndexOutOfBoundsException: null

ModList: https://pastebin.com/tW8YiHAd

latest.log

[1.16.5-Forge]server stopped

Forge:36.0.22
https://paste.ubuntu.com/p/myqQPNTWkZ/
I don’t know if the problem belongs to Starlight
The server stopped but did not crash

Lazy load vanilla lighting

It needs to store whether a skylight data section is uninitialised or absent (Vanilla conflates the two) and Starlight does not propagate light into chunks not marked as lit. However, in modifying the data stored, it also marks the chunk as "unlit." and add its own special tag for whether the chunk is it. To Vanilla the data will look like the chunk needs lighting, and to Starlight it will look "lit."

Reading this gave me an idea - what if Starlight loaded the world's lighting to its special tags, but also used the vanilla lighting engine in the background for compatibility? Obviously ignoring the vanilla data while Starlight is active, though.
That could improve the UX a lot in the case Starlight is disabled for any reason (outdated mod, incompatibilities, snapshots, etc.)

Upstream updates in tuinity?

I know that it is still in beta, and might not even work out, but, eventually, when it is stable, having starlight work as an upstream for tuinity will make tuinity EXTREMELY fast.

I think that if starlight gets added to tuinity, it will become very popular and honestly I dont really want to swap to a fabric server but I will if I cant get starlight along with bukkit plugins (when it is stable of course)

Still having chunk lag issues

I have the latest of everything. Starlight, Lithium, Tic-Tacs. I still get a pause when going in-between chunk borders. I have starlight server-side and client-side. My server runs on an Intel Xeon, so I don't think hardware is the issue. My server also has 8gb of ram, which is plenty enough for twenty players total (only 1-4 on at a time).

I wish I could give you the video evidence, but it is larger than 10MB ):

server crash

the server crashed whenever the player red_poppy joined, since the only major modification I made to the all of fabric 3 modpack was switch phosphor for starlight i tried reverting that and they were able to join again, which makes me suspect starlight

---- Minecraft Crash Report ----
// You should try our sister game, Minceraft!

Time: 12/6/20 11:10 AM
Description: Exception ticking world

java.lang.NullPointerException: Exception ticking world
	at net.minecraft.class_3204.md2eb940$lambda$purge$0$0(class_3204.java:544)
	at net.minecraft.class_4706.removeIf(class_4706.java:535)
	at net.minecraft.class_3204.method_14045(class_3204.java:550)
	at net.minecraft.class_3215.method_12127(class_3215.java:334)
	at net.minecraft.class_3218.method_18765(class_3218.java:353)
	at net.minecraft.server.MinecraftServer.method_3813(MinecraftServer.java:871)
	at net.minecraft.class_3176.method_3813(class_3176.java:312)
	at net.minecraft.server.MinecraftServer.method_3748(MinecraftServer.java:811)
	at net.minecraft.server.MinecraftServer.method_29741(MinecraftServer.java:670)
	at net.minecraft.server.MinecraftServer.method_29739(MinecraftServer.java:257)
	at java.lang.Thread.run(Thread.java:748)


A detailed walkthrough of the error, its code path and all known details is as follows:
---------------------------------------------------------------------------------------

-- Head --
Thread: Server thread
Stacktrace:
	at net.minecraft.class_3204.md2eb940$lambda$purge$0$0(class_3204.java:544)
	at net.minecraft.class_4706.removeIf(class_4706.java:535)
	at net.minecraft.class_3204.method_14045(class_3204.java:550)
	at net.minecraft.class_3215.method_12127(class_3215.java:334)
	at net.minecraft.class_3218.method_18765(class_3218.java:353)

-- Affected level --
Details:
	All players: 1 total; [class_3222['Red_Poppy'/97889, l='ServerLevel[world]', x=4565.70, y=73.97, z=6502.05]]
	Chunk stats: ServerChunkCache: 1654
	Level dimension: minecraft:the_end
	Derived: true
	Level spawn location: World: (-183,63,110), Chunk: (at 9,3,14 in -12,6; contains blocks -192,0,96 to -177,255,111), Region: (-1,0; contains chunks -32,0 to -1,31, blocks -512,0,0 to -1,255,511)
	Level time: 4396463 game time, 6083663 day time
	Level name: world
	Level game mode: Game mode: survival (ID 0). Hardcore: false. Cheats: false
	Level weather: Rain time: 165042 (now: false), thunder time: 120499 (now: false)
	Known server brands: fabric
	Level was modded: true
	Level storage version: 0x04ABD - Anvil
Stacktrace:
	at net.minecraft.server.MinecraftServer.method_3813(MinecraftServer.java:871)
	at net.minecraft.class_3176.method_3813(class_3176.java:312)
	at net.minecraft.server.MinecraftServer.method_3748(MinecraftServer.java:811)
	at net.minecraft.server.MinecraftServer.method_29741(MinecraftServer.java:670)
	at net.minecraft.server.MinecraftServer.method_29739(MinecraftServer.java:257)
	at java.lang.Thread.run(Thread.java:748)

-- System Details --
Details:
	Minecraft Version: 1.16.4
	Minecraft Version ID: 1.16.4
	Operating System: Linux (amd64) version 5.4.0-40-generic
	Java Version: 1.8.0_275, Private Build
	Java VM Version: OpenJDK 64-Bit Server VM (mixed mode), Private Build
	Memory: 1762900776 bytes (1681 MB) / 4236247040 bytes (4040 MB) up to 4294967296 bytes (4096 MB)
	CPUs: 16
	JVM Flags: 20 total; -XX:+UseG1GC -XX:+ParallelRefProcEnabled -XX:MaxGCPauseMillis=100 -XX:+UnlockExperimentalVMOptions -XX:+DisableExplicitGC -XX:+AlwaysPreTouch -XX:G1NewSizePercent=30 -XX:G1MaxNewSizePercent=40 -XX:G1HeapRegionSize=8M -XX:G1ReservePercent=20 -XX:G1HeapWastePercent=5 -XX:G1MixedGCCountTarget=4 -XX:InitiatingHeapOccupancyPercent=15 -XX:G1MixedGCLiveThresholdPercent=90 -XX:G1RSetUpdatingPauseTimePercent=5 -XX:SurvivorRatio=32 -XX:+PerfDisableSharedMem -XX:MaxTenuringThreshold=1 -Xmx4G -Xms2G
	Fabric Mods: 
		adorn: Adorn 1.12.2+1.16.4
		advanced_runtime_resource_pack: Runtime Resource Pack 0.2.9
		advdebug: Advancements Debug 2.2.0
		angerable-patch: Angerable Patch 1.1.0-1.16.4
		appleskin: AppleSkin 1.0.11
		appliedenergistics2: Applied Energistics 2 8.1.0-alpha.13
		architectury: Architectury 1.1.55
		arstheurgia: Ars Theurgia 1.0.5
		artifacts: Artifacts 2.0.2+1.16.4-fabric
		artifice: Artifice 0.13.2+1.16.3
		artofalchemy: Art of Alchemy: Memoriam 1.0.0-rc4+1.16.4
		astromine: Astromine 1.11.4+fabric-1.16.3
		astromine-core: Astromine: Core 1.11.4+fabric-1.16.3
		astromine-discoveries: Astromine: Discoveries 1.11.4+fabric-1.16.3
		astromine-foundations: Astromine: Foundations 1.11.4+fabric-1.16.3
		astromine-technologies: Astromine: Technologies 1.11.4+fabric-1.16.3
		astromine-transportations: Astromine: Transportations 1.11.4+fabric-1.16.3
		autoconfig1u: Auto Config v1 Updated 3.3.1
		bambootweaks: Bamboo Tweaks unspecified
		battletowers: Battle Towers 3.2.1-beta-1.16.4
		bedspreads: Bedspreads 1.3.1-1.16.4
		bettercaves: YUNG's Better Caves 1.16.2-1.0.3
		betterend: Better End 0.7.1-beta
		bettermineshafts: YUNG's Better Mineshafts 1.16.4-1.0
		blade: Blade 2.0.0
		blast: BLAST 1.4
		blockshifter: Blockshifter 1.3.2+fabric-1.16.4
		blockus: Blockus 1.6.8+1.16.4
		blue_endless_jankson: jankson +
		byg: BYG 1.1.3
		campanion: Campanion 1.2.0+build.39
		cardinal-components: Cardinal Components API 2.7.9
		cardinal-components-base: Cardinal Components API (base) 2.7.9
		cardinal-components-block: Cardinal Components API (blocks) 2.7.9
		cardinal-components-chunk: Cardinal Components API (chunks) 2.7.9
		cardinal-components-entity: Cardinal Components API (entities) 2.7.9
		cardinal-components-item: Cardinal Components API (items) 2.7.9
		cardinal-components-level: Cardinal Components API (world saves) 2.7.9
		cardinal-components-scoreboard: Cardinal Components API (scoreboard) 2.7.9
		cardinal-components-util: Cardinal Components API (utilities) 2.7.9
		cardinal-components-world: Cardinal Components API (worlds) 2.7.9
		carrier: Carrier 1.6.1
		cavebiomes: Cave Biomes 0.5.1
		chainmail: Chainmail 0.5.0
		charm: Charm 2.1.4
		charmonium: Charmonium 2.1.4
		chunkpregen: Fabric Chunk Pregenerator 0.3.3
		cinderscapes: Cinderscapes 1.2.4+build.43-1.16.4
		cleancut: CleanCut mc1.16-2.1-fabric
		cloth-api: Cloth API 1.4.9
		cloth-armor-api-v1: Cloth Armor API v1 1.4.9
		cloth-basic-math: Cloth Basic Math 0.5.1
		cloth-client-events-v0: Cloth Client Events v0 1.4.9
		cloth-common-events-v1: Cloth Common Events v1 1.4.9
		cloth-config2: Cloth Config v4 4.8.3
		cloth-datagen-api-v1: Cloth Datagen v1 1.4.9
		cloth-durability-bar-api-v1: Cloth Durability Bar API v1 1.4.9
		cloth-dynamic-registry-api-v1: Cloth Dynamic Registry API v1 1.4.9
		cloth-utils-v1: Cloth Utils v1 1.4.9
		com_electronwill_night-config_core: core 3.6.2
		com_electronwill_night-config_toml: toml 3.6.2
		com_github_nathanpb_safer: Safer 1.1.0
		com_github_therandomlabs_trlutils-config: TRLUtils-Config master-SNAPSHOT
		com_github_therandomlabs_trlutils-fabric: TRLUtils-Fabric 1.16-SNAPSHOT
		com_moandjiezana_toml_toml4j: toml4j 0.7.2
		compressedblocks: Compressed Blocks 1.0
		computercraft: CC:T for Fabric 1.91.2
		controlling: Controlling For Fabric 1.1.2
		couplings: Couplings 1.3.1
		crookedcrooks: Crooked Crooks 1.3.2+1.16.4
		croptopia: Croptopia 1.0.5-1.16.3-FABRIC
		crusade: Crusade 1.1.4+1.16.2
		dankstorage: Dank Storage 1.9a-1.16.3
		darkpaintings: Dark Paintings 1.0.0
		dawn: Dawn API 1.5.4
		decimal_coins: Decimal Coins 1.16.2-1.2.0
		diggusmaximus: Diggus Maximus 1.4.2-1.16.3
		dml-refabricated: Deep Mob Learning: Refabricated 0.3.1-beta5
		dwarfcoal: Dwarf Coal 1.16.2-1.0.0
		eggtab: Egg Tab 1.3.2+1.16-fabric
		expandedstorage: ExpandedStorage 5.6.31
		ezpas: Ezpas 1.2.3-1.16.2
		fabric: Fabric API 0.27.1+1.16
		fabric-api-base: Fabric API Base 0.2.0+ab87788d3a
		fabric-biome-api-v1: Fabric Biome API (v1) 3.1.0+2e23b97c3a
		fabric-command-api-v1: Fabric Command API (v1) 1.0.9+6a2618f53a
		fabric-commands-v0: Fabric Commands (v0) 0.2.0+6a2618f53a
		fabric-containers-v0: Fabric Containers (v0) 0.1.8+045df74f95
		fabric-content-registries-v0: Fabric Content Registries (v0) 0.2.0+e77439c73a
		fabric-crash-report-info-v1: Fabric Crash Report Info (v1) 0.1.2+b7f9825d3a
		fabric-dimensions-v1: fabric-dimensions-v1 2.0.1+9a6c75813a
		fabric-events-interaction-v0: Fabric Events Interaction (v0) 0.4.1+6a2618f53a
		fabric-events-lifecycle-v0: Fabric Events Lifecycle (v0) 0.2.0+16acbe5b95
		fabric-furnaces: Fabric Furnaces 1.3.2-1.16.2
		fabric-game-rule-api-v1: Fabric Game Rule API (v1) 1.0.3+a4467d2a3a
		fabric-item-api-v1: Fabric Item API (v1) 1.2.0+6a2618f53a
		fabric-item-groups-v0: Fabric Item Groups (v0) 0.2.1+6a2618f53a
		fabric-language-kotlin: Fabric Language Kotlin 1.4.0+build.1
		fabric-language-scala: Fabric Language Scala 0.3.2.12
		fabric-lifecycle-events-v1: Fabric Lifecycle Events (v1) 1.2.0+6a2618f53a
		fabric-loot-tables-v1: Fabric Loot Tables (v1) 1.0.1+6a2618f53a
		fabric-mining-levels-v0: Fabric Mining Levels (v0) 0.1.2+b764ce9995
		fabric-networking-blockentity-v0: Fabric Networking Block Entity (v0) 0.2.5+b50ffc7b95
		fabric-networking-v0: Fabric Networking (v0) 0.1.10+e00ecb5f4e
		fabric-object-builder-api-v1: Fabric Object Builder API (v1) 1.9.2+6a2618f53a
		fabric-object-builders-v0: Fabric Object Builders (v0) 0.7.1+6a2618f53a
		fabric-particles-v1: fabric-particles-v1 0.2.2+fb0d9b0e95
		fabric-registry-sync-v0: Fabric Registry Sync (v0) 0.7.1+285766753a
		fabric-rendering-data-attachment-v1: Fabric Rendering Data Attachment (v1) 0.1.4+6a2618f53a
		fabric-resource-loader-v0: Fabric Resource Loader (v0) 0.3.2+1944f3e03a
		fabric-screen-handler-api-v1: Fabric Screen Handler API (v1) 1.1.0+6a2618f53a
		fabric-structure-api-v1: Fabric Structure API (v1) 1.1.1+f1d8af063a
		fabric-tag-extensions-v0: Fabric Tag Extensions (v0) 1.1.0+e77439c73a
		fabric-tool-attribute-api-v1: Fabric Tool Attribute API (v1) 1.2.5+6a2618f53a
		fabricloader: Fabric Loader 0.10.8
		fabrikommander: FabriKommander 1.0.0-MC1.16.3
		fallflyinglib: FallFlyingLib 1.1.0
		fatxporbs: Fat Experience Orbs 0.0.9
		fermion: Fermion 2.1.191
		fermion-modkeys: Fermion Modifier Keys 1.8.180-snapshot
		fiber: fiber 0.23.0-2
		flamingo_ooo: Flamingo, oh, oh, oh... 1.0.4-MC1.16.3-fabric
		flan: Flan 1.16.2-1.2.0
		flonters: Flonters 1.1.1+1.16.2
		flora-doubling: Flora Doubling 1.3.0+1.16.4-fabric
		gameinfo: GameInfo 2.0.0a-experimental-06.1 1.16.2
		gateofbabylon: Gate Of Babylon 1.1.2-1.16.2
		geckolib: Geckolib 2.0.0
		givemehats: Give Me Hats! 1.3
		glassdoor: Glass Doors 1.5.0-1.16
		glassential: Glassential 1.16.1-1.1.4
		goml: Get Off My Lawn 1.2.2-beta
		hard-hat-steve: Hard Hat Steve 1.2.0
		harvest: Harvest 1.2.12
		harvest_scythes: Harvest Scythes 1.0.4
		hctm-base: HCTM Base 3.4.0
		horseinfo: Horse Info 0.2.2-1.16.1
		ignis-fatuus: Ignis Fatuus 1.1.0
		improved-stations: Improved Stations 2.0.3
		indrev: Industrial Revolution 1.7.15-BETA
		inmis: Inmis 2.0.0-beta-1.16.2
		inventorysorter: Inventory Sorter 1.7.4-1.16
		iron-jetpacks: Iron Jetpacks 0.2.5
		jankson: Jankson 3.0.1+j1.2.0
		javax_vecmath_vecmath: vecmath 1.5.2
		jumploader: Jumploader 2.1.0
		kibe: Kibe 1.5.2-BETA
		ktdatataglib: KtDataTagLib 1.4.0
		kubejs: KubeJS 1.5.5
		kyrptconfig: Kytpt Config 1.1.6-1.16
		lapisreserve: Lapis Reserve 1.0.6
		libblockattributes: LibBlockAttributes 0.8.4
		libblockattributes_core: LibBlockAttributes (Core) 0.8.4
		libblockattributes_fluids: LibBlockAttributes (Fluids) 0.8.4
		libblockattributes_items: LibBlockAttributes (Items) 0.8.4
		libcd: LibCapableData 3.0.3+1.16.3
		libgui: LibGui 3.2.2+1.16.3
		library_of_exile: Library of Exile 1.0.6
		libstructure: LibStructure 1.5
		lithium: Lithium 0.6.0
		lithium-api: Lithium API 0.6.0
		magna: Magna 1.4.3-1.16.2
		mcdict: MCDict 2.0.0+1.16.4
		megane: megane 3.0.7+1.16.4
		megane-api: megane-api 3.0.7+1.16.4
		megane-impl: megane-impl 3.0.7+1.16.4
		megane-runtime: megane-runtime 3.0.7+1.16.4
		minecraft: Minecraft 1.16.4
		mm: Manningham Mills 2.1
		mo_glass: Mo Glass 1.5-MC1.16.4
		modern_industrialization: Modern Industrialization 0.3.9
		mostructures: Mo' Structures 1.0.1+mc.1.16.4
		netherite_plus: Netherite Plus Mod 1.1.0
		nourish: Nourish 1.1.1
		org_codehaus_groovy_groovy: groovy 3.0.3
		org_codehaus_groovy_groovy-jsr223: groovy-jsr223 3.0.3
		org_jetbrains_annotations: annotations 20.0.0
		org_jetbrains_kotlin_kotlin-reflect: kotlin-reflect 1.4.0
		org_jetbrains_kotlin_kotlin-stdlib: kotlin-stdlib 1.4.0
		org_jetbrains_kotlin_kotlin-stdlib-jdk7: kotlin-stdlib-jdk7 1.4.0
		org_jetbrains_kotlin_kotlin-stdlib-jdk8: kotlin-stdlib-jdk8 1.4.0
		org_jetbrains_kotlinx_kotlinx-coroutines-jdk8: kotlinx-coroutines-jdk8 1.3.9
		org_joml_joml: joml 1.9.25
		org_yaml_snakeyaml: snakeyaml 1.25
		packages: Packages 1.1.1
		patchouli: Patchouli 1.16.4-48-FABRIC
		phonos: Phonos 0.1.0-beta
		piglib: Piglib 1.0.1
		playerabilitylib: Pal 1.2.1
		polymorph: Polymorph 0.0.5-1.16.3
		qcommon-cfg-core: qcommon-cfg-core 3.2.0
		qcommon-croco: Croco 2.1.1
		quickshulker: Quick Shulker 1.1.11-1.16
		reach-entity-attributes: Reach Entity Attribute 1.0.1
		reborncore: Reborn Core 4.6.1+build.97
		repurposed_structures: Repurposed Structures 1.16.4-1.7.3
		respawnablepets: Respawnable Pets 1.16.4-1
		roughlyenoughitems: Roughly Enough Items 5.8.7
		roughlyenoughitems-api: REI (API) 5.8.7
		roughlyenoughitems-default-plugin: REI (Default Plugin) 5.8.7
		roughlyenoughitems-runtime: REI (Runtime) 5.8.7
		rswires: RSWires 4.9.1
		rtree-3i-lite-fabric: rtree-3i-lite for Fabric 0.3.0
		secretrooms: Secret Rooms 0.9.2+1.16.2
		shapes: Shapes 2.0.0+build.10
		shulkerboxtooltip: Shulker Box Tooltip 2.3.3+1.16.4
		simpleteleporters: Simple Teleporters 2.2.1
		simplexterrain: Simplex Terrain 0.7.1
		smootherbedrock: Smoother Bedrock 1.0.0
		spark: spark 1.4.3
		staffofbuilding: Staff of Building 1.2.3-1.16.2
		starlight: Starlight 0.0.1-SNAPSHOT
		static-content: Static Content 1.0.1-1.16.2
		staticdata: Static Data 1.1.2
		step-height-entity-attribute: Step Height Entity Attribute 1.0.0
		stonecutter-tweaks: Stonecutter Tweaks 1.1.0-1.16
		strawdummy: Straw Dummy 1.4.0
		structure-helpers: Structure Helpers 3.0.0
		survivalisland: Survival Island 0.1.5
		tacocraft: TacoCraft 1.3.1+mc.1.16
		team_reborn_energy: Energy 0.1.1
		techreborn: Tech Reborn 3.7.1+build.162
		terraform-biome-builder-api-v1: Terraform Biome Builder API (v1) 1.0.0+build.1
		terraform-config-api-v1: Terraform Config API (v1) 1.0.0+build.1
		terraform-dirt-api-v1: Terraform Dirt API (v1) 1.0.0+build.1
		terraform-overworld-biome-extensions-api-v1: Terraform Overworld Biome Extensions API (v1) 1.0.0+build.1
		terraform-shapes-api-v1: Terraform Shapes API (v1) 1.0.0+build.3
		terraform-surfaces-api-v1: Terraform Surfaces API (v1) 1.0.0+build.1
		terraform-tree-api-v1: Terraform Tree API (v1) 1.0.1+build.3
		terraform-wood-api-v1: Terraform Wood API (v1) 1.0.0+build.1
		terrestria: Terrestria 2.1.5+build.28
		tis3d: TIS-3D 1.6.0
		tis3d-additions: TIS-3D Additions 0.2.1+1.16.2
		tk_valoeghese_zoesteriaconfig: ZoesteriaConfig 1.3.2
		totemmod: Wither Totems Mod 0.3.2
		trapexpansion: Trap Expansion 1.3.2
		traverse: Traverse 3.0.3+build.13
		trinkets: Trinkets 2.6.7
		truerooms: True Secret Rooms 1.0.3
		vanilla-hammers: Vanilla Hammers 3.0.1-1.16.3
		vanilladeathchest: VanillaDeathChest 1.16.3-1.11.0.7-fabric
		vanillaexcavators: Vanilla Excavators 1.1.0
		villagerhats: Villager Hats fabric-1.16.4-1.0.1
		voyager: Voyager 1.0.0
		waila: Hwyla 1.9.22
		waystones: Waystones 1.0.10
		wild_explorer: Wild Explorer 1.2.1
		winged: Winged Mod 1.16.2-1.4.1
		wolveswitharmor: Wolves With Armor 1.5.2-1.16.2
		woodenhoppers: Wooden Hoppers 1.0.0
		woods_and_mires: Woods and Mires 1.0.3+1.16.3
		wrenchable: Wrenchable 1.0.0+1.16.1
		xaerominimap: Xaero's Minimap 20.28.1
		xaeroworldmap: Xaero's World Map 1.11.3
		yosbr: YOSBR 0.1.1
		yungsapi: YUNG's API 1.16.4-Fabric-1
	Player Count: 4 / 20; [class_3222['Whiist'/25275, l='ServerLevel[world]', x=47.57, y=77.00, z=2545.37], class_3222['_Gryz_'/68616, l='ServerLevel[world]', x=171.12, y=176.12, z=-6069.06], class_3222['Eveybean'/84690, l='ServerLevel[world]', x=-754.14, y=62.67, z=-921.09], class_3222['Red_Poppy'/97889, l='ServerLevel[world]', x=4565.70, y=73.97, z=6502.05]]
	Data Packs: vanilla (incompatible), fabric/adorn, fabric/appliedenergistics2, fabric/arstheurgia, fabric/artifacts, fabric/artofalchemy, fabric/astromine-core, fabric/astromine-discoveries, fabric/astromine-foundations, fabric/astromine-technologies, fabric/astromine-transportations, fabric/bambootweaks, fabric/battletowers, fabric/bedspreads, fabric/betterend, fabric/blast, fabric/blockshifter, fabric/blockus, fabric/byg, fabric/campanion, fabric/carrier, fabric/cavebiomes, fabric/charm (incompatible), fabric/cinderscapes, fabric/compressedblocks, fabric/computercraft (incompatible), fabric/crookedcrooks, fabric/croptopia, fabric/crusade, fabric/dankstorage, fabric/decimal_coins (incompatible), fabric/dml-refabricated, fabric/dwarfcoal, fabric/expandedstorage, fabric/ezpas, fabric/fabric-furnaces, fabric/fabric-tool-attribute-api-v1, fabric/flamingo_ooo, fabric/flonters, fabric/flora-doubling, fabric/gateofbabylon, fabric/glassdoor, fabric/glassential, fabric/goml, fabric/hard-hat-steve (incompatible), fabric/harvest, fabric/hctm-base, fabric/ignis-fatuus, fabric/improved-stations, fabric/indrev, fabric/inmis, fabric/iron-jetpacks (incompatible), fabric/kibe, fabric/kubejs (incompatible), fabric/libcd, fabric/mo_glass, fabric/modern_industrialization, fabric/mostructures, fabric/netherite_plus, fabric/nourish, fabric/packages, fabric/phonos, fabric/piglib, fabric/repurposed_structures, fabric/respawnablepets, fabric/rswires, fabric/secretrooms, fabric/simpleteleporters, fabric/staffofbuilding, fabric/strawdummy, fabric/structure-helpers, fabric/tacocraft, fabric/techreborn, fabric/terrestria, fabric/tis3d (incompatible), fabric/tis3d-additions, fabric/totemmod, fabric/trapexpansion, fabric/traverse, fabric/trinkets, fabric/truerooms, fabric/vanilla-hammers, fabric/vanillaexcavators, fabric/villagerhats, fabric/waystones, fabric/wild_explorer, fabric/winged, fabric/wolveswitharmor, fabric/woodenhoppers, fabric/woods_and_mires, phonos:data_pack, secretrooms:server_pack
	Is Modded: Definitely; Server brand changed to 'fabric'
	Type: Dedicated Server (map_server.txt)

Incompatibility with Bobby

This is only really noticeable if bobby is installed, however it does happen
Nothing major, just minorly annoying

does not respect SemVer warning

Mod `starlight` (fabric-1.0.0-RC1-59d1f21) does not respect SemVer - comparison support is limited.

Though having commit hash, fabric/forge and such in the version string is good, it causes the above warning. Not sure if RC1 should be removed too to fix it, but it should support it. I'll assume it will be fixed once the 1.0 release is finalized?

Tuinity link in README is a 404

See title.

Starlight Forge 1.0.0-RC + Create 0.3.1 conflict

https://pastebin.com/Bvn5jx39

https://pastebin.com/cKbK8UHp

https://pastebin.com/eTbphx1i

Different crashes each time, I'm not sure which mod is at fault out of the two so posting on both.

It seemed to happen regardless of if I had creates "experimentalRendering" option set to on or off.

[1.16.5-Forge]Server crash

https://paste.ubuntu.com/p/hRtMjHXC56/
Nothing strange happened before the crash, when I restarted, the game runs normally.

Network Compatible?

You're re-writing the lighting engine, is it going to stay network compatible? If you change the lighting model, it'll require a client.

Random crashes

If I load my game with starlight-fabric after a few seconds after joining a server it says "Saving World" and the game crashes. I loaded a few other mods, so I dont know if its maybe just an incompatibility with another mod. I hope this helps, here is the crash report. https://paste.ee/p/Bu0Dr

How to use Starlight

Hello，my friend, i just want to kown how to use it ,is it conflict with lithium or sodium

Still not compatible with Tic-Tacs, Unfortunately

I upgraded to the latest starlight, 0.0.2 RC2, and now Tic-Tacs and Starlight are not compatible anymore. I am using Tic-Tacs 0.1.3, which made your mod compatible with it. Now with the latest release of starlight, something got changed and is now not functioning with Tic-Tacs.

Black Blocks appearing when breaking blocks

Im using starlight-forge-1.0.0-RC1-1.16.5.jar

When breaking blocks this black blocks would appear for half a sec, it's really weird and kinda annoying.

[Request] Update the comparison graph in README.md

I've heard (and felt) that Phosphor 0.7.0 dev branch is much better than 0.6.0 and almost as good as Starlight, so maybe it may be a good idea to show Phosphor 0.7.0 in the graph either by editing the phosphor section or adding a new section for 0.7.0 and renaming the old one to specify 0.6.0?

[Forge] Incompatibility with Miner's Helmet

Hello!
The Miner's Helmet from the same name mod doesn't light around us when weared with this mod installed:

Does the Chunk Border Lag bug exist if the client doesn't Starlight

I had chunk lag because I didn't have the mod on client, just on server. That seemed to be fixed when I installed it on my client. I don't know if this is a bug or not.

Weird rendering

So i made a massive 26,650 x 26,650 screenshot of a world at 64 chunk render distance but it has a million weird rendering bugs. Blocks appear above other blocks when they should, leaves become hollow, there are black seams everywhere and i'd like to know what you think is causing these issues or where i could start
These are my mods:

This is the image:
http://www.gigapan.com/gigapans/224366
(They are a lot more pronounced on the edges of the map)

This was captured with normal fov at y 1300. I tried the same thing with 30 fov but at y 3000 in order to see the same things and the problems got way worse
Does this have to do with starlight or is it something else or is it just vanilla?
If it is so, do you think any of the mods i have do something to fix it or is it just impossible?

Server hang with starlight and chisels and bits installed

https://paste.ubuntu.com/p/sBQBWX4JdN/

Port fixes from tuinity

Tuinity/Tuinity@9a48d49#diff-c983baa78af7e55be85daf219da850499446aad166c8ea3c846743b673e78fe6

Client-server light value desync with moving blocks

When moving blocks away from a light source and back the client light value (as from the Debug Menu) and server light value (as from the debug menu) desync, occasionally in some configurations. To be specific, the client light level maintains how it was when the blocks were removed when they've returned. It may be of note that I'm returning the blocks in the same gt.

holes in world

Sometimes, there are areas where the terrain never loads no matter how long you wait and they never go away even if you get out of your world and come back in

I even tried relaunching minecraft but it still doesn't work
I'm in 1.16.4 with version starlight-fabric-0.0.2-RC3
i also have lithium, sodium and tic tac installed but starlight is most likely the cause

Special block rendering can't be illuminated

Hello!

A mod called Supplementaries adds a new block called the Notice Board. It's like an item frame, but as a block, that can display maps and books.
The problem is that with Starlight installed, the light around it doesn't seem to affect the rendering of the map:

Without Starlight (rendered normally):

With Starlight (even with a lot of light sources, the map is always dark):

papermc / starlight Goto Github PK

starlight's Issues

Expected Behavior

Actual Behavior

Reproduction Steps

Mod Version

Additional screenshots

Expected Behavior

Actual Behavior

Reproduction Steps

Expected Behavior

Actual Behavior

Reproduction Steps

Recommend Projects

Recommend Topics

Recommend Org