parabot / internal-api Goto Github PK

I think it fails because the wrong dist is defined, and we need to change the jdk (also for deployments)

From here

• Provide a general summary of the issue in the Title above.
• Before you open an issue, please check if a similar issue already exists or has been closed before.

Important

Mark with [x] to select. Leave as [ ] to unselect.

When reporting a bug/issue:

• Screenshot
• The Parabot version and the operating system you're using
• The behavior you expect to see, and the actual behavior
• Steps to reproduce the behavior
• (optional) Possible solution/fix/workaround

When you open an issue for a change/improvement/feature request:

• A description of the problem you're trying to solve, including why you think this is a problem
• If the feature changes current behavior, reasons why your solution is better
• (optional) Possible solution/fix/workaround

Description

Now we only have WebUtil#getContents(URLConnection, String), though we should also have a WebUtil#getConnection(URL, String)

Something in the lines of

            urlConnection.setDoOutput(true);
            OutputStreamWriter wr = new OutputStreamWriter(urlConnection.getOutputStream());
            wr.write(parameters);
            wr.flush();
            wr.close();

We currently have this: https://github.com/Parabot/Internal-API/blob/master/src/main/java/org/parabot/api/ui/SwingUtil.java#L29

This should be changed to: https://github.com/Parabot/Parabot/blob/feature/release-3.0.0-RC-01-ui/src/main/java/org/parabot/core/ui/newui/BotUI.java#L39

Make sure to create a new class for this, as this isn't Swing anymore, but JavaFX

If master, perform:

mvn package
mvn javadoc:javadoc
mvn deploy
mvn site:deploy