paradadf / recaltools Goto Github PK

wget isn't natively installed on macOS. Use curl instead.

EnableDelayedExpansion is causing this issue, but it is needed to set variables inside a for-loop.
Need to check SETLOCAL to correct this.

Just a small recommondation. Would be nice to have Releases to see the changes. Thank you. Works great so far under macOS V.10.12.2

Hi
Is there a way to scrape mame with full naming rather then the short file name?

I m using this on windows

Thanks.

There is an issue with line 251

if [ ! "$arcade" = "" ]; then consoleImg=""; fi

When scraping all system, what this does is "purge" the consoleImg settings when an arcade system is scanned.
The settings are not restored.
I believe you should change this to an if else condition, and keep the consoleImg parameter.

2022/05/09 15:14:09 ERR: error processing trs80coco\Model 4 - Games\zork2.dsk: ss: cannot parse response: "invalid character 'F' looking for beginning of value"

I assume this comes from the scraper.exe and since I have no idea where it's getting that invalid character from (I assume a scraping server; I have mine set to ss,gdb).

It also fails to see thegamesdb.net being online, saying to use a switch to suppress this error.

I did put my ss credentials in the batch file, but it still isn't getting the 10 threads it should allow (the coded 4 is plenty).

While lauching the bat file i got stuck , after deleting the following code , it worked well, have to say i downloaded scraper.exe myself

`:scraperEXE
rem Detect OS architecture
reg Query "HKLM\Hardware\Description\System\CentralProcessor\0" | find /I "x86" >nul && set arch=386 || set arch=amd64

rem Query the API to get the latest tag
set "Uri=https://api.github.com/repos/sselph/scraper/releases/latest"
for /F "delims=" %%a in ('PowerShell Invoke-RestMethod -Method Get -Uri %Uri% ^| find /I "tag_name"') do (
for /F "tokens=3" %%b in ("%%a") do set scraperVersion=%%b
)

rem Download or update scraper if needed
if exist "scraper.exe" (
for /F "tokens=* usebackq" %%a in (scraper.exe -version) do (
if "%%a"=="%scraperVersion%" goto systemSelection
if "%scraperVersion%"=="" echo %dict[4]% & echo. & goto systemSelection
echo %dict[5]% %%a %dict[6]% %scraperVersion%%dict[7]% & echo.
)
) else echo %dict[8]% %scraperVersion%%dict[7]% & echo.

rem Build the file name, download url and download the file to the current location
set scraperZip=scraper_windows_%arch%.zip
set scraperURL=https://github.com/sselph/scraper/releases/download/%scraperVersion%/%scraperZip%
PowerShell (New-Object System.Net.WebClient).DownloadFile('%scraperURL%', '%~dp0%scraperZip%')

rem Unzip the scraper and remove unnecessary files
if exist "%scraperZip%" (
PowerShell Expand-Archive -Path '%scraperZip%' -DestinationPath '.' -Force
del LICENSE.txt %scraperZip%
) else echo %dict[2]% & pause >nul & exit`

Windows 10, up to date, 64bit, confirmed PowerShell is intalled.

Long story short, it doesn't download scraper.exe. I tried to echo scraperVersion, the variable is empty.

I added a SET command on scraperVersion at line 160 and manually inputted the correct version. I echo'd the scraperURL after line 172 and verified it through my browser. The download fails with the following error...

Exception calling "DownloadFile" with "2" argument(s): "The request was aborted: Could not create SSL/TLS secure
channel."
At line:1 char:1
+ (New-Object System.Net.WebClient).DownloadFile('https://github.com/ss ...
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (:) [], MethodInvocationException
    + FullyQualifiedErrorId : WebException

ERROR: Unable to download the scraper. Exiting...

The default in FastScraper needs the . removed from the extension as it is resulting in images to be named with ..jpg

Thanks!

Hello,
i tried to use your "Automatic Gamelists Filter.xlsx" but for some reasons, i'm not able to obtain a result at all

• if i open the xlsx with latest version of libreoffice calc then, when i paste from the mame2003 compatibility list, it just stucks forever in pasting..
• if i "import your file on google documents then i paste there, i get errors on formulas and lose parts of it (no way i can filter results in any way)

Can you suggest what program we have to use (hope not only MS excel) or particular things to do to obtain a succesful paste?

I use windows10 currently, thank you! =)

Add "Complete DAT (without NeoGeo)" to sort not-NeoGeo parents and clones.

Is it possible to add to the excel file a new tab for comparing the fba and mame list, to remove all the dupe between fba and mame,
if a game is present in fba list and mame list, only keep the one in fba list,
If a game is only present in fba, keep it
If a game is present in mame list, keep it,

By doing this, we'll have a mame reduced list to the minimum I think (whatever the choose of the filter)

I'm waiting for v1.2 to be released (compiled version to be uploaded) in order to upgrade the script with the latest changes!
https://github.com/sselph/scraper/releases

Currently, v.1.1.10 is practically useless with fastscraper.

When one version of scraper is already installed and I run the script I get this error:

fastscraper ver. 31.01.2018
./fastscraper: line 180: [: v1.4.5: integer expression expected
Updating sselph scraper from v1.4.5 to v1.4.5, please wait...

And then it re-downloads the scraper package. This makes running the script slow because this always takes a couple of seconds even if the current version matches.

I've verified this behavior on macOS and Ubuntu Linux both in zsh and bash.

You're doing an integer comparison between two strings:
https://github.com/paradadf/recaltools/blob/master/fastscraper/fastscraper#L180

The input/output is a string because it has the "v" character and more than one period in it.

I have added #13 to resolve this.

Hello @paradadf
I tried your batch fastsorter.bat and It's not work on windows 10.

I modified path for folder and it's ok now.

this path ".\%system%\ doesn't work on windows"

I modified path for folder and it's ok now on my computer

:createFolder
rem Create the selected folder
md "D:\%system%\%destFolder%"

rem Look inside the gamelist and copy the roms to the destination folder
if not exist "%gamelist%.txt" echo The file %gamelist%.txt is missing! & echo. & pause & goto:eof
title fastsorter ver. %releaseDate% - Sorting roms in progress...
for /f "delims=" %%a in ('type "%gamelist%.txt"') do (
	if exist "D:\%system%\%%a" (
		copy "D:\%system%\%%a" "D:\%system%\%destFolder%\%%~nxa" >nul | echo %%a
	) else (
		echo.
		echo %%a missing & echo.
		)
)

Had an issue w/the system select having odd paths, and looping back to the system selection.
Rewrote the Sub as

:SUB_folderBrowser
echo.
echo %dict[9]%

rem PowerShell-Subroutine to open a Folder Browser
set "psCommand="(New-Object -COM Shell.Application)^
.BrowseForFolder(0,'%dict[22]%.',0,0).self.name""
for /F "usebackq delims=" %%i in (`PowerShell %psCommand%`) do set "newRoot=%%i"

set "romsDir=%newRoot%"
set "system=%newRoot%"
cls & echo %dict[12]% %romsDir%
rem Check if scraping from network drive and show warning about stopping ES
if not x%romsDir:\\=%==x%romsDir% echo %dict[13]%
echo. & goto modeSelection