pariahstation / pariah-station Goto Github PK

Round ID:

Round ID: 85

Testmerges:

#748 is the only relevant one.

Details:

The Chapel's 'Monastery Garden' area and a few of the nearby walkways are using mapped-in windows rather than window spawners.
This wouldn't usually be very noticable, but with the Horizon walls PR it means that none of them are spawning with 'low walls' under them.

(Reported by Fallikaar#5812 on the Discord server.)

Round ID:

N/A

Testmerges:

#469

Reproduction:

1. Become a Heretic.
2. Use a heretic blade (/obj/item/melee/sickly_blade) in your hand, which should teleport you to a safe location.
3. Remain in the same spot, now without a blade.

This is being caused by the is_safe_turf() proc not being fully updated for ZAS yet, and is presumably affecting other things that use the proc as well.
Everything up to line 151 seems to work fine, but after that point the code is assuming that floor_gases is a /datum/gas_mixture rather than a list.

Current:

ZASR:

I played atmos tech on round 44 and have some feedback. I was told to leave feedback here so hope that's alright.

1. "Irradiated" items had a biohazard symbol infront of them, obfuscating the items in some cases. I tried showering them but it didn't remove the sign. Here's an image: https://cdn.discordapp.com/attachments/912976196931817512/971192714664226816/pariahradiation.png
   Perhaps the contamination sign could be exchanged for something that still allows us to see the item.

2. Refilling rooms seems very slow. Brig was bombed during this shift and I repaired the breach quite quickly. Unfortunately, multiple doors/firelocks were destroyed so the Armoury, Sec Office and brig at large were among the rooms vented. The rooms took a good while to refill; much much longer than if I were doing the same repair job on TG. I even upped distro to 1200kpa and tripled all vent outputs. As far as I know, at the time there weren't other breaches draining distro, though can't be certain. Either way it had 100kpa+ in it when I analyzed so that shouldn't be the problem.
   I can't say for certain but I think that the atmos refresh rate was slower than on TG, despite there being no lag or anything. IDK if this is a feature of ZAS but that would contribute to the problem. Either way, it might be good to make vents work faster for refilling rooms. If each breach requires 10-20 minutes of gas refill time, engineering won't be able to cope with many bombings and it'd be less fun for them to do so.

Round ID:

60

Testmerges:

#708
#704
#699
#688
#678
#469

Reproduction:

Open HoP Locker, have no budget card.

Round ID:

H160/H1

Testmerges:

Reproduction:

step 1, drink some h20
step 2, boot up pariah
step 3, open loadouts
step 4, go-to suits and find the puffer jacket and select it
(MEME)(step 5, contact your local F/A-18 Hornet and request an airstrike on the smoke marker you have done beforehand, and watch the fireworks )

Okay, memes aside. in the lists of the DM for loadouts, a codder added two lines for #puffer_jacket

Reporting client version: 514.1583

Round ID:

85

Testmerges:

• Ports Vox species and various vox-related features
• Discord Verification System
• [DNM] Revert "[SEMI MODULAR] Ports the IC Spawning Module from SR"
• Baystation airlock sounds
• Mob holding refactor
• Re-adds the Deluxe Agent Card
• Ports the rest of my Contractor PRs from skyrat
• Adds a lightswitch button to the APC UI
• [MDB IGNORE] The tale of how this codebase is becoming Bay-TG or in other words Horizon/Bay walls port

Reproduction:

Build a thermomachine (the atmos heater/freezer) and screw open it's panel. I noticed this bug on pubbystation, haven't checked other maps.

regular thermomachine. all is well.

uh oh

Feathers and Body Feathers open to a BSOD window in Character pref

Round ID: 78
Server Time: 2022-05-28 18:32:53.

Round ID:

73

Testmerges:

Reproduction:

load up map
be doctor
no fridge with funny spray bottles

Round ID:

N/A

Reproduction:

Spawn as skrell. Die immedeately of heart attack.

Ontop of this, I discovered that Skrell hearts have no beating sprite, and their base sprite is likely invalid. When primed in hand skrell hearts will sprite swap to the default heart sprites, causing consistancy issues. They retain their name and description however.

Round ID: The atmo test round

Testmerges: fucked if I know

Reproduction: remove a distro pipe

Removing a distro pipe seemed to make distro have ALL the kpa

Reporting client version: 514.1583

Round ID:

98

Reproduction:

Join as a chaplain.
Pick punished sect.
Get to the burden level 6(Personally used HARS and a mutadone pill, left me exactly at 6 burden level).
Get a glow effect, mute mutation and 2 genetic abilities.
Abilities won't function properly - UI buttons don't respond. Reloading made the genetic abilities tab disappear from UI entirely.
Cry, for Chaplain seems to have many problems. Fun fact, on TG punished sect was also broken due to telepathy code being a stinky

piece of doo-doo. Moreover, maintenance sect's eye regeneration is constantly broken in almost every code, and don't get me started on organic slurry.

PS: Sorry for shitty crapping and circles.

Reproduction:

Caused by PR #704.

Before the PR (69a8a18):

After the PR (23aef65):

I haven't had a chance to properly look into this yet so it might be end up just being caused by something really obvious.

Reporting client version: 514.1583

Round ID:

84

Testmerges:

• Ports Vox species and various vox-related features
• Discord Verification System
• [DNM] Revert "[SEMI MODULAR] Ports the IC Spawning Module from SR"
• Baystation airlock sounds
• Mob holding refactor
• Re-adds the Deluxe Agent Card
• Ports the rest of my Contractor PRs from skyrat
• Adds a lightswitch button to the APC UI
• [MDB IGNORE] The tale of how this codebase is becoming Bay-TG or in other words Horizon/Bay walls port

Reproduction:

The HoP doesn't have access to the service hall on Metastation. Botany, Bar, Kitchen, e-t-c seem to work fine, but not the service hall doors themselves.

Round ID: 103

Testmerges:

#469: 'ZASR(eforged): A Baystation12 port & modification' by Kapu1178 at commit be287e74fe
#730: 'Baystation airlock sounds' by Kapu1178 at commit 593adbbd87
#767: 'Adds a Vox Description' by Tokorizo at commit e59c5fc335
#780: 'A little something special for AIs.' by francinum at commit 59cdddb21e
#777: 'Shuttle smoothing improvements' by SabreML at commit 7dea130530
#792: 'Most likely not how this works, but, clothing fitting, less human sprites on less conventionally humanoid species' by ElorgRHG at commit 3984ff92de
#786: 'NSV Parallax Port' by Tokorizo at commit 7a847fff6c
#787: 'Gamuioda (Moth) head shape update: They actually look like bugs now, woah.' by Ebin-Halcyon at commit 6aa0b5beee
#782: 'Just straight up removes plumbing' by ElorgRHG at commit 550c99554e

Reproduction:

Core refinery explodes the TTV outside of the refinery, which leads to this

Round ID:

61 but who cares

Testmerges:

doesnt matter

Reproduction:

play HoS

Round ID:

Lavaland monsters don't move when they are in a attack state.
I.E. Goaliths move one tile, then never move again and only use their ability.

Testmerges:

N/A

Reproduction:

Hit goalith once, watch it never move.

Round ID:116

Testmerges:

#780 at commit 59cdddb
#469 at commit 12e40b1
#740 at commit 5d881c6
#803 at commit b018908
#785 at commit 8275c22

Reproduction:

Attempting to install a prosthetic limb or spawn with the prosthetic limb quirk results in spawning with a missing limb, According to user report.

I have no clue what I did here

Round ID:

60

Testmerges:

#708
#704
#699
#688
#678
#469

Reproduction:

Attempt to write a paper with a Fancy Pen, Sign a paper, or really anything non-default.