Giter VIP home page Giter VIP logo

Comments (7)

hauleth avatar hauleth commented on June 30, 2024 1

For example (almost) default Phoenix Repo module

defmodule MyApp.Repo do
  use Ecto.Repo, otp_app: :my_app

  @dialyzer {:nowarn_function, rollback: 1}
  @dialyzer {:nowarn_function, insert_or_update: 2}
  @dialyzer {:nowarn_function, insert_or_update!: 2}
end

Which has no unused lines and no used lines (even if it is used during tests). I believe that in such case (0 SLOC and 0 covered lines) there should be automatically 100% coverage.

from excoveralls.

parroty avatar parroty commented on June 30, 2024 1

Thanks for the comment and sorry being late to respond. I'm closing by pushing as v0.6.0, but if you find further issue/comment, please reopen.

from excoveralls.

joshsmith avatar joshsmith commented on June 30, 2024

This is an interesting problem. I would think that even though there are zero executable lines of code, it's still technically correct to say that there is 0% coverage of that file.

What use case do you have where you have a completely empty file in your project?

from excoveralls.

joshsmith avatar joshsmith commented on June 30, 2024

Thanks, that's a good example!

from excoveralls.

parroty avatar parroty commented on June 30, 2024

Thanks for the feedback.
There was related item (#7 has some description). What do you think about applying the option in coveralls.json?

from excoveralls.

hauleth avatar hauleth commented on June 30, 2024

I think that this can be used as a temporary workaround, but it should be default behaviour.

from excoveralls.

parroty avatar parroty commented on June 30, 2024

OK, understood the point. Also, I've rechecked the coveralls.io output and it seems they're taking it as 100% (though not sure when changed). I'll be changing the default to 100%.

from excoveralls.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.