The optimizationgeneric from parththaker

optimizationgeneric's People

Contributors

pep8 suggests two lines between the import statement and the class declaration
unless you're working with python3 only, it's always better to make the class inherit from object
why is the class named regression_function?
the __init__ function (or any function for that matter) shouldn't be passed mutable arguments, in this case features and labels.
pep8 also suggests limiting the line length to <80. but this is a very contentious issue so you can ignore this.
what the function_update method is hard to understand, especially because of the long statement. it might be nice to create a private function that takes self.labels[i] and self.features[i].
you might consider using the zip function e.g. for label, feature in zip(self.labels, self.featues)

dataset is a class-level constant, pep suggests that you place the constants right beneath the imports and before any function/class definitions
i'd like it if the arg parser code was inside a if __name__ == "__main__":, if i understand the code correctly.
convert the print statements into print function calls and import print function from future

Add a README with comments on how to use the root and functions modules
consider creating a package that contains the two modules
consider adding a license to the repository. unless you explicitly add a license, people won't know whether or not they can legally use your code.

Recommend Projects