pascal-zarrad / tc-discord-webhooks Goto Github PK

Is your feature request related to a problem? Please describe.
Currently the messages for the webhooks are hardcoded and cannot be adjusted. This is bad and should be changed.

Describe the solution you'd like
Implement the functionality to customize the send webhooks.
This implementation can either be done via TeamCity's default way of customizing notifications or by a custom webhook editor in the administration area.

Is your feature request related to a problem? Please describe.
Currently the contribution guidelines are not optimal and have some clear typos. That should be fixed.

Describe the solution you'd like
Fix the typos by taking the improved version of the guidelines from https://github.com/pascal-zarrad/GCaptchaValidator

Is your feature request related to a problem? Please describe.
Would be nice to have info on what changes the build includes

Describe the solution you'd like
shoudl be possible to get the list of changes (commit msg log) and include it on the notification

Problem: Look's like no messages are sent

TeamCity Version: 2019.2.1 (build 71758)
Settings as displayed at the screenshot.

Describe the bug
A build triggered by the Finish Build Trigger doesn't trigger a notification. The original build that finished that was the trigger does make a notification though.

To Reproduce
Steps to reproduce the behavior:

1. Create a build config, let's call it build A. This build config is triggered by a VCS Trigger with branches specified that triggers it (ensure the branches are also in the Discord notify branch filter), e.g. +:refs/heads/release/QA
2. Create a build config, let's call it build B, that has a Finish Build Trigger on build A. This build gets the same VCS information from build A.
3. Create a change in the branch from step 1 and push it to trigger a new build

Expected behavior
Get a notification for build A and build B's start and stop events. Currently we only get notifications for build A and not B. Both A and B is the list of build configs that we want notifications for

Screenshots
Build A trigger config

Build B trigger config

Discord notification config

Additional context
None

Is your feature request related to a problem? Please describe.
The repo currently does use many of the great new features that GitHub introduced. We should change that.

Describe the solution you'd like
The following things should be changed:

• Add a code of conduct
• Add a social image
• Add contribution guidelines
• Add issue templates
• Add a PR template
• Enable GitHubs security features
• Switch from Travis to GitHub Actions

Is your feature request related to a problem? Please describe.
Currently the labels are unsorted, that should be changed.

Describe the solution you'd like
Change the GitHub issue labels to sort them and update the stale workflow to support the renamed labels.
We can apply numeric prefixes with some letter that descriptes the scope of a label (for example: C1 = Category 1)

Describe the bug
In the message, the Branch always shows "Default", even if the build is on another branch than master

To Reproduce
Enable notifications
Launch a build
Read the notification on discord

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
configuration

notification

Environment:

• OS: Linux
• Dist: Docker
• Shell: Bash

Additional context
I use three build features
Performance Monitor
SSH agent
Report change status to GitHub

Also, when I click on the link, it gives me the correct build report, and in the report parameters, I see the correct branch name in teamcity.build.branch
and teamcity.build.branch.is_default is marked as false.

1. set the branch filter to +:*

-> you expect to have branch name in notifications
Instead notification looks like this:

Build succeeded!
The build with the ID 41167 has succeeded!
Project:
ZenID
Build:
Demo deploy
Branch
Default

With branch == Default

I'm trying to use it on a server that needs proxy.
I've tried setting TEAMCITY_SERVER_OPTS with -Dhttp.proxyHost=.... -Dhttp.proxyPort=... -Dhttps.proxyHost=.... -Dhttps.proxyPort=.... -Dhttp.nonProxyHosts=....
and restarting teamcity, then even uninstall and install the plugin again.

Also tried to add

teamcity.http.nonProxyHosts=...
teamcity.https.proxyHost=...
teamcity.https.nonProxyHosts=...
teamcity.http.proxyHost=...
teamcity.https.proxyPort=...
teamcity.http.proxyPort=...

on internal.properties

but everytime I get this:

[2021-02-13 23:42:24,271] ERROR [9@58f69f86'; Normal executor 1] - notificator.DiscordNotificator - Failed to send the WebHook! org.apache.http.conn.HttpHostConnectException: Connect to discord.com:443 [discord.com/162.159.136.232, discord.com/162.159.135.232, discord.com/162.159.128.233, discord.com/162.159.137.232, discord.com/162.159.138.232] failed: Connection timed out (Connection timed out) at org.apache.http.impl.conn.DefaultHttpClientConnectionOperator.connect(DefaultHttpClientConnectionOperator.java:156) at org.apache.http.impl.conn.PoolingHttpClientConnectionManager.connect(PoolingHttpClientConnectionManager.java:374) at org.apache.http.impl.execchain.MainClientExec.establishRoute(MainClientExec.java:393) at org.apache.http.impl.execchain.MainClientExec.execute(MainClientExec.java:236) at org.apache.http.impl.execchain.ProtocolExec.execute(ProtocolExec.java:186) at org.apache.http.impl.execchain.RetryExec.execute(RetryExec.java:89) at org.apache.http.impl.execchain.RedirectExec.execute(RedirectExec.java:110) at org.apache.http.impl.client.InternalHttpClient.doExecute(InternalHttpClient.java:185) at org.apache.http.impl.client.CloseableHttpClient.execute(CloseableHttpClient.java:83) at org.apache.http.impl.client.CloseableHttpClient.execute(CloseableHttpClient.java:108) at com.github.playerforcehd.tcdiscordwebhooks.discord.DiscordWebHookProcessor.sendDiscordWebHook(DiscordWebHookProcessor.java:95) at com.github.playerforcehd.tcdiscordwebhooks.discord.DiscordWebHookProcessor.sendDiscordWebHook(DiscordWebHookProcessor.java:73) at com.github.playerforcehd.tcdiscordwebhooks.notificator.DiscordNotificator.processNotify(DiscordNotificator.java:145) at com.github.playerforcehd.tcdiscordwebhooks.notificator.DiscordNotificator.notifyBuildFailed(DiscordNotificator.java:258) at jetbrains.buildServer.notification.impl.UserRulesAwareNotificationListener$NotificatorEventAdapter.notifyBuildFailureWatchers(UserRulesAwareNotificationListener.java:237) at jetbrains.buildServer.notification.impl.UserRulesAwareNotificationListener$NotificatorEventAdapter.buildFailedSubsequent(UserRulesAwareNotificationListener.java:192) at jetbrains.buildServer.notification.impl.UserRulesAwareNotificationListener$NotificatorEventAdapter.access$400(UserRulesAwareNotificationListener.java:148) at jetbrains.buildServer.notification.impl.UserRulesAwareNotificationListener.buildFailed(UserRulesAwareNotificationListener.java:23) at jetbrains.buildServer.notification.NotificationProcessor$5.call(NotificationProcessor.java:3) at jetbrains.buildServer.notification.NotificationProcessor$19.run(NotificationProcessor.java:8) at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) at java.base/java.lang.Thread.run(Thread.java:829) Caused by: java.net.ConnectException: Connection timed out (Connection timed out) at java.base/java.net.PlainSocketImpl.socketConnect(Native Method) at java.base/java.net.AbstractPlainSocketImpl.doConnect(AbstractPlainSocketImpl.java:399) at java.base/java.net.AbstractPlainSocketImpl.connectToAddress(AbstractPlainSocketImpl.java:242) at java.base/java.net.AbstractPlainSocketImpl.connect(AbstractPlainSocketImpl.java:224) at java.base/java.net.SocksSocketImpl.connect(SocksSocketImpl.java:403) at java.base/java.net.Socket.connect(Socket.java:609) at org.apache.http.conn.ssl.SSLConnectionSocketFactory.connectSocket(SSLConnectionSocketFactory.java:368) at org.apache.http.impl.conn.DefaultHttpClientConnectionOperator.connect(DefaultHttpClientConnectionOperator.java:142) ... 22 more

Describe the bug
A clear and concise description of what the bug is.

When attempting to assign a hook in Notification Rules -> Discord WebHook, no settings box appears to be able to assign the hook or username. You can see the normal "watching" rules box, but no settings for this tool.

To Reproduce
Steps to reproduce the behavior:

1. Install Webhook Plugin
2. Restart Server
3. Go to Groups -> Notification Rules -> Discord WebHook
4. Notice the settings box is missing

Expected behavior
Should have settings box for hook url and username visible and able to be edited

Screenshots

Environment:

• OS: Windows 10

Is your feature request related to a problem? Please describe.
Check if here is stuff that needs to be updated and prepare the project for further development.
This includes adjustments to the development environment.

Describe the solution you'd like

• Check documentation and ensure it is up to date.
• Update local development environment
• Update targeted TeamCity version