patrick96 / click-link Goto Github PK

like Title

I'm using Atom 1.22.1 x64.

Line wrapping in the editor breaks the functionality of click-link.

If I move the text so it doesn't wrap then the ctrl+click works.

The CTRL-click creates a double-cursor (document wise) if the mouse-click isn't pointed directly over the document cursor. This can be rid of by another mouse-click anywhere in the said document.

I tried pressing Ctrl and Mouse left click, nothing happens, seems like it will not work if multi select is enable and that's very important plugin as well

If a link is wrapped, only the line that was clicked on will be opened as a link, rather than the entire link.

Running Atom 1.58.0 on macOS 10.15.7

(I know this project is no longer being maintained, but I figured I'd record this issue in case anyone else has the same problem or wants to try to fix it.)

In click-link/styles/click-link.less:

Starting from Atom v1.13.0, the contents of atom-text-editor elements are no longer encapsulated within a shadow DOM boundary. This means you should stop using :host and ::shadow pseudo-selectors, and prepend all your syntax selectors with syntax--. To prevent breakage with existing style sheets, Atom will automatically upgrade the following selectors:

• atom-text-editor::shadow .hyperlink:hover => atom-text-editor.editor .syntax--hyperlink:hover

• atom-text-editor::shadow .source.gfm .link:hover => atom-text-editor.editor .syntax--source.syntax--gfm .syntax--link:hover

Automatic translation of selectors will be removed in a few release cycles to minimize startup time. Please, make sure to upgrade the above selectors as soon as possible.

When I open 'http://www.cc98.org/dispbbs.asp?boardid=80&id=4643677', it wil automatic transform to 'http://www.cc98.org/dispbbs.asp?boardid=80&id=4643677'. So I can't open the url correctly.
Hope you can fix it, thank you!

for example

1. Install [Chrome Dev for Linux](https://www.google.com/chrome/browser/?platform=linux&extra=devchannel)

ctrl-click on that google link doesn't do anything

This is not working on a Mac OS (v10.11.6) since ctrl+click is interpreted as right-click. Would it be possible to change it to cmd+click for a Mac?

Atom redid panes in 1.17.0, these changes affected the DOM, and thus the query selector for this package.

I was able to fix this locally by changing the query selector from atom-pane-container.panes to atom-workspace. Just passing it along in case you wanted to fix it upstream!

The 1.0.7 version doesn't install both from Atom or with the apm install in the said directory.
The 1.0.5 version works perfectly well.
This is probably a bug not due directly with your package since others have installed it successfully.

I run a Windows 10.
Atom version 1.12.6

(included debug.txt)
npm-debug.txt
file)

Upon upgrading to 1.0.6, I'm getting this message when clicking on any button or link in the settings page. When I try to create an issue with the "Create issue on the click-link package", I get a 414 Request-URI Too Large message.

/Users/wolfy/.atom/packages/click-link/lib/click-link.js:13
Hide Stack Trace
TypeError: Cannot read property 'getGrammar' of undefined
    at atom-pane-container.<anonymous> (/Users/wolfy/.atom/packages/click-link/lib/click-link.js:13:66)

I tried uninstalling and reinstalling, but that failed. I've reverted to 1.0.5 in the meantime.

Open wrong link when Soft Wrap enabled

If link is very long, click-link will open wrong link

When wrap around is on, a very long link will be truncated.

Ex:
https://github.com/patrick96/cli↩
ck-link

points to : https://github.com/patrick96/cli
instead of: https://github.com/patrick96/click-link

After update the packge from 1.0.10 to latest one in Atom, I got this error:

TypeError: Cannot read property 'paneContainer' of undefined
    at Object.activate (/home/arvin/.atom/packages/click-link/lib/click-link.js:11:43)
    at Package.module.exports.Package.activateNow (/usr/share/atom/resources/app.asar/src/package.js:218:19)
    at /usr/share/atom/resources/app.asar/src/package.js:190:32
    at Package.module.exports.Package.measure (/usr/share/atom/resources/app.asar/src/package.js:96:15)
    at /usr/share/atom/resources/app.asar/src/package.js:183:26
    at Package.module.exports.Package.activate (/usr/share/atom/resources/app.asar/src/package.js:180:34)
    at PackageManager.module.exports.PackageManager.activatePackage (/usr/share/atom/resources/app.asar/src/package-manager.js:550:34)
    at /usr/share/atom/resources/app.asar/src/package-manager.js:531:29
    at Config.module.exports.Config.transactAsync (/usr/share/atom/resources/app.asar/src/config.js:337:18)
    at PackageManager.module.exports.PackageManager.activatePackages (/usr/share/atom/resources/app.asar/src/package-manager.js:526:19)
    at PackageManager.module.exports.PackageManager.activate (/usr/share/atom/resources/app.asar/src/package-manager.js:508:46)
    at /usr/share/atom/resources/app.asar/src/atom-environment.js:826:28

Workaround:
Temporary I replaced following line in /home/arvin/.atom/packages/click-link/lib/click-link.js file:

From:
atom.workspace.activePaneContainer.paneContainer.element.addEventListener("click", function(e) {

To:
document.querySelector("atom-pane-container.panes").addEventListener("click", function(e) {

Would be great to push the fix.

If a link is wrapped in to a second line, only the first line gets parsed, the rest of the link is missing.
If you click on the first line only what is in the first line gets interpreted.
Clicking the second line does nothing (maybe because the protocoll is missing).

thank you for this nice package anyways :)