Giter VIP home page Giter VIP logo

Comments (4)

patrickmichalik avatar patrickmichalik commented on June 25, 2024

Hello! Thanks for the report. We’ve followed the reproduction instructions and tried several other setups, but unfortunately, we haven’t been able to reproduce the crash. Could you share a minimal reproducible example? Two extra notes:

  • The problem reported in issue #200 was resolved in Vico 1.6.5. Something else seems to be happening here.
  • At least by default, AnimatedVisibility appears to clip its content, not resize it. The CartesianChartHost’s height should remain unaffected, and this was the case in our testing.

from vico.

fuadenergyom avatar fuadenergyom commented on June 25, 2024

Hey Patrick! Thank you very much for taking the time to look at this. I rolled back to yesterday's version of the app and tried to find what was causing the issue, and I figured it out. This is an extremely specific case: my AnimatedVisibility is inside a Column, which is inside a Box, which is inside another Column, and the whole thing is inside the content: @Composable (PaddingValues) -> Unit block of BottomSheetScaffold. When I use the PaddingValues in the parent Column, or the Box that's the only child of it, it would cause this crash. Another thing worth considering is that I measure content's height to determine sheetPeekHeight for BottomSheetScaffold.
I don't know if you think this is worth addressing or not, but here is the minimal reproduction:

BottomSheetScaffold(
...
) { paddingValues ->
Column(
Modifier
.fillMaxSize()
.padding(paddingValues) // The crash doesn't happen if this is removed.
) {
Box(
Modifier
.fillMaxWidth() // We can also put padding(paddingValues) here and it would crash.
.background(Color.White)
.onGloballyPositioned { coordinates ->
val height = with(localDensity) {
coordinates.size.height.toDp()
}
sheetHeight = (screenHeight - height) - 20.dp
}
) {
Column(
modifier = Modifier
.fillMaxWidth()
.padding(horizontal = 20.dp)
) {
HomeViewSwitch( // This is just to show/hide the chart
modifier = Modifier,
mapViewSelected = mapViewSelected,
onClick = {
screenModel.changeHomeScreenView()
}
)
AnimatedVisibility(
visible = !mapViewSelected,
enter = fadeIn(tween(300)),
exit = fadeOut(tween(300))
) {
LineChartImpl( // This is a wrapper around CartesianChartHost
dataPoints = listOf(10f, 20f, 3f, 4f, 6f)
)
}
}
}
}
}

from vico.

Gowsky avatar Gowsky commented on June 25, 2024

Hello @fuadenergyom, please provide a self-contained MRE. The code you've shared contains unknown references.

from vico.

Gowsky avatar Gowsky commented on June 25, 2024

Closing due to no MRE.

from vico.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.