Comments (4)
Hello! Thanks for the report. We’ve followed the reproduction instructions and tried several other setups, but unfortunately, we haven’t been able to reproduce the crash. Could you share a minimal reproducible example? Two extra notes:
- The problem reported in issue #200 was resolved in Vico 1.6.5. Something else seems to be happening here.
- At least by default,
AnimatedVisibility
appears to clip its content, not resize it. TheCartesianChartHost
’s height should remain unaffected, and this was the case in our testing.
from vico.
Hey Patrick! Thank you very much for taking the time to look at this. I rolled back to yesterday's version of the app and tried to find what was causing the issue, and I figured it out. This is an extremely specific case: my AnimatedVisibility
is inside a Column
, which is inside a Box
, which is inside another Column
, and the whole thing is inside the content: @Composable (PaddingValues) -> Unit
block of BottomSheetScaffold
. When I use the PaddingValues
in the parent Column, or the Box that's the only child of it, it would cause this crash. Another thing worth considering is that I measure content's height to determine sheetPeekHeight
for BottomSheetScaffold
.
I don't know if you think this is worth addressing or not, but here is the minimal reproduction:
BottomSheetScaffold(
...
) { paddingValues ->
Column(
Modifier
.fillMaxSize()
.padding(paddingValues) // The crash doesn't happen if this is removed.
) {
Box(
Modifier
.fillMaxWidth() // We can also put padding(paddingValues) here and it would crash.
.background(Color.White)
.onGloballyPositioned { coordinates ->
val height = with(localDensity) {
coordinates.size.height.toDp()
}
sheetHeight = (screenHeight - height) - 20.dp
}
) {
Column(
modifier = Modifier
.fillMaxWidth()
.padding(horizontal = 20.dp)
) {
HomeViewSwitch( // This is just to show/hide the chart
modifier = Modifier,
mapViewSelected = mapViewSelected,
onClick = {
screenModel.changeHomeScreenView()
}
)
AnimatedVisibility(
visible = !mapViewSelected,
enter = fadeIn(tween(300)),
exit = fadeOut(tween(300))
) {
LineChartImpl( // This is a wrapper around CartesianChartHost
dataPoints = listOf(10f, 20f, 3f, 4f, 6f)
)
}
}
}
}
}
from vico.
Hello @fuadenergyom, please provide a self-contained MRE. The code you've shared contains unknown references.
from vico.
Closing due to no MRE.
from vico.
Related Issues (20)
- Data Labels for Stacked bar chart have wrong position and value HOT 4
- Marker missing style defined by custom MarkerLabelFormatter HOT 9
- Cannot access CartesianChartHost in my project HOT 2
- Reading a state that was created after the snapshot was taken or in a snapshot that has not yet been applied HOT 6
- Cannot make a LabelFormatter on stacked column chart HOT 11
- Markers only works for the first line series HOT 2
- Crash on changing dataset which contains negative values HOT 3
- Throwing OOM Exception when using Chart in LazyColumn HOT 7
- Marker duplicated HOT 2
- No axisValueOverrider in rememberCandlestickCartesianLayer HOT 4
- Feature Missing - Slide to Position HOT 4
- Text alignment on y-axis label only shown correctly for ALIGN_NORMAL HOT 6
- [View] CartesianChartView always handles touches, even if `isClickable` or `isEnabled` is false HOT 6
- Cannot Round NaN to Float HOT 4
- ColumnChart with MergeMode.Grouped does not receive callback for all the series added through CartesianMarkerVisibilityListener HOT 2
- TopBottomShader.splitY doesn't do anything HOT 1
- Incorrect floating point rounding in xSpacingMultiplier calculation leads to wrong IllegalStateException HOT 6
- At the end the label of bottom axis is cut off HOT 5
- Couple crashes with `java.util.ConcurrentModificationException` and `java.util.NoSuchElementException: Key null is missing in the map` HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from vico.