All instances of "Toast notifications" on the Overview page should be "Toast Notifications"
http://www.patternfly.org/pattern-library/communication/toast-notifications/#/api

Remove "description" from the About Modal https://github.com/patternfly/patternfly-design/blob/master/pattern-library/communication/about-modal/design/design.md

Upon mention of the "line chart", the bar chart pattern (https://github.com/patternfly/patternfly-design/blob/master/pattern-library/data-visualization/bar-chart/design/overview.md) should link to it (http://www.patternfly.org/pattern-library/data-visualization/line-chart/#/api).

"Line Chart" should has have header style capitalization.

There should not be a cards AND a card folder under the pattern-library. add the design folder for "card" underneath the "cards" folder and removed the "card" folder from the pattern-library

No guidelines on what the value in the center of the donut chart should report. Examples show either Available or Used value, but what is preferable and when?

The example used in the Overview page for List View is too wide to fit in the page template and therefor wraps. It therefore looks different when opened in a separate window.

Recommendation: Redesign the example so it fits.

Re masthead, Kyle confirmed that the following example is outdated and should come off the PF site: http://www.patternfly.org/pattern-library/navigation/horizontal-navigation/horizontal-navigation.html#

On the Trend Card page: http://www.patternfly.org/pattern-library/cards/trend-card/#/api
There are "-" listed after all the labels and should be removed.

Here is the PR for the new Masthead pattern: https://github.com/beanh66/patternfly-design/blob/fb4b2e134405ed5006fe30620b584a7a50437fdb/pattern-library/application-framework/masthead/masthead_overview.md

The Forms pattern has numerous inconsistencies with other patterns in the library. Some specific issues are:

• Inconsistency between button usage in examples and other button guidelines in PatternFly.
• Inconsistency between labeling recommendations between Forms and Form Field Layout pages.

Current Forms pattern only addresses simple data entry forms focusing on modals.

Recommendation: Entire Forms section should be reconsidered using a top-down approach. What are the patterns we need? How do we leverage existing work that was done? Where are the gaps.

Heat map does not have usabiilty tests or discovery so those folders should be removed. See:
https://github.com/patternfly/patternfly-design/tree/master/pattern-library/data-visualization/heat-map

On the Overview tab for the Donut Chart, all instances of "donut chart" should be "Donut Chart"
http://www.patternfly.org/pattern-library/data-visualization/donut-chart/#/api

The are various inconsistencies and omissions between design, HTML, and Angular examples. These include:

• Angular examples do not include top-labeled bars as per HTML example and design.
• Tooltip styles are inconsistent between HTML and Angular example. HTML chart does not display PatternFly standard tool tips.
• Examples do not consistently express utilization in bar labeling.

There is also no reference to bar labeling in design description and when to use top labeled vs. left/right labeled bars or explanation of color coding.

The example shown on this page: http://www.patternfly.org/pattern-library/widgets/#info-tip was superseded by the Notification Drawer and new masthead design and should be revised. Furthermore, an Info Tip is just a general pop-up that is not specifically associated with messages or notifications so this example is misleading.

The pattern library currently includes three parallel view types for presenting summary level content: Card, List, and Table views. Card and List views are presented as full page examples to show how this view can be used in the context of a page. Table View is presented as a stand-alone pattern without additional context. Table view seems to focus more specifically on behaviors associated with data tables.

Recommendation: Create a full page Table View pattern that shows how a table can be used for a summary view similar to List or Card views. Separate out details of data table interaction into a new pattern as tables may be useful in a variety of view contexts.

http://www.patternfly.org/pattern-library/data-visualization/bullet-chart/#/api

On the overview page, "bullet graph" should be "Bullet Graph"

On the table view page [1], replace all instances of "Data Toolbar" with "Toolbar" and link them over to the Toolbar pattern here: http://www.patternfly.org/pattern-library/forms-and-controls/toolbar/

[1] http://www.patternfly.org/pattern-library/content-views/table-view/

The Dashboard Card (Base) pattern is intended as a general container for other dashboard cards, but the relationship between this pattern and other dashboard card patterns in unclear. These is also redundancy between the documentation of features that may be part of the card base pattern (like the time frame filter) rather than the card content itself. This seems like a perfect opportunity for modularization where all dashboard cards are constructed from a consistent base container and additional charts.

There are also inconsistencies between design page and examples around Title formatting. Design says Title is always followed by a horizontal separator, but this is not true in all examples.

In Angular example, footer link does not display hand cursor on hover. See example for Footer with Link & Timeframe filter

On the list view page [1], replace all instances of "Data Toolbar" with "Toolbar" and link them over to the Toolbar pattern here: http://www.patternfly.org/pattern-library/forms-and-controls/toolbar/

[1] http://www.patternfly.org/pattern-library/content-views/list-view/#/api

There are multiple inconsistencies between trend card design examples and Angular implementation examples. Some of these include:

• Treatment of card with single trend and card with multiple trends are inconsistent in appearance of card title, placement of time frame selector, and placement of text labels.
• Treatment and placement of card titles differs between examples.

In the overview section, "aggregate status card" should be "Aggregate Status Card"
http://www.patternfly.org/pattern-library/cards/aggregate-status-card/#/api

The optional Pin feature is documented as part of Tertiary Navigation, but wouldn't this feature be just as valid for 2 levels of navigation?

Also, not sure that the icon used for Pin is what we ended up with. Pin feature is not demonstrated in any of the examples.

There is some problems with the formatting on the Login page under the Notifications section. See: http://www.patternfly.org/pattern-library/application-framework/login-page/#/design

Remove the section header called "Example" on the overview page. http://www.patternfly.org/pattern-library/communication/wizard/#/api

Card does not have any information for discovery or usability testing so it's not necessary to have those template .md files or folders in there. See: https://github.com/patternfly/patternfly-design/tree/master/pattern-library/card

"Grid lines:" (the second bullet) should be "Grid Lines:" http://www.patternfly.org/pattern-library/data-visualization/area-chart/#/api

On the design tab (http://www.patternfly.org/pattern-library/data-visualization/bar-chart/#/api), after item "5. Bar:", there is a bug because "Interaction" has a "-" before it. I think it was supposed to be a sub-bullet.

It should look like...

• Bar:
  • Interaction:
    • If drill down behavior is supported, clicking on a bar will navigate to the appropriate page.
    • If supported, right clicking on an bar will bring up a menu with associated actions. If you are using a grouped bar chart, right clicking on a group will bring up a menu with associated actions for that group.
  • Width: All bars should be the same width.
  • Color: For recommendations on fill colors, see the Color Palette.
  • Height: Bar height in vertical charts is the dimension that represents its value.
  • Spacing: Spacing between bars should be equal. In the case of grouped charts, increase the spacing between main categories.

I used the template, which has relative links. Can we update the templates to have the correct format @cshinn ?

Same issue as patternfly/patternfly#607, jquery.matchHeight-min.js has changed location.

However there are also some pages that pull resources from CDNs and I suppose that's not what you want. Changing those would require further synchronization with patternfly-org.

The PF kebab example (https://www.patternfly.org/pattern-library/widgets/#kebabs) shows sentence style capitalization for menu items.

In PF T&W (http://www.patternfly.org/styles/terminology-and-wording/) the section for Capitalization for Common Components - it doesn’t talk about capitalization for menu items. But it does say to use Headline capitalization for Button labels. My thought would be Headline would be used for menu items as well.

Could the appropriate recommendation be added to the documentation?

The list view design documentation has the following:

"Pagination: Card view can also support pagination. See Pagination for more details."

Should say Card view instead of list view. Link goes to github instead of the pattern on the site.

Current documentation does not explain what to display if multiple conditions are being shown in a card and only some of them are reporting conditions that need attention (others are OK). Documentation only addresses what to show if everything is shown or if everything is running OK.

the design and overview files in the drag-and-drop folder are incorrectly named.
Currently, they are called drag-drop_design.md and drag-drop_overview.md; they should be called design.md and overview.md

http://www.patternfly.org/pattern-library/application-framework/login-page/#/api

• All instances of "heat map" should be "Heat Map" on the Overview tab
• Instead of referring to "a" heat map, we want to refer specifically to our heat map. Therefore...
  • Instead of "A heat map is a visualization of objects as blocks in a grid.", change to "The Heat Map is a visualization of objects as blocks in a grid. "
  • Instead of "When heat map items become so...", change to "When the Heat Map items become...."
  • Instead of "The most common use cases for a heat map are:", change to "The most common use cases for the Heat Map are:"

http://www.patternfly.org/pattern-library/data-visualization/heat-map/#/api

http://www.patternfly.org/pattern-library/forms-and-controls/form-field-layouts/#/api

The section for left aligned labels has a screenshot that shows top aligned labels instead

In the Card View pattern, the HTML and Angular implementations don't match. HTML follows the design in terms of form and function. Angular implementation lacks formatted card contents and supports selection options that are not described in the design.

Recommend to update Angular card appearance and clarify selections model (updating the design if necessary).

http://www.patternfly.org/pattern-library/forms-and-controls/toolbar/#_

Behavior for row expansion is inconsistent between HTML and Angular implementations. HTML expands when clicking the row. Angular only when clicking the caret icon. Design is closer to HTML implelmentation.

Existing documentation is not clear about how to handle drill-down if multiple elements within a list item or card are linked. Current guidance that a single click on a list or card item should drill down to the next level may not be sufficient for all use cases.

Recommendation: Consider cases where there may be multiple drill-down links and how one should handle this case vs. single drill-down link.

Remove the h1 titles "Overview" and "Examples"
http://www.patternfly.org/pattern-library/cards/trend-card/#/api

On this page - http://www.patternfly.org/pattern-library/data-visualization/bar-chart/#/api

Right now it looks like:
Legend: It is recommended to include a legend to define the colors on the chart. On the bar chart, the legend may be located left aligned and underneath the chart or left aligned and to the right of the chart. - Interactive Legend (optional): Clicking on a series in the legend should toggle the visibility of the series in the chart.

and should look like...

• Legend: It is recommended to include a legend to define the colors on the chart. On the bar chart, the legend may be located left aligned and underneath the chart or left aligned and to the right of the chart.
  • Interactive Legend (optional): Clicking on a series in the legend should toggle the visibility of the series in the chart.

While the design page includes for 2-Level (Secondary) and 3-Level (Tertiary) navigation options, the examples on the Overview and Code pages are only for 2-Level Nav.

The buttons in the modal examples in the form pattern (link is below) should be updated.https://www.patternfly.org/pattern-library/forms-and-controls/forms/#_

• "Save changes" should be changed to "Save" ( or at a minimum "Save Change" with initial caps)
• "Close" should be changed to "Cancel", since this is canceling the operation not just closing the modal

Remove the title "Example" from the overview page
http://www.patternfly.org/pattern-library/communication/empty-state/#/api

The Angular implementation does not present row variations as does the HTML/CSS example. There is also no guidance on how these variations can be used, what types of element are available and how they can be defined.

Recommendation: Provide more context for examples and explain general template that should be used to format list items. This would promote better consistency between designs that use list view. Create consistent HTML and Angular examples that implement these variations.

Remove the word "Overview" as it's redundant on Heat Map pattern https://github.com/patternfly/patternfly-design/blob/master/pattern-library/data-visualization/heat-map/design/overview.md

Remove the section title called "Overview" on the overview tab. Remove the example header called "Default Table". It's not necessary and we can just show the screenshot. http://www.patternfly.org/pattern-library/content-views/table-view/#/_