DirectDebitService::submit does not gracefully handle bad data. If the submitted Purchase object has none of ach, eft, bacs, or sepa set, the function will cause a PHP error: Undefined variable: return

Additionally, DirectDebitService::standaloneCredits suffers from the same logic flaw. If the submitted StandaloneCredits object has none of ach, eft, or bacs set, the function will cause a PHP error:
Undefined variable: return

It would likely be more appropriate to throw an exception in these cases. Or, at least have some meaningful return.

\Paysafe\CardPayments\Filter does not properly extend JSONObject. The class def looks like:

class Filter extends JSONObject

However, the Filter class is in the CardPayments sub-namespace, while JSONObject is in the root Paysafe namespace.

Based on the definition of DirectDebit\Filter, I believe the class def should be:

class Filter extends \Paysafe\JSONObject

We should support different packaging platform so that merchants has a better way to handle and manage these external libraries.

https://packagist.org/

`$auth = new Authorization(array(
'merchantRefNum' => "0f8fad5bd9cb469fa16570867728950e",
'amount' => 555,
'settleWithAuth' => true,
'card' => array(
'cardNum' => "4111111111111111",
'cvv' => '123',
'cardExpiry' => array(
'month' => "06",
'year' => "2020",
)
),
'billingDetails' => array(
'zip' => "M5H 2N2"
)
));

$response = $client->cardPaymentService()->authorize($auth);`

if the amount is 555.50 it fails saying it needs to be a Int

As of a0f7cee it appears there has been a mass renaming of class files such that filename case should now match class name case. However, there appears to have been an error when renaming PaysafeApiclient.php The c is still lowercase in the filename, yet the C is upper case in the class name.

Example for creating a customer profile using a single-use token via the PHP SDK outlined at the following page does not function:
https://developer.paysafe.com/en/sdks/server-side/php/customer-vault/

Code outlined is as follows:

$profile = new Profile(array(
	"merchantCustomerId" => $merchantCustomerId,
	"locale" => "en_US",
	"firstName" => "John",
	"lastName" => "Smith",
	"email" => "[email protected]",
	"phone" => "713-444-5555",
	"card" => array(
		'singleUseToken' => "SCrGrrRANmOVtcVc"
	)
));
$response = $client->customerVaultService()->createProfile($profile);

However, the customer vault profile object ignores the 'card' property, so it is never stored and encoded in the request to create a vault profile. Example should not outline this process, or the 'card' property should be added to the field types in source/paysafe/customervault/profile.php and the optional fields set in source/paysafe/customervaultservice.php

I fixed with below steps:

1. lib/vendor/paysafegroup/paysafe_sdk_php/source/paysafe.php:

function __PaysafeAutoloader($className)
{
$classPath = str_replace("\", DIRECTORY_SEPARATOR, $className);

if (($classFile = realpath(__DIR__ . DIRECTORY_SEPARATOR . $classPath . '.php'))) {
    require_once( $classFile );
}

}

Removed use of strtolower function with first line of function.

2. Renamed directory from "lib/vendor/paysafegroup/paysafe_sdk_php/source/paysafe" to "lib/vendor/paysafegroup/paysafe_sdk_php/source/Paysafe"

Please check - my side that is working now.

Thanks.

Hello,
Found an issue with the following request:

$auth = $client->cardPaymentService()->authorize(new Authorization(array(
            'merchantRefNum' => uniqid(date('Ymd-')),
            'customerNotificationEmail' => $email,
            'amount' => $amount * $currencyBaseUnitsMultiplier,
            'settleWithAuth' => true,
            'card' => array(
                'cardNum' => $ccn,
                'cvv' => $cvv,
                'cardExpiry' => array(
                    'month' => $exp1,
                    'year' => $exp2
                )
            ),
            'profile' => array(
                'email' => $email,
                'firstName' => $firstName,
                'lastName' => $lastName
            ),
            'billingDetails' => array(
                'zip' => $postal_code
		    ),
		    'customerIp' => $_SERVER['REMOTE_ADDR']
        )));

All "profile" fields were not passed to PaySafe (first name, last name and email).
Had to edit the file "/Paysafe/CardPaymentService.php" and add 'profile' into a list of "setOptionalFields" on line 77.

Hello,

1.0.3 is outdated and is missing important fixes such as ed4c707

https://github.com/paysafegroup/paysafe_sdk_php/releases

Thank you

Function updateCard in CustomerVault filters out singleUseToken as it doesn't allow it even as a facultative param.

https://github.com/paysafegroup/paysafe_sdk_php/blob/master/source/Paysafe/CustomerVaultService.php#L408

This prevents updating cards with a single use token through the customer vault.

As per the API documentation, there is an additional field 'storedcredential' that is required for recurring transactions:
https://developer.paysafe.com/en/cards/api/#/introduction/complex-json-objects/storedcredential

This is not part of the optional fields for the card payment service authorise method:
https://github.com/paysafegroup/paysafe_sdk_php/blob/master/source/Paysafe/CardPaymentService.php#L77

Please add 'storedcredentials' to the optional fields list.

When providing the initialTransactionId and / or the externalInitialTransactionId parameters, as outlined within documentation, to an authorization request using the SDK, they are stripped out and ignored.

See:
https://developer.paysafe.com/en/cards/api/#/introduction/complex-json-objects/storedcredential

Opened a Pull Request at:
#37 (comment)

API is supposed to support fetching a profile with merchantCustomerId but SDK requires profile id.

Modifying the library to not require id and support merchantCustomerId still throws an InvalidRequestException, HTTP code 400, error code 5023

https://developer.paysafe.com/en/vault/api/#/reference/0/profiles/get-profile-using-merchant-customer-id

https://github.com/paysafegroup/paysafe_sdk_php/blob/master/source/paysafe/customervault/profile.php#L80

Currently

 'achBankAccounts' => '\Paysafe\CustomerVault\ACHBankaccounts',
 'bacsBankAccounts' => '\Paysafe\CustomerVault\BACSBankaccounts',
 'eftBankAccounts' => '\Paysafe\CustomerVault\EFTBankaccounts',
 'sepaBankAccounts' => '\Paysafe\CustomerVault\SEPABankaccounts'

Should be

 'achBankAccounts' => 'array:\Paysafe\CustomerVault\ACHBankaccounts',
 'bacsBankAccounts' => 'array:\Paysafe\CustomerVault\BACSBankaccounts',
 'eftBankAccounts' => 'array:\Paysafe\CustomerVault\EFTBankaccounts',
 'sepaBankAccounts' => 'array:\Paysafe\CustomerVault\SEPABankaccounts'

/card-payment-simple.php - Class 'Paysafe\PaysafeApiClient' not found in /home/seb/Downloads/paysafe/sample/card-payment-simple.php on line 9

Is it normal ? I am on Ubuntu 14.04

Hi,

In PaysafeApiClient the method threeDSecureService() returns ThreeDSecureService. I'm getting a fatal error saying class Paysafe\ThreeDSecureService cannot be found. Simple fix was to just change ThreeDSecureService to ThreeDsecureService (lowercase 's' in secure).

Thanks,

Anthony

File cardpayments/dateofbirth.php defines a class VisaAdditionalAuthData, which is of course also defined in file cardpayments/visaadditionalauthdata.php.

Should the class defined in dateofbirth.php instead be named DateOfBirth, as the naming scheme for the rest of the classes/filenames would suggest?