The flowtype-hoc-exploration from pcardune

flowtype-hoc-exploration's People

Contributors

Stargazers

Watchers

flowtype-hoc-exploration's Issues

Did you see different behavior when used in different files?

Thanks for your notes-- they were really informative for me!

Did you notice different Flow behavior when the code is in different files?

When the code is all in 1 file (Profile.js) here: https://github.com/saltycrane/flowtype-hoc-exploration/tree/fc09e5f3a0eb62d500c31d996a16610ab682f8e1

I get 2 errors as expected:

    $ npm run -s flow
    Profile.js:25
     25:   <LoggedProfile
           ^ React element `LoggedProfile`
     26:     username={1234}
                       ^^^^ number. This type is incompatible with
      6: function Profile(props:{username:string, onEdit:Function}) {
                                          ^^^^^^ string

    Profile.js:25
     25:   <LoggedProfile
           ^ React element `LoggedProfile`
     27:     onEdit={"not implemented yet"}
                     ^^^^^^^^^^^^^^^^^^^^^ string. This type is incompatible with
      6: function Profile(props:{username:string, onEdit:Function}) {
                                                         ^^^^^^^^ function type


    Found 2 errors

Then I modified the code into 2 files (App.js and Profile.js) here: https://github.com/saltycrane/flowtype-hoc-exploration/tree/4e3150217dc62ef960a8b4e80680bee772a14307

And I got this unexpected error:

    $ npm run -s flow
    Profile.js:22
     22: const LoggedProfile = logOnRender(Profile);
                               ^^^^^^^^^^^^^^^^^^^^ type parameter `FirstOrderProps` of function call. Missing annotation


    Found 1 error

Then I separated the code into 3 files (App.js, Profile.js and logOnRender.js) here: https://github.com/saltycrane/flowtype-hoc-exploration/tree/b56850c3cbf95cd9702f3e6fd53adcc4d8e760bc

And I got 0 errors which is not expected: