Giter VIP home page Giter VIP logo

git-pull-request's People

Contributors

pcl avatar

Watchers

 avatar  avatar  avatar

git-pull-request's Issues

Tests!

It'd be nice to have a test suite that generates a GitHub repo somewhere, runs some happy-path and edge cases, and reports on status.

'git pr push' fails when pushing to a branch that exists and has the same HEAD ref

To reproduce:

  1. Create a conflict
  2. git rebase ...
  3. git pr push foo branchname

Output:

fatal: ambiguous argument '': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'
Traceback (most recent call last):
  File "/usr/local/bin/git-pr", line 713, in <module>
    sys.exit(main(sys.argv))
  File "/usr/local/bin/git-pr", line 700, in main
    exit_code = git_pr(argv)
  File "/usr/local/bin/git-pr", line 602, in git_pr
    return args.func(PullRequestController(), args)
  File "/usr/local/bin/git-pr", line 548, in <lambda>
    parser_push.set_defaults(func=lambda prc, args: prc.do_push(args))
  File "/usr/local/bin/git-pr", line 265, in do_push
    return self.create_pr(args.remote, args.branch, args.reviewer)
  File "/usr/local/bin/git-pr", line 172, in create_pr
    title = sh('git', 'show', '-q', change, '--format=format:%s')
  File "/usr/local/bin/git-pr", line 532, in sh
    return str(check_output(args), 'utf-8').strip()
  File "/usr/local/opt/python/Frameworks/Python.framework/Versions/3.7/lib/python3.7/subprocess.py", line 376, in check_output
    **kwargs).stdout
  File "/usr/local/opt/python/Frameworks/Python.framework/Versions/3.7/lib/python3.7/subprocess.py", line 468, in run
    output=stdout, stderr=stderr)
subprocess.CalledProcessError: Command '('git', 'show', '-q', '', '--format=format:%s')' returned non-zero exit status 128.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.