pcman-bbs / pcmanx Goto Github PK

View Code? Open in Web Editor NEW

79.0 79.0 74.0 3.99 MB

GTK version

License: GNU General Public License v2.0

Shell 0.08% Perl 0.02% Python 0.22% C++ 9.14% C 90.04% Makefile 0.09% M4 0.39% Roff 0.01%

pcmanx's People

Contributors

Stargazers

Watchers

pcmanx's Issues

Show Web Search in right click menu only when text selection

and show the selected words in menu label of Web Search.

Have Warning on Initial the program

When open the program on shell. There are some warning print out.As the following:

(pcmanx:3853): Gtk-CRITICAL **: IA__gtk_image_get_pixbuf: assertion 'image->storage_type == GTK_IMAGE_PIXBUF || image->sto
rage_type == GTK_IMAGE_EMPTY' failed

(pcmanx:3853): GdkPixbuf-CRITICAL **: gdk_pixbuf_scale_simple: assertion 'GDK_IS_PIXBUF (src)' failed

(pcmanx:3853): GdkPixbuf-CRITICAL **: gdk_pixbuf_copy: assertion 'GDK_IS_PIXBUF (pixbuf)' failed

(pcmanx:3853): GdkPixbuf-CRITICAL **: gdk_pixbuf_get_n_channels: assertion 'GDK_IS_PIXBUF (pixbuf)' failed

(pcmanx:3853): GdkPixbuf-CRITICAL **: gdk_pixbuf_get_rowstride: assertion 'GDK_IS_PIXBUF (pixbuf)' failed

(pcmanx:3853): GdkPixbuf-CRITICAL **: gdk_pixbuf_get_width: assertion 'GDK_IS_PIXBUF (pixbuf)' failed

(pcmanx:3853): GdkPixbuf-CRITICAL **: gdk_pixbuf_get_height: assertion 'GDK_IS_PIXBUF (pixbuf)' failed

(pcmanx:3853): GdkPixbuf-CRITICAL **: gdk_pixbuf_get_pixels: assertion 'GDK_IS_PIXBUF (pixbuf)' failed

(pcmanx:3853): GLib-GObject-CRITICAL **: g_object_unref: assertion 'G_IS_OBJECT (object)' failed

It seems the problem is happened when the program initialize.

Test different configuration in travis-ci

travis-ci shall test different configuration.

參考資料

根據官網上的連結目前的 Windows 版跟 GNU/Linux 版 PCMan 雖然使用者介面類似但是出自於不同的來源碼樹，是否有合併兩者〈也就是讓其中一個版本能夠跨平台到 MS Windows 平台〉的必要性？

網址無法重複開啟

環境：Archlinux 64 bit kernel 3.19.2-1-ARCH

How to reproduce : help->about->點選任何一個網址->等待firefox開啟後->回到pcmanx->回到firefox關掉->回到pcmanx->點選網址

發生狀況：沒有反應

預期行為：開啟連結

UI for SSH connection

Now there are no UI for user to enable SSH function.

create AppData file

http://people.freedesktop.org/~hughsient/appdata/
Ref:
https://code.google.com/p/pcmanx-gtk2/issues/detail?id=75

Allow specifing the host from the command line

Allow specifing the host from the command line.
$ pcmanx ptt.cc

Add number display for post-pushing

Number display for post-pushing is good for user to interact with other user in the same post
Here is a sketch

This function also have been implemented in JPTT & MoPTT (Close Source App)

中文輸入會產生白色方塊及無法使用輸入中文

如果一開始進入時為中文輸入法，然後切換成英文輸入法打字時會產生的白色方塊，之後亦無法消除。
並且之後無法中打。

reconnect 按鈕並未將原 tab 中的連線重設

I think 'reconnect' function should let the session reconnect in 'original tab', not open a new tab.

Maybe we can close last tab and open a new tab for new connection.

add placeholder page when no connection

just like what web browsers does.

use GtkMenuBar

https://developer.gnome.org/gtk3/stable/GtkMenuBar.html

如果在設定檔內指定 UseExternelSSH 或 UseExtetrnelTelnet 應該更積極使用

因為目前使用的 build 沒有編譯 Proxy 且目前沒有常態性使用 Proxy 的需求
所以有時候會用 SSH tunnel 代替
但是在看過原始碼後發現只要使用非標準 port 就會 fallback 到內建連線

使用 oxygen-gtk2 主題時，偏好設定崩潰

從 405dc18 這個 commit 開始，
使用 oxygen-gtk2 主題時，Preference 內的 Site Settings 分頁會使得程式崩潰。

The program 'pcmanx' received an X Window System error.
This probably reflects a bug in the program.
The error was 'BadMatch (invalid parameter attributes)'.
  (Details: serial 13294 error_code 8 request_code 62 minor_code 0)
  (Note to programmers: normally, X errors are reported asynchronously;
   that is, you will receive the error a while after causing it.
   To debug your program, run it with the --sync command line
   option to change this behavior. You can then get a meaningful
   backtrace from your debugger if you break on the gdk_x_error() function.)

以下是根據提示，利用 break gdk_x_error() 讀取 backtrace 時所產生的輸出

#0  gdk_x_error (display=0x7a7e20, error=0x7fffffffc4b0) at gdkmain-x11.c:458
#1  0x00007ffff60658fd in _XError () from /usr/lib/libX11.so.6
#2  0x00007ffff6062867 in ?? () from /usr/lib/libX11.so.6
#3  0x00007ffff6062925 in ?? () from /usr/lib/libX11.so.6
#4  0x00007ffff60638d0 in _XReply () from /usr/lib/libX11.so.6
#5  0x00007ffff60498cd in XGetWindowProperty () from /usr/lib/libX11.so.6
#6  0x00007ffff75145f0 in IA__gdk_window_get_type_hint (window=0xc87360) at gdkwindow-x11.c:2117
#7  0x00007fffecffba68 in Oxygen::Gtk::gdk_window_nobackground (window=window@entry=0xc87360)
    at /home/hyslion/pkgbuild/oxygen-gtk2/src/oxygen-gtk2-1.4.5/src/oxygengtkutils.cpp:174
#8  0x00007fffed0757c0 in Oxygen::draw_flat_box (style=0xd28be0, window=0xc87360, state=13377632, shadow=GTK_SHADOW_NONE, 
    clipRect=0x7ffff7b2752c, widget=0xdaf598, detail=0x7ffff7b2752c "base", x=0, y=0, w=668, h=414)
    at /home/hyslion/pkgbuild/oxygen-gtk2/src/oxygen-gtk2-1.4.5/src/oxygenstylewrapper.cpp:153
#9  0x00007ffff7918e62 in gtk_paint_flat_box () from /usr/lib/libgtk-x11-2.0.so.0
#10 0x00007ffff79d0f1b in gtk_window_paint (widget=widget@entry=0xcc2060, area=area@entry=0x7fffffffcf84) at gtkwindow.c:6625
#11 0x00007ffff79d0f6c in gtk_window_expose (widget=0xcc2060, event=0x7fffffffcf70) at gtkwindow.c:6634
#12 0x00007ffff789184f in _gtk_marshal_BOOLEAN__BOXED (closure=0x84f140, return_value=0x7fffffffcb60, n_param_values=<optimized out>, 
    param_values=0x7fffffffcc10, invocation_hint=<optimized out>, marshal_data=0x7ffff79d0f20 <gtk_window_expose>) at gtkmarshalers.c:86
#13 0x00007ffff6ace3d8 in g_closure_invoke () from /usr/lib/libgobject-2.0.so.0
#14 0x00007ffff6adfb1b in ?? () from /usr/lib/libgobject-2.0.so.0
#15 0x00007ffff6ae7719 in g_signal_emit_valist () from /usr/lib/libgobject-2.0.so.0
#16 0x00007ffff6ae7d02 in g_signal_emit () from /usr/lib/libgobject-2.0.so.0
#17 0x00007ffff79c4a3c in gtk_widget_event_internal (widget=0xcc2060, event=0x7fffffffcf70) at gtkwidget.c:5010
#18 0x00007ffff788ee18 in gtk_main_do_event () from /usr/lib/libgtk-x11-2.0.so.0
#19 0x00007ffff74eb3bf in _gdk_window_process_updates_recurse (window=window@entry=0xc87360, expose_region=expose_region@entry=0xdd2f90)
    at gdkwindow.c:5443
#20 0x00007ffff7518b65 in _gdk_windowing_window_process_updates_recurse (window=window@entry=0xc87360, region=region@entry=0xdd2f90)
    at gdkwindow-x11.c:5643
#21 0x00007ffff74e7e38 in gdk_window_process_updates_internal (window=0xc87360) at gdkwindow.c:5610
#22 0x00007ffff74e8738 in IA__gdk_window_process_all_updates () at gdkwindow.c:5716
#23 0x00007ffff7812bd1 in gtk_container_idle_sizer (data=<optimized out>) at gtkcontainer.c:1360
#24 0x00007ffff74c8487 in gdk_threads_dispatch (data=0xdb0ae0) at gdk.c:512
#25 0x00007ffff67fea65 in g_main_context_dispatch () from /usr/lib/libglib-2.0.so.0
#26 0x00007ffff67fedc8 in ?? () from /usr/lib/libglib-2.0.so.0
#27 0x00007ffff67ff08a in g_main_loop_run () from /usr/lib/libglib-2.0.so.0
#28 0x00007ffff7815c23 in IA__gtk_dialog_run (dialog=0xcc2060) at gtkdialog.c:1094
#29 0x0000000000431a5f in CDialog::ShowModal (this=0x88f030) at dialog.cpp:68
#30 0x0000000000437439 in CMainFrame::OnPreference (mitem=0x9d69c0, _this=0x883e70) at mainframe.cpp:1155
#31 0x00007ffff6ace3d8 in g_closure_invoke () from /usr/lib/libgobject-2.0.so.0
#32 0x00007ffff6adfd5d in ?? () from /usr/lib/libgobject-2.0.so.0
#33 0x00007ffff6ae7a49 in g_signal_emit_valist () from /usr/lib/libgobject-2.0.so.0
#34 0x00007ffff6ae7d02 in g_signal_emit () from /usr/lib/libgobject-2.0.so.0
#35 0x00007ffff77d1460 in _gtk_action_emit_activate (action=0x9d69c0) at gtkaction.c:795
#36 0x00007ffff6ace3d8 in g_closure_invoke () from /usr/lib/libgobject-2.0.so.0
#37 0x00007ffff6adf577 in ?? () from /usr/lib/libgobject-2.0.so.0
#38 0x00007ffff6ae7a49 in g_signal_emit_valist () from /usr/lib/libgobject-2.0.so.0
#39 0x00007ffff6ae7d02 in g_signal_emit () from /usr/lib/libgobject-2.0.so.0
#40 0x00007ffff79c3876 in IA__gtk_widget_activate (widget=widget@entry=0x89a530) at gtkwidget.c:5041
#41 0x00007ffff78a30bd in IA__gtk_menu_shell_activate_item (menu_shell=0x998220, menu_item=0x89a530, force_deactivate=<optimized out>)
    at gtkmenushell.c:1276
#42 0x00007ffff78a343b in gtk_menu_shell_button_release (widget=0x998220, event=<optimized out>) at gtkmenushell.c:703
#43 0x00007ffff789184f in _gtk_marshal_BOOLEAN__BOXED (closure=0x84ff70, return_value=0x7fffffffdcb0, n_param_values=<optimized out>,
    param_values=0x7fffffffdd60, invocation_hint=<optimized out>, marshal_data=0x7ffff7898c10 <gtk_menu_button_release>) at gtkmarshalers.c:86
#44 0x00007ffff6ace3d8 in g_closure_invoke () from /usr/lib/libgobject-2.0.so.0
#45 0x00007ffff6adfb1b in ?? () from /usr/lib/libgobject-2.0.so.0
#46 0x00007ffff6ae7719 in g_signal_emit_valist () from /usr/lib/libgobject-2.0.so.0
#47 0x00007ffff6ae7d02 in g_signal_emit () from /usr/lib/libgobject-2.0.so.0
#48 0x00007ffff79c4a3c in gtk_widget_event_internal (widget=0x998220, event=0xc31990) at gtkwidget.c:5010
#49 0x00007ffff789054a in gtk_propagate_event () from /usr/lib/libgtk-x11-2.0.so.0
#50 0x00007ffff788f014 in gtk_main_do_event () from /usr/lib/libgtk-x11-2.0.so.0
#51 0x00007ffff75037bc in gdk_event_dispatch (source=<optimized out>, callback=<optimized out>, user_data=<optimized out>)
    at gdkevents-x11.c:2403
#52 0x00007ffff67feb84 in g_main_context_dispatch () from /usr/lib/libglib-2.0.so.0
#53 0x00007ffff67fedc8 in ?? () from /usr/lib/libglib-2.0.so.0
#54 0x00007ffff67ff08a in g_main_loop_run () from /usr/lib/libglib-2.0.so.0
#55 0x00007ffff788e59c in gtk_main () from /usr/lib/libgtk-x11-2.0.so.0
#56 0x000000000042c893 in main (argc=2, argv=0x7fffffffe3b8) at pcmanx_gtk2.cpp:190

同時也能觀察到 UAO 的下拉式選單只被繪出了一半，接著就崩潰了。而將該選單移除後就不會有問題了。

這個問題似乎只在使用 oxygen-gtk2 作為主題的時候發生，換別的主題就不會了，所以也可能是 oxygen-gtk2 的 bug。只是乍看之下 405dc18 好像沒有直接影響，沒有套用該 patch 的分支（像 master）就算用 oxygen-gtk2 也不會有問題。為什麼會產生這個錯誤呢？希望在這方面有心得的前輩可以幫忙解惑，謝謝！

Support "OpenSearch" in selection menu entry

http://www.opensearch.org/

Just like the feature in PCMan Windows version.

Ref:
https://code.google.com/p/pcmanx-gtk2/issues/detail?id=64

All the starting "l" in host address will be removed unconditionally

For example, trying to connect to labc.com will lead to a connection to abc.com.

It only works to add a backslash before l, i.e. \labc.com.

The accepted values for the Site Encoding settings does not appear to be documented anywhere, and it is unclear to me what settings should be used for sites that support utf-8 like [email protected]:23. I have so far tried "utf8", "utf-8" and various uppercase variants to no avail.

SSH 連線 UTF-8 的 PTT 無法顯示中文字元

議題描述

如標題，請參考問題重現錄影：
https://www.youtube.com/watch?v=kb_OE55G31A

回報者環境

作業系統

Ubuntu 15.10 AMD64

桌面環境

Unity

PCmanX

版本

commit ad0af3a

英文字型

Droid Sans Mono

中文字型

Droid Sans Fallback

Workaround

直接用 BIG5 模式連線，URL：[email protected]:22

Default browser

環境：Archlinux 64bit kernel 3.19.2-1-ARCH

How to reproduce :
help->about->點選任何一個網址

發生狀況：pcmanx不會找到系統預設瀏覽器(chromium)，一律以firefox開啟，儘管在preference裡面已經設定chromium也一樣，此系統預設瀏覽器是在kde裡面設定的

預期行為：pcmanx找到系統預設瀏覽器(chromium)開啟

fix fullscreen mode shortcut regression

"Shift + Enter" toggles fullscreen mode, it once worked in 1.2.

MAC系统下make时出现三个error

make[3]: Nothing to be done for all'. Making all in core make[3]: Nothing to be done forall'.
CXX pcmanx_gtk2.o
pcmanx_gtk2.cpp:88:2: error: use of undeclared identifier 'bindtextdomain'
bindtextdomain (GETTEXT_PACKAGE, LOCALEDIR);
^
pcmanx_gtk2.cpp:89:2: error: use of undeclared identifier
'bind_textdomain_codeset'
bind_textdomain_codeset(GETTEXT_PACKAGE, "UTF-8");
^
pcmanx_gtk2.cpp:90:2: error: use of undeclared identifier 'textdomain'
textdomain(GETTEXT_PACKAGE);
^
3 errors generated.
make[3]: *** [pcmanx_gtk2.o] Error 1
make[2]: *** [all-recursive] Error 1
make[1]: *** [all-recursive] Error 1
make: *** [all] Error 2

pcmanx_gtk2.cpp的那几行代码出错

支援含中文字元的網址連結

參考附圖

Add search function for favorites

After I added lots of sites into favorites, it's hard to find a setting of a specific site by just using scroll bar.
Maybe add a search function for favorites just like the same in the Site List would be a better UX.
Actually, press <ctrl> + f while viewing the Favorites list will invoke a simple search bar for users. (might be the GTK built-in function?)
If it's not that necessary to implement this emphasizing function, maybe can just add a notice like press ctrl+f to search in the Favorites list.

use GtkBuilder

to replace deprecated GtkUIManager
Ref:
https://code.google.com/p/pcmanx-gtk2/issues/detail?id=76

update homepage url in manpage

This is minor fix, but happened to fix that bug:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=635670

pcmanx-manpage.diff.txt

termdata.cpp:1231: cart before the horse

termdata.cpp:1231]: (style) Array index 'col' is used before limits check.

Source code is

   while( pattr[col].IsHyperLink() && col < m_ColsPerPage )

Only write files if really changing them

Every time one uses the program,

.pcmanx/favorites
.pcmanx/pcmanx

are written, even if unchanged.
Please only write them if changing something in them.

英文字體顯示問題

有些英文會黏在一起看不清楚(OSX)

對分頁的右鍵操作不合使用者預期

首先開啟好幾個分頁

接著對最左邊現在沒有 focus 的分頁點右鍵，選擇關閉

接著跳出視窗確認

最後發現關掉的是 focus 的視窗，而非點右鍵那個位置的視窗

預期狀況：中文字體也隨之改變