Giter VIP home page Giter VIP logo

battlebot's Introduction

BattleBot

1-Up World Badge Codacy Badge

A bot made with the Discord.js library for the 1-Up World Discord server, discord.gg/mario!

1-Up World Image

battlebot's People

Contributors

pdinsdale avatar

Stargazers

 avatar  avatar Suep Khalifa avatar  avatar  avatar

Watchers

 avatar  avatar

battlebot's Issues

Arbitrary data in source code

https://github.com/Phoenix1128/BattleBot/blob/0e8036a213d047f0370e6fa6fd571998215a233a/bot.js#L118

I don't mind this blacklist existing, but I would rather they be parsed from a text file or something like that, and possibly also excluded from the git repo but that's up to you. If you embed this in the source code, you have to restart the bot every time you update it, or do something similarly nasty. If you update it in a txt file or json, all you need to do is run a command to update the list with the new contents of the file.

Incorrect parameter usage for anonymous function

https://github.com/Phoenix1128/BattleBot/blob/0e8036a213d047f0370e6fa6fd571998215a233a/commands/factions/clear.js#L37

If an error is caught, the parameter passed in the anon function is not the same as the then block. It will simply return an error that you're meant to print to the console for description of what went wrong. collection.size will always be null; you should instead be printing it directly, and assume that the entire command failed.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.