pdugan20 / nyt-byline-chrome Goto Github PK

Thanks for creating this extension!

Unfortunately the version from the Chrome Web Store wasn't working at all for me, because it was looking for the absolute URLs coming out of the feed, whereas all the links on the NYT homepage are relative for me. (Not sure if that's a recent change or you're seeing something different.)

I fixed this by replacing

url = url.split('?')[0];

with

url = url.match(/https:\/\/[^\/]+([^\?]+)/)[1];

(I'd submit a PR but the current code isn't in the repo.)

When set to document_end, the bylines were appearing and then disappearing as the page loaded further. I didn't look into what the page was doing to clear those — I assume some view layer that's updating server-rendered components — but using document_idle fixed it for me.

Unfortunately the bylines appear a good bit later with document_idle, so an alternative would be figuring out why they're disappearing and whether there's a better trigger to use to know when it's safe to add them, but this is better than having them disappear.