peerchemist / cryptotik Goto Github PK

Can you please also add Binance exchange API support?

This decorator seems nice: https://pypi.python.org/pypi/ratelimit/1.1.0

https://stackoverflow.com/questions/40748687/python-api-rate-limiting-how-to-limit-api-calls-globally

https://exmo.com/en/api

https://coinmarketcap.com/api/

Price ticker feature sounds interesting, as well as the promise of past OHLC data.

For example Wex works differently when compared to Poloniex. With Poloniex base pair (BTC) goes first when you call the API and market pair comes second (XRP).
Implement a wrapper which would standardize this and make it all the same to library user.

https://www.bitmex.com/app/restAPI

https://www.kraken.com/help/api

Perhaps using async http://websockets.readthedocs.io/en/stable/intro.html

https://tuxexchange.com/docs

extract signature generation code from private_api and make it a separate method

Allow class methods to communicate with the exchange via proxy.

Bittrex has functioning version two of API, here is documentation: https://github.com/thebotguys/golang-bittrex-api/wiki/Bittrex-API-Reference-(Unofficial)

.

This will break compatibility, but it's a necessary step to differentiate the margin orders from limit orders.

.

Both can just be a front for existing get_orders method.

https://www.cryptopia.co.nz/Forum/Thread/255

"trades.do" should be "future_trades.do" in method def.

It should return deposit address and the message.

APIError should not be raised if remote API did not respond. Other messages are http and should be handled differently.

>>> Poloniex.get_market_depth("btc-usd")
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/lib/python3.4/site-packages/cryptotik/poloniex.py", line 179, in get_market_depth
    asks = sum([Decimal(i[1]) for i in order_book["asks"]])
KeyError: 'asks'

This error message is because btc-usd doesn't exist (usdt-btc should be used). The error should be handled better. What should be printed is something like "pair doesn't exist"

https://kucoinapidocs.docs.apiary.io/#introduction/general

Thank you very much for Binance implementation! I am getting following error when I try to use it:
"TypeError: Can't instantiate abstract class Binance with abstract methods get_nonce"

.

>>> Poloniex.get_market_depth("usdt-btc")
{'bids': Decimal('1305402.021491549563469446713'), 'asks': Decimal('738.6224445900000004128204662')}

The result should not have Decimal(

https://docs.bitfinex.com/docs

This is example
polo.get_balances()
will get an error

>>> polo.get_balances()
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
TypeError: get_balances() missing 1 required positional argument: 'pair'

This works

>>> polo.get_balances('usdt')
'0.00000000'