Enhancement: Local config about dynamic-config HOT 4 CLOSED

Hey @meaku

I created a PR, that follows your suggestion. Instead of Object.assign I used the deep-assign module, because of two reasons:

1. Object.assign is not available in node 0.12
2. Object.assign is only shallow, but imho it should be possible to also overwrite nested properties without specifying the whole child object chain in the overwrite file

Let me know what you think 😄

Ben

from dynamic-config.

Thanks for your proposal @benurb!

I like the idea of having a local config. It could be a plugin and used if needed.

Another option would be to add the logic to your config.js

//config/index.js

const path = require("path");
const dynamicConfig = require("dynamic-config");

let localConfigPath = path.join(__dirname, "config.local.js");

let config = dynamicConfig(__dirname, "config.js");

if(fs.existsSync(localConfigPath) {
    config = Object.assign(config, fs.readFileSync(localConfigPath)); 
}

module.exports = config;

But i'd be happy with a PR adding this functionality as a plugin 👍

We already have an extend plugin which reads from env and argv. Maybe it's extend/file or extend/localfile?

from dynamic-config.

Looks good! I added some comments about some copy & paste things. If you agree this PR can land :)

from dynamic-config.

Already landed in 207cd1e. Thank you guys 👍

from dynamic-config.