Comments (5)
dynamic-config
is already checking for NODE_ENV and you can use NODE_ENV=production to load the production config.
I think dynamic-config should only "listen" for NODE_ENV rather than setting it. That's more predictable for developers and has less side effects. Maybe we should add it to the README.
Agree?
from dynamic-config.
You're right, we should not alter process.env
.
But I think we should replace all examples with just env
to NODE_ENV
. It really seems like NODE_ENV
is a de-facto standard, even React uses it to toggle developer mode.
from dynamic-config.
I guess this issue can be closed then?
from dynamic-config.
Reopen if you disagree.
from dynamic-config.
Since you both seem to agree and I'm already on it, I created a PR for this.
It's only one occurrence 😃
from dynamic-config.
Related Issues (6)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dynamic-config.