peregrine66 / peregrinesview Goto Github PK

In the file WeakPropertyChangedEventHandler (ViewModels) I encountered two erros, maybe due to a previous code layout.

1. WeakPropertyChangedProperties constructor : WeakReference has a protected constructor, in fact it exposes Create static method, so the class new instance should be instantiated with :
   _weakSouce = WeakReference<INotifyPropertyChanged>.Create(source);
_weakSouce = new WeakReference<INotifyPropertyChanged>(source);

2. WeakPropertyChangedProperties CleanupEverything : _weakSouce doesnt have TryGetValue
   INotifyPropertyChanged source = _weakSouce.Target; if(source != null).....
if (_weakSource.TryGetValue)

Fontsize accepts numerical values with decimal separators e.g. <fs *1.16> this will work as expected on computers with US decimal settings.
In other countries of the world it is common to use a comma as decimal separator and the dot as thousand separator. This leads to unexpected results in the current version.
Please exchange the TryParse()… methods with invariant language versions:
=>
private static void SplitTextAtFirstTag
…
if (relativeSize)
{
if (!double.TryParse(fontSizeText, NumberStyles.Any, CultureInfo.InvariantCulture, out var relativeFontSize))
relativeFontSize = 1.0d;

                    newFontSize = relativeFontSize * fontSize;
                }
                else if (!double.TryParse(fontSizeText, NumberStyles.Any, CultureInfo.InvariantCulture, out newFontSize))
                    newFontSize = fontSize;

BusySpinner works correctly, however it reports many binding errors during runtime
e.g.:
System.Windows.Data Information: 10 : Cannot retrieve value using the binding and no valid fallback value exists; using default instead. BindingExpression:Path=Foreground; DataItem=null; target element is 'Ellipse' (Name='Item11'); target property is 'Fill' (type 'Brush')
System.Windows.Data Information: 10 : Cannot retrieve value using the binding and no valid fallback value exists; using default instead. BindingExpression:Path=ItemDiameter; DataItem=null; target element is 'Ellipse' (Name='Item11'); target property is 'Height' (type 'Double')
System.Windows.Data Information: 10 : Cannot retrieve value using the binding and no valid fallback value exists; using default instead. BindingExpression:Path=ItemDiameter; DataItem=null; target element is 'Ellipse' (Name='Item11'); target property is 'Width' (type 'Double')
System.Windows.Data Information: 10 : Cannot retrieve value using the binding and no valid fallback value exists; using default instead. BindingExpression:Path=Foreground; DataItem=null; target element is 'Ellipse' (Name='Item12'); target property is 'Fill' (type 'Brush')
System.Windows.Data Information: 10 : Cannot retrieve value using the binding and no valid fallback value exists; using default instead. BindingExpression:Path=ItemDiameter; DataItem=null; target element is 'Ellipse' (Name='Item12'); target property is 'Height' (type 'Double')
System.Windows.Data Information: 10 : Cannot retrieve value using the binding and no valid fallback value exists; using default instead. BindingExpression:Path=ItemDiameter; DataItem=null; target element is 'Ellipse' (Name='Item12'); target property is 'Width' (type 'Double')