pesco / hammer Goto Github PK

desugar functions need to check the results of recursive calls to h_desugar for NULL returns and return NULL themselves if there is a failure. otherwise h_compile will succeed with an erroneous compile.

By default scons, has -Werror=clobbered set in build and GCC 4.8.4 produces a warning for this that gets promoted to error.

It seems we can either resolve the warning or loosen the build flag.

build/opt/src/backends/regex.c: In function 'run_trace':
build/opt/src/backends/regex.c:209:75: error: argument 'trace' might be clobbered by 'longjmp' or 'vfork' [-Werror=clobbered]
 HParseResult *run_trace(HAllocator *mm__, HRVMProg *orig_prog, HRVMTrace *trace, const uint8_t *input, int len) {

try valgrind on it...

this makes the h_many tests fail.

how should it be handled?