petkivim / id-registry Goto Github PK

Acceptance criteria:

• title field's length is 100 characters

Acceptance criteria:

• statics show the number of submitted "Join the ISBN system" forms within a time period
• only forms submitted on the public site are taken into account

Identifier description is shown on publisher info view and it must be removed. Descriptions are identified by the below labels.

• COM_ISBNREGISTRY_VIEW_PUBLISHER_IDENTIFIER_STATE_ACTIVE
• COM_ISBNREGISTRY_VIEW_PUBLISHER_IDENTIFIER_STATE_CLOSED

Acceptance criteria:

• email message is sent to contact person's email address when publisher register regitration form is submitted
• email message is sent to contact person's email address when ISBN/ISMN application form is submitted
• email is sent using the language of the UI

Acceptance criteria:

• publisher search can be filtered by the length of the latest publisher identifier
• ISBN filter categories are: 1, 2, 3, 4, 5
• ISMN filter categories are: 1, 2, 3, 4, 5, 6, 7
• if publisher has multiple identifiers of different length, only the last identifier matters

Accessing publication statistics causes a PHP notice:

PHP Notice:  Undefined property: stdClass::$www in /var/www/html/administrator/components/com_isbnregistry/helpers/publication.php on line 627

Acceptance criteria:

• ISBN and ISSN application form fields must accept values with " and ' characters

Acceptance criteria:

• it's possible to export Excel or CSV file that contains a list of ISMN publishers and all their identifiers
• each publishers can appear in the list multiple times
• it's possible to set begin date and end date for the listing
• both active and passive publishers are included in the list
• lists are available on statistics popup window

Acceptance criteria:

• it must be possible to add up to 10 authors per publication
• by default there are 4 author fields on the application forms and the user can add more fields if needed
• adding new fields must be possible in the back end as well

Acceptance criteria:

• http:// is added automatically in the beginning of all the URL fields if it's missing

Acceptance criteria:

• MARC record 530 field must have subfield 9 with the value FENNI<KEEP>

Acceptance criteria:

• currently group messages are sent to publishers that have active identifier of the selected size
• group messages must be sent to all the publishers with publisher identifier of the selected size. Publishers may have multiple identifiers of different sizes, but only the last identifier counts and all the other identifiers are ignored.

How to reproduce the problem:

• create a new ISBN request
• generate ISBN identifier for the publication
• delete or cancel the generated identifier on edit publication view
• save the publication form
• reload the page
• the identifier is still stored in publication table, but removed elsewhere from the system

The cause for the problem is that the hidden input fields containing the source of the data are not updated when the identifier is deleted.

<input name="jform[publication_identifier_print]" id="jform_publication_identifier_print" value="{&quot;978-952-xx-xxxx-x&quot;:&quot;PAPERBACK&quot;}" type="hidden">

<input name="jform[publication_identifier_electronical]" id="jform_publication_identifier_electronical" value="{&quot;978-952-xx-xxxx-x&quot;:&quot;PDF&quot;}" type="hidden">

Field 530 is used if and only if both printed and electronic versions are published.

Acceptance criteria:

• printed record's 530 subfield a must contain the string defined by COM_ISBNREGISTRY_MARC_530_A_PRINT
• electronic record's 530 subfield a must contain the string defined by COM_ISBNREGISTRY_MARC_530_A_ELECTRONICAL
• field 530 does not contain other subfields besides subfield a

Acceptance criteria:

• it's possible to add publication's subtitle field to message templates by using #SUBTITLE# tag
• it's possible to use the tag in template's message part

Currently leader character position 08 value is _. Correct value for character position 08 is .

Acceptance criteria:

• archived publisher records have their own menu item on the left side menu and main menu
• it's possible to search the records by name, other names and additional info
• there's a link to full record from the search results
• full record is view only - editing is not possible

Acceptance criteria:

• MARC subfield 336 $a must start with a lower case letter

Acceptance criteria:

• "is publication public" field's default value is true on backend

Acceptance criteria:

• title field's length is 100 characters

Acceptance criteria:

• when ISBN is applied for a dissertation a "I have checked at my department/faculty that I do not get an ISBN" checkbox must be checked
• if the checkbox is not checked a warning is returned and the user is not able to proceed
• the value is not stored to the database

Acceptance criteria:

• statics show the number of submitted ISBN and ISMN application forms within a time period
• only forms submitted on the public site are taken into account

Acceptance criteria:

• issued_from_year menu contains 1900-{currentYear} from January to August
• issued_from_year menu contains 1900-{currentYear + 1} from September to December

Acceptance criteria:

• it's possible to set begin date and end date for publishers statistics search, and only publishers that have been created or modified within the given time range are included in the results
• it's possible to set begin date and end date for publications statistics search, and only publications that have been created or modified within the given time range are included in the results

Acceptance criteria:

• registration form fields question1 and question2 must accept a number range, e.g. 0-1
• application form field publishing_activity_amount must accept a number range, e.g. 0-1

856 field indicator 1 value is currently 0. The value must be changed to 4, e.g.:

856 40 ‡u http://www.lehtiluukku.fi/pub?id=98685 ‡y Linkki verkkoaineistoon

Acceptance criteria:

• publication count maximum value is checked before running validation and filtering functions
• if the received value exceeds the maximum value defined in the configuration the maximum value loaded from the configuration is used

Acceptance criteria:

• publications list created column contains date and time (currently it contains only date)

Acceptance criteria:

• printed ISSN publication's 007 field value is ta
  • current value is ta||||||||||||

Acceptance criteria:

• 250 ## $a 1. edition
• 250 ## $a 1. painos

If question_4 or question_5 contain line breaks, they do not pass client side validation. Validator must be updated:

regex = /^.{0,200}$/;
return regex.test(value);

=>

return value.length <= 200;

Acceptance criteria:

• field 776 is added if and only if both printed and electronic versions are published
• printed record's 776 field contains the string:
  • 776 08 $i Verkkoaineisto (PDF): $z xxx-xxx-xxx-xxx-xx-x $9 FENNI<KEEP>
• electronic record's 776 field contains the string:
  • 776 08 $i Painettu: $z xxx-xxx-xxx-xxx-xx-x $9 FENNI<KEEP>

Acceptance criteria:

• publisher search has email filter
  • publisher has email: yes / no
  • when yes is selected, only publishers with email address are returned
  • when no is selected, only publishers with empty email field are returned

Acceptance criteria:

• title field's length is 100 characters

Sending a group message generates warnings and notices below:

PHP Warning:  Missing argument 3 for IsbnregistryModelMessage::filterMessage(), called in administrator/components/com_isbnregistry/helpers/groupmessages-script.php on line 97 and defined in administrator/components/com_isbnregistry/models/message.php on line 401
PHP Notice:  Trying to get property of non-object in administrator/components/com_isbnregistry/models/message.php on line 402
PHP Notice:  Trying to get property of non-object in administrator/components/com_isbnregistry/models/message.php on line 404
PHP Notice:  Undefined variable: title in administrator/components/com_isbnregistry/models/message.php on line 407

Acceptance criteria:

• it's possible to export Excel or CSV file that contains a list of publishers that have been created within the given time frame
• each publishers appears in the list only once
• the first publisher identifier of each publisher is included in the list
• it's possible to set begin date and end date for the listing
• both active and passive publishers are included in the list
• ISBN publishers and ISMN publishers are available through different lists
• lists are available on statistics popup window

Acceptance criteria:

• 502 ## $a Väitöskirja $c Publisher Name $9 FENNI

Acceptance criteria:

• publisher list on backend contains name, other_names and id columns

Acceptance criteria:

• send email popup shows all the email fields without scrolling
• message field scroll bar is OK

Acceptance criteria:

• it is possible to add attachments to emails
• attachments are stored in the system
• it's possible to view the attachments afterwards

Acceptance criteria:

• it's possible to export Excel or CSV file that contains a list of publications published by ISMN author publishers
• it's possible to set begin date and end date for the listing
• lists are available on statistics popup window

Acceptance criteria:

• character position 28: _ =>
• character position 31: 0 => |
• character position 32: | =>
• character position 39: _ =>

Acceptance criteria:

• all the whitespaces and other non-numeric characters are stripped from field zip before validation
• whitespaces are stripped from the beginning and end of field phone before validation. Only digits and whitespaces are allowed inside the string. The first character can be a digit or +. All the other characters are stripped from the string.
• whitespaces are stripped from the beginning and end of fields email and www before validation
• the modified version of the field must be returned if validation fails

Acceptance criteria:

• generated MARC records do not have 538 field

Acceptance criteria:

• title field's length is 100 characters

Acceptance criteria:

• new 700 field is added for each author 2-4
  • 700 1# $a Smith, John, $g ENNAKKOTIETO
• currently only author 1 is added to the MARC record

Max length of issued_from_number field is 20 characters. Max length must be increased to 100 characters.

362 field should be added to MARC record if and only if issued_from_number field is not empty.

Acceptance criteria:

• list of publishers that did not receive the group message is available on group message's information after all the publishers related to the group message have been processed
• list of publishers without email address is equal to the list of publishers that received the message

Acceptance criteria:

• other_names type is Repeatable
• there's a single column name
• max count of other_names is 10

Acceptance criteria:

• it's possible to delete rejected publications
• it's not possible to delete publications with other status